Re: [PR] Add a preload hint for preloading mmap data on specific open calls [lucene]

ChrisHegarty commented on code in PR #14604: URL: https://github.com/apache/lucene/pull/14604#discussion_r2081913839 ## lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java: ## @@ -110,7 +111,10 @@ public Lucene99HnswVectorsReader(SegmentReadStat

Re: [PR] Add a preload hint for preloading mmap data on specific open calls [lucene]

uschindler commented on code in PR #14604: URL: https://github.com/apache/lucene/pull/14604#discussion_r2081775573 ## lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java: ## @@ -110,7 +111,10 @@ public Lucene99HnswVectorsReader(SegmentReadState

Re: [PR] Add a preload hint for preloading mmap data on specific open calls [lucene]

ChrisHegarty commented on PR #14604: URL: https://github.com/apache/lucene/pull/14604#issuecomment-2866648054 > Ahh, I saw the constant on `MMapDirectory` and failed to see that it was unused. We can of course choose to change this - enable preLoad Hints by default, but I'd rather se

Re: [PR] Add a preload hint for preloading mmap data on specific open calls [lucene]

jpountz commented on PR #14604: URL: https://github.com/apache/lucene/pull/14604#issuecomment-2866603763 Ahh, I saw the constant on `MMapDirectory` and failed to see that it was unused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Add a preload hint for preloading mmap data on specific open calls [lucene]

thecoop commented on PR #14604: URL: https://github.com/apache/lucene/pull/14604#issuecomment-2866518576 After comments from @ChrisHegarty, this PR does not change the default behaviour. You need to use the hint by calling `MMapDirectory.setPreload(PRELOAD_HINT)` -- This is an automated

Re: [PR] Add a preload hint for preloading mmap data on specific open calls [lucene]

jpountz commented on PR #14604: URL: https://github.com/apache/lucene/pull/14604#issuecomment-2866464348 Can you add a CHANGES entry for this? Similar changes have not always been well received in the past, because it increases the cost of opening a reader, even though the reader may not ne

Re: [PR] Add a preload hint for preloading mmap data on specific open calls [lucene]

ChrisHegarty merged PR #14604: URL: https://github.com/apache/lucene/pull/14604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] Add a preload hint for preloading mmap data on specific open calls [lucene]

thecoop commented on code in PR #14604: URL: https://github.com/apache/lucene/pull/14604#discussion_r2081391127 ## lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java: ## @@ -136,7 +137,8 @@ public class MMapDirectory extends FSDirectory { private BiFunction> r

Re: [PR] Add a preload hint for preloading mmap data on specific open calls [lucene]

ChrisHegarty commented on code in PR #14604: URL: https://github.com/apache/lucene/pull/14604#discussion_r2081375455 ## lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java: ## @@ -136,7 +137,8 @@ public class MMapDirectory extends FSDirectory { private BiFunctio

Re: [PR] Add a preload hint for preloading mmap data on specific open calls [lucene]

ChrisHegarty commented on code in PR #14604: URL: https://github.com/apache/lucene/pull/14604#discussion_r2081339388 ## lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java: ## @@ -110,7 +111,10 @@ public Lucene99HnswVectorsReader(SegmentReadStat

[PR] Add a preload hint for preloading mmap data on specific open calls [lucene]

thecoop opened a new pull request, #14604: URL: https://github.com/apache/lucene/pull/14604 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m