javanna commented on PR #13806:
URL: https://github.com/apache/lucene/pull/13806#issuecomment-2360422815
@cbuescher could you add an entry to CHANGES.txt, under 9.12 please? I am
thinking that this should be backported so it provides a replacement for the
deprecated method before it gets re
cbuescher commented on code in PR #13806:
URL: https://github.com/apache/lucene/pull/13806#discussion_r1766408644
##
lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java:
##
@@ -141,6 +135,11 @@ public long getTermsCount() {
return termData.size();
}
+ pu
javanna merged PR #13806:
URL: https://github.com/apache/lucene/pull/13806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
cbuescher commented on PR #13806:
URL: https://github.com/apache/lucene/pull/13806#issuecomment-2360483799
@javanna done, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
javanna commented on PR #13806:
URL: https://github.com/apache/lucene/pull/13806#issuecomment-2360398761
Thanks for taking a look @rmuir !
I have been digging a bit through history, it seems like it used to be
possible to get all the terms via `QueryVisitor#consumeTerms`, but that cha
rmuir commented on PR #13806:
URL: https://github.com/apache/lucene/pull/13806#issuecomment-2359564950
also, it would be good to get an idea of the use-case. The problem is, this
query can hold many terms:
* getting an automaton over them isn't really a use-case, highlighting docs
is. We
rmuir commented on code in PR #13806:
URL: https://github.com/apache/lucene/pull/13806#discussion_r1765753269
##
lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java:
##
@@ -141,6 +135,11 @@ public long getTermsCount() {
return termData.size();
}
+ public
rmuir commented on PR #13806:
URL: https://github.com/apache/lucene/pull/13806#issuecomment-2359446319
and the question is not for this PR, just a general one. It seems the only
"real user" of `consumeTermsMatching` is highlighter, and building an automaton
for this thing seems to be... bot
rmuir commented on PR #13806:
URL: https://github.com/apache/lucene/pull/13806#issuecomment-2359438720
good solution. could we consider also fixing the visitor to use this
approach (vs passing a RunAutomaton or something awful?)
--
This is an automated message from the Apache Git Service.
cbuescher opened a new pull request, #13806:
URL: https://github.com/apache/lucene/pull/13806
Addresses #13778
TermInSetQuery used to have an accessor to its terms that was removed in
#12173 to protect leaking internal encoding details. This introduces an
accessor to the term data in
10 matches
Mail list logo
