rmuir commented on PR #13806: URL: https://github.com/apache/lucene/pull/13806#issuecomment-2359564950
also, it would be good to get an idea of the use-case. The problem is, this query can hold many terms: * getting an automaton over them isn't really a use-case, highlighting docs is. We should make this more efficient. This existing visitor api seems way too prescriptive: probably shouldn't be `Supplier<ByteRunAutomaton> automaton` but should probably just be `Predicate<BytesRef>` which supports composition with and/or/etc and also supports matching terms with `test(BytesRef)`. This is more general API (even if it doesn't help us with PrefixCodedTerms immediately). * for similar reasons, getting an iterator over ALL terms isn't a use-case... its a slow linear-time implementation of whatever you are doing. So it would be great to get an idea of what that is, so that we can get to a good interface eventually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
