Re: [I] How to run tests with the Panama Vector implementation [lucene]

2024-05-08 Thread via GitHub
uschindler commented on issue #13344: URL: https://github.com/apache/lucene/issues/13344#issuecomment-2100583761 Hi, thats a fine PR but it still has some problem, so I'd tend to move away from "devlopers" using CI=true and instead use another setting. Will explain in the PR. -- This is

Re: [I] How to run tests with the Panama Vector implementation [lucene]

2024-05-08 Thread via GitHub
uschindler commented on issue #13344: URL: https://github.com/apache/lucene/issues/13344#issuecomment-2100253239 P.S.: I had the same idea to enable it randomly by adding another item to the random list. Next to that, maybe the best would be to have another option to do two things:

Re: [I] How to run tests with the Panama Vector implementation [lucene]

2024-05-08 Thread via GitHub
uschindler commented on issue #13344: URL: https://github.com/apache/lucene/issues/13344#issuecomment-2100249027 Hi, sorry for being late. I am busy at moment, but as quick fix I applied locally the following: ```diff gradle/testing/randomization.gradle | 8 ++-- 1 file cha

Re: [I] How to run tests with the Panama Vector implementation [lucene]

2024-05-08 Thread via GitHub
ChrisHegarty commented on issue #13344: URL: https://github.com/apache/lucene/issues/13344#issuecomment-2100196605 @uschindler your idea above is clearly preferable, but another alternative is to just add to the set of values in `vectorsize`, that will result in enabling Panama Vector rand

Re: [I] How to run tests with the Panama Vector implementation [lucene]

2024-05-07 Thread via GitHub
ChrisHegarty commented on issue #13344: URL: https://github.com/apache/lucene/issues/13344#issuecomment-2098198314 > By the way the empty string is allowed because of this: Yes, exactly. I'm exploiting this, which is a fine way to say "default" :-) > My quickest idea would be to

Re: [I] How to run tests with the Panama Vector implementation [lucene]

2024-05-07 Thread via GitHub
uschindler commented on issue #13344: URL: https://github.com/apache/lucene/issues/13344#issuecomment-2098179725 We can change the defaults, sure. I am just afraid that Robert will be annoyed. He wants to randomly test all bit sizes. By the way the empty string is allowed because of t

Re: [I] How to run tests with the Panama Vector implementation [lucene]

2024-05-07 Thread via GitHub
ChrisHegarty commented on issue #13344: URL: https://github.com/apache/lucene/issues/13344#issuecomment-2098157117 I wonder if we can just avoid some of this complexity. For example, locally I can run all the tests with the Panama Vector implementation, by doing this: ``` $ expo

Re: [I] How to run tests with the Panama Vector implementation [lucene]

2024-05-06 Thread via GitHub
ChrisHegarty commented on issue #13344: URL: https://github.com/apache/lucene/issues/13344#issuecomment-2096743493 I really wanna spawn a new JVM with those options for a small set of tests, rather than have them infect all other running tests. -- This is an automated message from the Apa

Re: [I] How to run tests with the Panama Vector implementation [lucene]

2024-05-06 Thread via GitHub
uschindler commented on issue #13344: URL: https://github.com/apache/lucene/issues/13344#issuecomment-2096259809 No idea yet, still thinking about it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] How to run tests with the Panama Vector implementation [lucene]

2024-05-06 Thread via GitHub
uschindler commented on issue #13344: URL: https://github.com/apache/lucene/issues/13344#issuecomment-2096257331 > Those settings are really only useful when running the test which compares that the Panama and default implementations emit the same results. If we could somehow just limit set

Re: [I] How to run tests with the Panama Vector implementation [lucene]

2024-05-06 Thread via GitHub
uschindler commented on issue #13344: URL: https://github.com/apache/lucene/issues/13344#issuecomment-2095762775 see https://github.com/apache/lucene/pull/12681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [I] How to run tests with the Panama Vector implementation [lucene]

2024-05-06 Thread via GitHub
uschindler commented on issue #13344: URL: https://github.com/apache/lucene/issues/13344#issuecomment-2095759073 I think we must do some magic to not set those: https://github.com/apache/lucene/blob/40cae087f71a875478309abfc4b1ab1e7b027cab/gradle/testing/randomization.gradle#L108-L113

Re: [I] How to run tests with the Panama Vector implementation [lucene]

2024-05-06 Thread via GitHub
uschindler commented on issue #13344: URL: https://github.com/apache/lucene/issues/13344#issuecomment-2095734125 I think there should be the option to run this with defaults. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] How to run tests with the Panama Vector implementation [lucene]

2024-05-06 Thread via GitHub
uschindler commented on issue #13344: URL: https://github.com/apache/lucene/issues/13344#issuecomment-2095612656 Could it be the ";" in your command line? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] How to run tests with the Panama Vector implementation [lucene]

2024-05-06 Thread via GitHub
ChrisHegarty commented on issue #13344: URL: https://github.com/apache/lucene/issues/13344#issuecomment-2095546148 /cc @uschindler -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co