ChrisHegarty commented on issue #13344: URL: https://github.com/apache/lucene/issues/13344#issuecomment-2098157117
I wonder if we can just avoid some of this complexity. For example, locally I can run all the tests with the Panama Vector implementation, by doing this: ``` $ export CI=true; ./gradlew :lucene:core:test -Ptests.vectorsize="" -Ptests.forceintegervectors=false ``` ( setting an empty string for vectorsize results in the default vector size for the platform ) What we want to support is to allow for testing Panama Vector with different sizes during development of the code, so basically this: ``` for bits in 128 256 512; do ./gradlew -p lucene/core test --tests TestVectorUtilSupport -Dtests.vectorsize=$bits; done ``` If we just flip the defaults of these properties, vectorsize to <empty_string> and forceintegervectors to false, then all tests will use Panama Vector as appropriate - same as the "real world", while not hurting the development time usage. So the concrete proposal is to just set the default value of vectorsize to <empty_string> and forceintegervectors to false -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
