[GitHub] [lucene-solr] mikemccand commented on pull request #1552: LUCENE-8962: merge small segments on commit

2020-06-22 Thread GitBox
mikemccand commented on pull request #1552: URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-647487636 Thanks @s1monw @msfroh @msokolov! What an awesome feature and great OSS collaboration bringing it to Lucene! ---

[GitHub] [lucene-solr] mikemccand commented on pull request #1552: LUCENE-8962: merge small segments on commit

2020-06-15 Thread GitBox
mikemccand commented on pull request #1552: URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-644317157 OK I opened [this issue](https://issues.apache.org/jira/browse/LUCENE-9406) to explore how to know what specifically `IndexWriter` is doing for merge-on-commit and other

[GitHub] [lucene-solr] mikemccand commented on pull request #1552: LUCENE-8962: merge small segments on commit

2020-06-15 Thread GitBox
mikemccand commented on pull request #1552: URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-644226072 Just for my sanity to keep track of all the exciting PRs here :) Here is the original PR (that was pushed, then reverted, then led to this PR): https://github.com/apache

[GitHub] [lucene-solr] mikemccand commented on pull request #1552: LUCENE-8962: merge small segments on commit

2020-06-12 Thread GitBox
mikemccand commented on pull request #1552: URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-643496306 > @mikemccand thanks for replying to all these comments. I do understand that this change has an impact and I agree we should add this functionality. I just disagree with

[GitHub] [lucene-solr] mikemccand commented on pull request #1552: LUCENE-8962

2020-06-09 Thread GitBox
mikemccand commented on pull request #1552: URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-640678328 > The 2nd - TestPhraseWildcardQuery failure should be ignored, it's not a real issue. I'll fix that fragile test. Great, thanks @bruno-roustant! -

[GitHub] [lucene-solr] mikemccand commented on pull request #1552: LUCENE-8962

2020-06-05 Thread GitBox
mikemccand commented on pull request #1552: URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-639524684 > I'll beast this PR on my 128-core AMD Ryzen box :) I ran this overnight, consuming a lot of electricity and generating heat in my already too hot basement ;0

[GitHub] [lucene-solr] mikemccand commented on pull request #1552: LUCENE-8962

2020-06-04 Thread GitBox
mikemccand commented on pull request #1552: URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-639161416 I'll beast this PR on my 128-core AMD Ryzen box :) This is an automated message from the Apache Git Servi