dweiss commented on issue #1157: Add RAT check using Gradle
URL: https://github.com/apache/lucene-solr/pull/1157#issuecomment-574559840
Thanks Mike. I'll fix the remaining tiny issues on gradle-master.
This is an automated mes
dweiss commented on issue #1157: Add RAT check using Gradle
URL: https://github.com/apache/lucene-solr/pull/1157#issuecomment-574539229
Thanks Mike. I'll merge it in today. I actually looked at apache rat sources
yesterday -- they are indeed riddled with encoding issues (writer on top of
p
dweiss commented on issue #1157: Add RAT check using Gradle
URL: https://github.com/apache/lucene-solr/pull/1157#issuecomment-574082560
bq. One other question of best practices - do we want all the project
exclusions in a central rat.gradle file, or spread out and local to each
project?
dweiss commented on issue #1157: Add RAT check using Gradle
URL: https://github.com/apache/lucene-solr/pull/1157#issuecomment-574079514
To be honest I would prefer not to add those license headers to build files,
unless it's a requirement of apache legal -- this would have to be verified.
dweiss commented on issue #1157: Add RAT check using Gradle
URL: https://github.com/apache/lucene-solr/pull/1157#issuecomment-573698185
Once you apply the patch included in my last comment change the hardcoded
" here:
pattern(substring: "Licensed under the Apache License, Version 2.0
dweiss commented on issue #1157: Add RAT check using Gradle
URL: https://github.com/apache/lucene-solr/pull/1157#issuecomment-573688875
[patch.txt](https://github.com/apache/lucene-solr/files/4054015/patch.txt)
Updated patch. Some files still fail; it'd have to be investigated.
-
dweiss commented on issue #1157: Add RAT check using Gradle
URL: https://github.com/apache/lucene-solr/pull/1157#issuecomment-573683590
It doesn't hang. It just takes a loong time on the highlighter - don't
know why. The two failures are related to extra exclusions present in the ant
b
dweiss commented on issue #1157: Add RAT check using Gradle
URL: https://github.com/apache/lucene-solr/pull/1157#issuecomment-573680544
[patch.txt](https://github.com/apache/lucene-solr/files/4053932/patch.txt)
I reworked a few things, Mike. Now... rat hangs for me (?). I wonder if we
co
dweiss commented on issue #1157: Add RAT check using Gradle
URL: https://github.com/apache/lucene-solr/pull/1157#issuecomment-573306410
I'll take a look later, Mike. As for applying tasks and anything else --
think of the project structure as a graph. You attach things to this graph in
two
