Re: [PR] .editorconfig [lucene]

2025-06-01 Thread via GitHub
dsmiley commented on PR #14740: URL: https://github.com/apache/lucene/pull/14740#issuecomment-2928610050 I simplified the glob patterns. I realized my QA was quite flawed because I had the "Google Java Format" IntelliJ plugin installed, which overrides the style settings. I disabled

Re: [PR] .editorconfig [lucene]

2025-06-01 Thread via GitHub
github-actions[bot] commented on PR #14740: URL: https://github.com/apache/lucene/pull/14740#issuecomment-2928581410 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

Re: [PR] Fix java doc in IndexWriter. [lucene]

2025-06-01 Thread via GitHub
vsop-479 commented on code in PR #14733: URL: https://github.com/apache/lucene/pull/14733#discussion_r2119876685 ## lucene/core/src/java/org/apache/lucene/index/IndexWriter.java: ## @@ -469,9 +469,9 @@ public void onTicketBacklog() { * session can be quickly made available f

Re: [PR] Fix java doc in IndexWriter. [lucene]

2025-06-01 Thread via GitHub
github-actions[bot] commented on PR #14733: URL: https://github.com/apache/lucene/pull/14733#issuecomment-2928438304 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

Re: [PR] Add a DoubleValuesSource for scoring full precision vector similarity [lucene]

2025-06-01 Thread via GitHub
dungba88 commented on code in PR #14708: URL: https://github.com/apache/lucene/pull/14708#discussion_r2119797821 ## lucene/core/src/java/org/apache/lucene/search/ByteVectorSimilarityValuesSource.java: ## @@ -42,7 +78,35 @@ public VectorScorer getScorer(LeafReaderContext ctx) thr

[I] Can we support vectors to be loaded with direct I/O for full precision re-ranking? [lucene]

2025-06-01 Thread via GitHub
dungba88 opened a new issue, #14746: URL: https://github.com/apache/lucene/issues/14746 ### Description Spin-off from discussion in https://github.com/apache/lucene/pull/14708. One of the concern with with full precision (FP) re-ranking (for quantized vectors) is that if we use off-h

Re: [PR] deps(java): bump org.apache.rat:apache-rat from 0.14 to 0.16.1 [lucene]

2025-06-01 Thread via GitHub
github-actions[bot] commented on PR #14582: URL: https://github.com/apache/lucene/pull/14582#issuecomment-2928199733 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] build(deps): bump holidays from 0.71 to 0.73 in /dev-tools/scripts [lucene]

2025-06-01 Thread via GitHub
github-actions[bot] commented on PR #14743: URL: https://github.com/apache/lucene/pull/14743#issuecomment-2928169068 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

Re: [PR] build(deps): bump basedpyright from 1.29.1 to 1.29.2 in /dev-tools/scripts [lucene]

2025-06-01 Thread via GitHub
github-actions[bot] commented on PR #14745: URL: https://github.com/apache/lucene/pull/14745#issuecomment-2928169297 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

Re: [PR] build(deps): bump ruff from 0.11.9 to 0.11.12 in /dev-tools/scripts [lucene]

2025-06-01 Thread via GitHub
github-actions[bot] commented on PR #14744: URL: https://github.com/apache/lucene/pull/14744#issuecomment-2928169198 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

[PR] build(deps): bump holidays from 0.71 to 0.73 in /dev-tools/scripts [lucene]

2025-06-01 Thread via GitHub
dependabot[bot] opened a new pull request, #14743: URL: https://github.com/apache/lucene/pull/14743 Bumps [holidays](https://github.com/vacanza/holidays) from 0.71 to 0.73. Release notes Sourced from https://github.com/vacanza/holidays/releases";>holidays's releases. v0.73

[PR] build(deps): bump basedpyright from 1.29.1 to 1.29.2 in /dev-tools/scripts [lucene]

2025-06-01 Thread via GitHub
dependabot[bot] opened a new pull request, #14745: URL: https://github.com/apache/lucene/pull/14745 Bumps [basedpyright](https://github.com/detachhead/basedpyright) from 1.29.1 to 1.29.2. Commits https://github.com/DetachHead/basedpyright/commit/cc4dcede985490e029945df0981b644b

Re: [PR] Add a DoubleValuesSource for scoring full precision vector similarity [lucene]

2025-06-01 Thread via GitHub
vigyasharma commented on PR #14708: URL: https://github.com/apache/lucene/pull/14708#issuecomment-2928167858 Moved full precision scores logic to a separate `FullPrecisionFloatVectorSimilarityValuesSource` that can take a custom vector similarity function. -- This is an automated message

[PR] build(deps): bump ruff from 0.11.9 to 0.11.12 in /dev-tools/scripts [lucene]

2025-06-01 Thread via GitHub
dependabot[bot] opened a new pull request, #14744: URL: https://github.com/apache/lucene/pull/14744 Bumps [ruff](https://github.com/astral-sh/ruff) from 0.11.9 to 0.11.12. Release notes Sourced from https://github.com/astral-sh/ruff/releases";>ruff's releases. 0.11.12 Rele

Re: [PR] Add a DoubleValuesSource for scoring full precision vector similarity [lucene]

2025-06-01 Thread via GitHub
github-actions[bot] commented on PR #14708: URL: https://github.com/apache/lucene/pull/14708#issuecomment-2928159436 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

Re: [PR] Keep evaluating conjunction one doc-at-a-time until dynamic pruning kicks in. [lucene]

2025-06-01 Thread via GitHub
gf2121 commented on code in PR #14739: URL: https://github.com/apache/lucene/pull/14739#discussion_r2119549265 ## lucene/core/src/java/org/apache/lucene/search/BlockMaxConjunctionBulkScorer.java: ## @@ -87,18 +87,64 @@ public int score(LeafCollector collector, Bits acceptDocs,

Re: [PR] Keep evaluating conjunction one doc-at-a-time until dynamic pruning kicks in. [lucene]

2025-06-01 Thread via GitHub
jpountz commented on code in PR #14739: URL: https://github.com/apache/lucene/pull/14739#discussion_r2119453329 ## lucene/core/src/java/org/apache/lucene/search/BlockMaxConjunctionBulkScorer.java: ## @@ -87,18 +87,64 @@ public int score(LeafCollector collector, Bits acceptDocs,

Re: [PR] Fix: Include tests.jvmargs in "Reproduce with" output [lucene]

2025-06-01 Thread via GitHub
github-actions[bot] commented on PR #14742: URL: https://github.com/apache/lucene/pull/14742#issuecomment-2927705148 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

[PR] Fix: Include tests.jvmargs in "Reproduce with" output [lucene]

2025-06-01 Thread via GitHub
N624-debu opened a new pull request, #14742: URL: https://github.com/apache/lucene/pull/14742 Appended tests.jvmargs from system properties to support accurate reproduction lines. ### Description This patch fixes an issue where the "Reproduce with" line generated by the test r

Re: [I] Failing test: TestSpellChecking.testGeneratedSuggestions — ComparisonFailure with expected suggestion list [lucene]

2025-06-01 Thread via GitHub
N624-debu commented on issue #14741: URL: https://github.com/apache/lucene/issues/14741#issuecomment-2927483252 Thanks for the suggestion, @vigyasharma. I’d be happy to take a look at fixing the test output formatting and open a PR for it. -- This is an automated message from the

Re: [PR] Support for Re-Ranking Queries using Late Interaction Model Multi-Vectors. [lucene]

2025-06-01 Thread via GitHub
romseygeek commented on PR #14729: URL: https://github.com/apache/lucene/pull/14729#issuecomment-2927412166 The advantage of a `Rescorer` is that is is explicitly only run over the hits in a `TopDocs` instance, whereas `FunctionScoreQuery` will run over the entire docid space if you let it.

Re: [PR] Keep evaluating conjunction one doc-at-a-time until dynamic pruning kicks in. [lucene]

2025-06-01 Thread via GitHub
gf2121 commented on code in PR #14739: URL: https://github.com/apache/lucene/pull/14739#discussion_r2117962626 ## lucene/core/src/java/org/apache/lucene/search/BlockMaxConjunctionBulkScorer.java: ## @@ -87,18 +87,64 @@ public int score(LeafCollector collector, Bits acceptDocs,

Re: [PR] .editorconfig [lucene]

2025-06-01 Thread via GitHub
vigyasharma commented on PR #14740: URL: https://github.com/apache/lucene/pull/14740#issuecomment-2926728995 > I'm fine with adding these hints, although I don't use this convention myself Oh wait, I thought these changes were coming from the `editorconfig` in this PR. But looks like

Re: [PR] Add a DoubleValuesSource for scoring full precision vector similarity [lucene]

2025-06-01 Thread via GitHub
vigyasharma commented on code in PR #14708: URL: https://github.com/apache/lucene/pull/14708#discussion_r2118820224 ## lucene/core/src/java/org/apache/lucene/search/ByteVectorSimilarityValuesSource.java: ## @@ -42,7 +78,35 @@ public VectorScorer getScorer(LeafReaderContext ctx)

Re: [PR] Add a DoubleValuesSource for scoring full precision vector similarity [lucene]

2025-06-01 Thread via GitHub
vigyasharma commented on code in PR #14708: URL: https://github.com/apache/lucene/pull/14708#discussion_r2118819077 ## lucene/core/src/java/org/apache/lucene/search/ByteVectorSimilarityValuesSource.java: ## @@ -42,7 +78,35 @@ public VectorScorer getScorer(LeafReaderContext ctx)