vigyasharma commented on PR #14740: URL: https://github.com/apache/lucene/pull/14740#issuecomment-2926728995
> I'm fine with adding these hints, although I don't use this convention myself Oh wait, I thought these changes were coming from the `editorconfig` in this PR. But looks like it's adding some stuff from my local IDE setup, duh! Surprising because I don't use this convention either! > Robert's comments should probably be reviewed and applied first - especially if adding this file may result in corruping certain file types (Makefile). 100% agree. We also don't need to add any extra hints, as long as we have parity with the tidy bot, and reformatting with this config doesn't change existing committed code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
