Re: [I] Could/should KNN queries use per-segment query caching? [lucene]

2025-05-21 Thread via GitHub
rmuir commented on issue #14669: URL: https://github.com/apache/lucene/issues/14669#issuecomment-2899564405 for an http-based service, you can accomplish this by setting cache headers correctly as well. then the caching is much more flexible: can happen on user's device/client, load balance

Re: [PR] Introduce a mapping to map sparse labels to a continuous range [lucene]

2025-05-21 Thread via GitHub
github-actions[bot] commented on PR #14494: URL: https://github.com/apache/lucene/pull/14494#issuecomment-2899568006 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Fix AbstractRangeQueryNode#toQueryString [lucene]

2025-05-21 Thread via GitHub
stefanvodita commented on code in PR #14697: URL: https://github.com/apache/lucene/pull/14697#discussion_r2101276705 ## lucene/queryparser/src/test/org/apache/lucene/queryparser/flexible/standard/nodes/TestAbstractRangeQueryNode.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the

[PR] Fix AbstractRangeQueryNode#toQueryString [lucene]

2025-05-21 Thread via GitHub
phb-ig opened a new pull request, #14697: URL: https://github.com/apache/lucene/pull/14697 Re: #7865 It now returns a string which is valid Lucene range query syntax and can be parsed back into the original node. Added public method `getTermEscaped(EscapeQuerySyntax)` to `Valu

Re: [PR] Add assumption to ignore test failures due to disconnected graphs [lucene]

2025-05-21 Thread via GitHub
github-actions[bot] commented on PR #14696: URL: https://github.com/apache/lucene/pull/14696#issuecomment-2898976362 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

[PR] Add assumption to ignore test failures due to disconnected graphs [lucene]

2025-05-21 Thread via GitHub
msokolov opened a new pull request, #14696: URL: https://github.com/apache/lucene/pull/14696 We've seen a occasional test failures like this one: gradlew test --tests TestFloatVectorSimilarityQuery.testTimeout -Dtests.seed=B1F95AA82C52ACA8 -Dtests.multiplier=3 -Dtests.locale=nl-BE

Re: [PR] Minor access modifier adjustment to a couple of lucene90 backward compat types [lucene]

2025-05-21 Thread via GitHub
github-actions[bot] commented on PR #14695: URL: https://github.com/apache/lucene/pull/14695#issuecomment-2898413053 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

[PR] Minor access modifier adjustment to a couple of lucene90 backward compat types [lucene]

2025-05-21 Thread via GitHub
ChrisHegarty opened a new pull request, #14695: URL: https://github.com/apache/lucene/pull/14695 This commit makes a minor adjustment to a couple of lucene90 backward compat types to avoid duplicating them for older code. -- This is an automated message from the Apache Git Service. To res

Re: [PR] Use a hint to specify READONCE IOContext [lucene]

2025-05-21 Thread via GitHub
thecoop commented on code in PR #14509: URL: https://github.com/apache/lucene/pull/14509#discussion_r2100453646 ## lucene/core/src/java/org/apache/lucene/store/IOContext.java: ## @@ -56,7 +56,7 @@ interface FileOpenHint {} * This context should only be used when the read ope

Re: [I] Could/should KNN queries use per-segment query caching? [lucene]

2025-05-21 Thread via GitHub
jpountz commented on issue #14669: URL: https://github.com/apache/lucene/issues/14669#issuecomment-2897936261 I wonder if this use-case would be better served by something like Elasticsearch's shard request cache. The cache key is the whole request (query, number of hits retrieved, etc.), p

Re: [I] Integrate a JVector codec for KNN searches [lucene]

2025-05-21 Thread via GitHub
jpountz commented on issue #14681: URL: https://github.com/apache/lucene/issues/14681#issuecomment-2897879834 > sandbox Nit: it's fine for any codec to live in `lucene/codecs` in my opinion, the bar isn't much higher than sandbox, and this allows us to put them into codec randomizati

Re: [PR] Speed up exhaustive evaluation. [lucene]

2025-05-21 Thread via GitHub
jpountz commented on PR #14679: URL: https://github.com/apache/lucene/pull/14679#issuecomment-2897806175 CheckIndex integration is pushed, I hooked into a place where we were already exhaustively consuming the `PostingsEnum` anyway, so it shouldn't cause a major slowdown. -- This is an a

Re: [PR] A specialized Trie for Block Tree Index [lucene]

2025-05-21 Thread via GitHub
jpountz commented on PR #14333: URL: https://github.com/apache/lucene/pull/14333#issuecomment-2897729953 This is great info, thanks for sharing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] A specialized Trie for Block Tree Index [lucene]

2025-05-21 Thread via GitHub
mikemccand commented on PR #14333: URL: https://github.com/apache/lucene/pull/14333#issuecomment-2897725511 Thank you @Coqueue. > ran it against an Amazon Search internal benchmark, from which we observed an increase of 2.7% in Searcher throughput : D Small correction: Amazon P

Re: [PR] Speed up exhaustive evaluation. [lucene]

2025-05-21 Thread via GitHub
gf2121 commented on code in PR #14679: URL: https://github.com/apache/lucene/pull/14679#discussion_r2099773865 ## lucene/core/src/java/org/apache/lucene/search/Scorer.java: ## @@ -76,4 +77,57 @@ public int advanceShallow(int target) throws IOException { * {@link #advanceShal

Re: [PR] Speed up exhaustive evaluation. [lucene]

2025-05-21 Thread via GitHub
gf2121 commented on code in PR #14679: URL: https://github.com/apache/lucene/pull/14679#discussion_r2099767800 ## lucene/core/src/java/org/apache/lucene/search/TermScorer.java: ## @@ -120,4 +126,54 @@ public void setMinCompetitiveScore(float minScore) { impactsDisi.setMin

Re: [PR] Speed up exhaustive evaluation. [lucene]

2025-05-21 Thread via GitHub
jpountz commented on PR #14679: URL: https://github.com/apache/lucene/pull/14679#issuecomment-2897149675 Thanks for the feedback, both. I added coverage to `BasePostingsFormatTestCase`. `TestDuelingCodecs` is a bit tricky since implementations are free to return buffers of arbitrary sizes.

Re: [PR] Speed up exhaustive evaluation. [lucene]

2025-05-21 Thread via GitHub
jpountz commented on code in PR #14679: URL: https://github.com/apache/lucene/pull/14679#discussion_r2099741906 ## lucene/core/src/java/org/apache/lucene/search/Scorer.java: ## @@ -76,4 +77,57 @@ public int advanceShallow(int target) throws IOException { * {@link #advanceSha

Re: [PR] Specify and test that IOContext is immutable [lucene]

2025-05-21 Thread via GitHub
ChrisHegarty merged PR #14686: URL: https://github.com/apache/lucene/pull/14686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] Speed up exhaustive evaluation. [lucene]

2025-05-21 Thread via GitHub
gf2121 commented on code in PR #14679: URL: https://github.com/apache/lucene/pull/14679#discussion_r2099660480 ## lucene/core/src/java/org/apache/lucene/index/PostingsEnum.java: ## @@ -97,4 +98,44 @@ protected PostingsEnum() {} * anything (neither members of the returned Byt

Re: [PR] DocIdRunEnd implementation missed in Lucene103PostingsReader [lucene]

2025-05-21 Thread via GitHub
gf2121 commented on PR #14693: URL: https://github.com/apache/lucene/pull/14693#issuecomment-2896897637 Test failure is unrelated, i raised https://github.com/apache/lucene/issues/14694. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Speed up exhaustive evaluation. [lucene]

2025-05-21 Thread via GitHub
gf2121 commented on code in PR #14679: URL: https://github.com/apache/lucene/pull/14679#discussion_r2099522207 ## lucene/core/src/java/org/apache/lucene/search/Scorer.java: ## @@ -76,4 +77,57 @@ public int advanceShallow(int target) throws IOException { * {@link #advanceShal

Re: [PR] deps(java): bump org.eclipse.jgit:org.eclipse.jgit from 7.2.0.202503040940-r to 7.2.1.202505142326-r [lucene]

2025-05-21 Thread via GitHub
dweiss merged PR #14692: URL: https://github.com/apache/lucene/pull/14692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] deps(java): bump org.gradle.toolchains.foojay-resolver-convention from 0.10.0 to 1.0.0 [lucene]

2025-05-21 Thread via GitHub
dweiss merged PR #14691: URL: https://github.com/apache/lucene/pull/14691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[PR] DocIdRunEnd implementation missed in Lucene103PostingsReader [lucene]

2025-05-21 Thread via GitHub
gf2121 opened a new pull request, #14693: URL: https://github.com/apache/lucene/pull/14693 The `docIdRunEnd` implementation of postings (introduced in #14390) missed in `Lucene103PostingsReader`. Thanks @bugmakerr for finding this and reminding me! -- This is an automated messa