thecoop commented on code in PR #14509:
URL: https://github.com/apache/lucene/pull/14509#discussion_r2100453646
##########
lucene/core/src/java/org/apache/lucene/store/IOContext.java:
##########
@@ -56,7 +56,7 @@ interface FileOpenHint {}
* <p>This context should only be used when the read operations will be
performed in the same
* thread as the thread that opens the underlying storage.
*/
- IOContext READONCE = new DefaultIOContext(DataAccessHint.SEQUENTIAL);
+ IOContext READONCE = new DefaultIOContext(DataAccessHint.SEQUENTIAL,
ReadOnceHint.INSTANCE);
Review Comment:
`Lucene99FlatVectorsReader` uses `SEQUENTIAL for merge operations - as does
the built-in `merge` and `flush` IOContexts. Would those have the same access
pattern as `READONCE` - read from the start, all the way through, with no
significant pauses?
##########
lucene/core/src/java/org/apache/lucene/store/IOContext.java:
##########
@@ -56,7 +56,7 @@ interface FileOpenHint {}
* <p>This context should only be used when the read operations will be
performed in the same
* thread as the thread that opens the underlying storage.
*/
- IOContext READONCE = new DefaultIOContext(DataAccessHint.SEQUENTIAL);
+ IOContext READONCE = new DefaultIOContext(DataAccessHint.SEQUENTIAL,
ReadOnceHint.INSTANCE);
Review Comment:
`Lucene99FlatVectorsReader` uses `SEQUENTIAL` for merge operations - as does
the built-in `merge` and `flush` IOContexts. Would those have the same access
pattern as `READONCE` - read from the start, all the way through, with no
significant pauses?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
