Re: [I] Nightly benchmark regression on 2025.05.01 [lucene]

2025-05-18 Thread via GitHub
mikemccand commented on issue #14630: URL: https://github.com/apache/lucene/issues/14630#issuecomment-2889212582 OK thank you @jpountz and @rmuir! Downgrading the kernel to 6.12.4 indeed recovered our lost performance, so it looks like that change in HZ (how many time slices the Linux sche

Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]

2025-05-18 Thread via GitHub
dweiss commented on PR #14684: URL: https://github.com/apache/lucene/pull/14684#issuecomment-2889161433 I've no idea, to be honest. I also have sha256sum on my mac but it's relatively new... hard to tell where it comes from. I went with the suggestion on that gh issue I referenced. I don't

Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]

2025-05-18 Thread via GitHub
dweiss merged PR #14684: URL: https://github.com/apache/lucene/pull/14684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]

2025-05-18 Thread via GitHub
rmuir commented on PR #14684: URL: https://github.com/apache/lucene/pull/14684#issuecomment-2889155275 on the mac it has this `shasum` just due to perl, so I think that's all that is happening. Not sure if it requires `xcode` installation to be present? But I guess here it is more common,

Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]

2025-05-18 Thread via GitHub
dweiss commented on PR #14684: URL: https://github.com/apache/lucene/pull/14684#issuecomment-2889150872 Ok, both linux and mac seem to work fine after your tweak (and with cached gradle-wrapper.jar, so I assume the checksum command has been triggered) - ![image](https://github.com/user-a

Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]

2025-05-18 Thread via GitHub
github-actions[bot] commented on PR #14684: URL: https://github.com/apache/lucene/pull/14684#issuecomment-2889150241 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]

2025-05-18 Thread via GitHub
dweiss commented on code in PR #14684: URL: https://github.com/apache/lucene/pull/14684#discussion_r2094599576 ## gradlew: ## @@ -222,7 +222,12 @@ if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then fi GRADLE_WRAPPER_JAR="$APP_HOME/gradle/wrapper/gradle-wrapper.jar" -if ! (

Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]

2025-05-18 Thread via GitHub
rmuir commented on code in PR #14684: URL: https://github.com/apache/lucene/pull/14684#discussion_r2094599378 ## gradlew: ## @@ -222,7 +222,12 @@ if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then fi GRADLE_WRAPPER_JAR="$APP_HOME/gradle/wrapper/gradle-wrapper.jar" -if ! (

Re: [I] gradle-wrapper.jar http 429 (too many requests) from github [lucene]

2025-05-18 Thread via GitHub
dweiss closed issue #14683: gradle-wrapper.jar http 429 (too many requests) from github URL: https://github.com/apache/lucene/issues/14683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]

2025-05-18 Thread via GitHub
rmuir commented on code in PR #14684: URL: https://github.com/apache/lucene/pull/14684#discussion_r2094599073 ## gradlew: ## @@ -222,7 +222,12 @@ if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then fi GRADLE_WRAPPER_JAR="$APP_HOME/gradle/wrapper/gradle-wrapper.jar" -if ! (

Re: [I] gradle-wrapper.jar http 429 (too many requests) from github [lucene]

2025-05-18 Thread via GitHub
dweiss commented on issue #14683: URL: https://github.com/apache/lucene/issues/14683#issuecomment-2889148906 Seems like it's working - ![Image](https://github.com/user-attachments/assets/fad370e3-bc75-4fa9-889c-8680776be09a) -- This is an automated message from the Apache Git Servi

Re: [I] gradle-wrapper.jar http 429 (too many requests) from github [lucene]

2025-05-18 Thread via GitHub
dweiss commented on issue #14683: URL: https://github.com/apache/lucene/issues/14683#issuecomment-2889147432 It is a good idea indeed. If the problem persists, I'll do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]

2025-05-18 Thread via GitHub
github-actions[bot] commented on PR #14684: URL: https://github.com/apache/lucene/pull/14684#issuecomment-2889147213 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

[PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]

2025-05-18 Thread via GitHub
dweiss opened a new pull request, #14684: URL: https://github.com/apache/lucene/pull/14684 I just noticed that sha256sum is not present on github's mac vms. https://github.com/actions/runner-images/issues/90 This patch switches to using shasum on darwin and adds a pre-check to see

Re: [PR] Add Query for reranking KnnFloatVectorQuery with full-precision vectors [lucene]

2025-05-18 Thread via GitHub
vigyasharma commented on PR #14009: URL: https://github.com/apache/lucene/pull/14009#issuecomment-2889130972 > The graph is a bit confusing, but the dots are the oversample (from 1 to 5). This is the piece I was missing! Can we edit the [benchmark comment](https://github.com/apache/l

Re: [PR] Support adaptive refresh in Searcher Managers. [lucene]

2025-05-18 Thread via GitHub
vigyasharma merged PR #14443: URL: https://github.com/apache/lucene/pull/14443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

[I] gradle-wrapper.jar http 429 (too many requests) from github [lucene]

2025-05-18 Thread via GitHub
dweiss opened a new issue, #14683: URL: https://github.com/apache/lucene/issues/14683 ### Description We see more of these. I'll add http 429 to WrapperDownloader but we may think of another way to do it, eventually. ### Version and environment details _No response_ --

Re: [I] gradle-wrapper.jar http 429 (too many requests) from github [lucene]

2025-05-18 Thread via GitHub
dweiss commented on issue #14683: URL: https://github.com/apache/lucene/issues/14683#issuecomment-2889005053 I need to leave now but will try the caching trick later. I would place this jar on Lucene's data storage but am afraid of abuse by other projects. ;) There is a long story of

Re: [I] gradle-wrapper.jar http 429 (too many requests) from github [lucene]

2025-05-18 Thread via GitHub
dweiss commented on issue #14683: URL: https://github.com/apache/lucene/issues/14683#issuecomment-2889003536 For github workflows, we could configure regular gh caching just on this file (and keyed by gradle-wrapper.jar.sha256). Alternatively, we could put gradle-wrapper.jar on Lucene's own

Re: [I] gradle-wrapper.jar http 429 (too many requests) from github [lucene]

2025-05-18 Thread via GitHub
rmuir commented on issue #14683: URL: https://github.com/apache/lucene/issues/14683#issuecomment-2889003464 it is caused by the rate limit changes on GH side. https://github.blog/changelog/2025-05-08-updated-rate-limits-for-unauthenticated-requests/ Can we cache this binary somehow to

Re: [PR] deps(java): bump org.apache.rat:apache-rat from 0.14 to 0.16.1 [lucene]

2025-05-18 Thread via GitHub
github-actions[bot] commented on PR #14582: URL: https://github.com/apache/lucene/pull/14582#issuecomment-2888991972 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

Re: [PR] upgrade from rat 0.14 to rat 0.15 [lucene]

2025-05-18 Thread via GitHub
rmuir merged PR #14648: URL: https://github.com/apache/lucene/pull/14648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

Re: [PR] build: configure 3 retries for all gradle Download tasks [lucene]

2025-05-18 Thread via GitHub
rmuir merged PR #14653: URL: https://github.com/apache/lucene/pull/14653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

Re: [PR] tests: decrease maximum number of threads in seq number test to avoid OOM [lucene]

2025-05-18 Thread via GitHub
rmuir merged PR #14670: URL: https://github.com/apache/lucene/pull/14670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

Re: [I] Filters cannot be set in Analysis [lucene]

2025-05-18 Thread via GitHub
dweiss closed issue #14649: Filters cannot be set in Analysis URL: https://github.com/apache/lucene/issues/14649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Fix for add char and token filters in Luke Analysis tab [lucene]

2025-05-18 Thread via GitHub
pseudo-nymous commented on PR #14682: URL: https://github.com/apache/lucene/pull/14682#issuecomment-2888961089 Happy to contribute! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Fix for add char and token filters in Luke Analysis tab [lucene]

2025-05-18 Thread via GitHub
dweiss merged PR #14682: URL: https://github.com/apache/lucene/pull/14682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Fix for add char and token filters in Luke Analysis tab [lucene]

2025-05-18 Thread via GitHub
dweiss commented on PR #14682: URL: https://github.com/apache/lucene/pull/14682#issuecomment-2888960145 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Fix for add char and token filters in Luke Analysis tab [lucene]

2025-05-18 Thread via GitHub
dweiss commented on PR #14682: URL: https://github.com/apache/lucene/pull/14682#issuecomment-277887 This is a bug - thank you. Could you also add a CHANGES.txt entry under 10.3.0? I'll merge and backport. -- This is an automated message from the Apache Git Service. To respond to the m