rmuir commented on code in PR #14684:
URL: https://github.com/apache/lucene/pull/14684#discussion_r2094599073
##########
gradlew:
##########
@@ -222,7 +222,12 @@ if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
fi
GRADLE_WRAPPER_JAR="$APP_HOME/gradle/wrapper/gradle-wrapper.jar"
-if ! ( cd "$APP_HOME/gradle/wrapper" && sha256sum --status -c
"${GRADLE_WRAPPER_JAR}.sha256" ); then
+if [ "$darwin" ]; then
Review Comment:
I'm pretty sure this will execute always as written, even when
`darwin=false`.
I would instead use it the same way as the variable is used elsewhere in the
script, without putting it inside of `test`:
```suggestion
if "$darwin"; then
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
