Re: [I] Tone down TestIndexWriterDelete.testDeleteAllRepeated (OOMs sometimes) [lucene]

2025-04-15 Thread via GitHub
dweiss commented on issue #14508: URL: https://github.com/apache/lucene/issues/14508#issuecomment-2808569567 @msfroh would you know how to tackle this better than forcing FSDirectory in this test? -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [I] Tone down TestIndexWriterDelete.testDeleteAllRepeated (OOMs sometimes) [lucene]

2025-04-15 Thread via GitHub
dweiss commented on issue #14508: URL: https://github.com/apache/lucene/issues/14508#issuecomment-2808566689 Originally added in #10657. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[I] Tone down TestIndexWriterDelete.testDeleteAllRepeated (OOMs sometimes) [lucene]

2025-04-15 Thread via GitHub
dweiss opened a new issue, #14508: URL: https://github.com/apache/lucene/issues/14508 ### Description This tests OOMs on nightly runs sometimes - when its directory implementation is picked to be in ram. ![Image](https://github.com/user-attachments/assets/365028a7-237c-426f-ae

Re: [PR] MultiRange query for SortedNumeric DocValues [lucene]

2025-04-15 Thread via GitHub
mkhludnev commented on PR #14404: URL: https://github.com/apache/lucene/pull/14404#issuecomment-2808554795 @gsmiller do you have a chance look through? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] MultiRange query for SortedNumeric DocValues [lucene]

2025-04-15 Thread via GitHub
Copilot commented on code in PR #14404: URL: https://github.com/apache/lucene/pull/14404#discussion_r2046173651 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/SortedNumericDocValuesMultiRangeQuery.java: ## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software Fo

Re: [I] smokeTestRelease broken after versions.toml moved [lucene]

2025-04-15 Thread via GitHub
dweiss closed issue #14507: smokeTestRelease broken after versions.toml moved URL: https://github.com/apache/lucene/issues/14507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] smokeTestRelease broken after versions.toml moved [lucene]

2025-04-15 Thread via GitHub
dweiss commented on issue #14507: URL: https://github.com/apache/lucene/issues/14507#issuecomment-2808483323 Fixed: https://github.com/apache/lucene/actions/runs/14485791824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[I] smokeTestRelease broken after versions.toml moved [lucene]

2025-04-15 Thread via GitHub
dweiss opened a new issue, #14507: URL: https://github.com/apache/lucene/issues/14507 ### Description https://github.com/apache/lucene/actions/runs/14483476152/job/40624702365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[I] Run a workflow on dependabot's PRs (gradlew updateLicenses) [lucene]

2025-04-15 Thread via GitHub
dweiss opened a new issue, #14506: URL: https://github.com/apache/lucene/issues/14506 ### Description This would have to be very selective - only on pull_request, only on specific branch paths (dependabot/gradle/*). It'd need a write access to the branch, run updateLicenses, then com

Re: [PR] MultiRange query for SortedNumericc DocValues [lucene]

2025-04-15 Thread via GitHub
github-actions[bot] commented on PR #14404: URL: https://github.com/apache/lucene/pull/14404#issuecomment-2807845769 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] PointInSetQuery use reverse collection to improve performance [lucene]

2025-04-15 Thread via GitHub
github-actions[bot] commented on PR #14352: URL: https://github.com/apache/lucene/pull/14352#issuecomment-2807846493 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

[PR] deps(java): bump com.github.luben:zstd-jni from 1.5.5-11 to 1.5.7-2 [lucene]

2025-04-15 Thread via GitHub
dependabot[bot] opened a new pull request, #14505: URL: https://github.com/apache/lucene/pull/14505 Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.5-11 to 1.5.7-2. Commits https://github.com/luben/zstd-jni/commit/88892eb44549a214ba4c23459618b9d5d6

[PR] deps(java): bump com.carrotsearch.randomizedtesting:randomizedtesting-runner from 2.8.1 to 2.8.3 [lucene]

2025-04-15 Thread via GitHub
dependabot[bot] opened a new pull request, #14504: URL: https://github.com/apache/lucene/pull/14504 Bumps com.carrotsearch.randomizedtesting:randomizedtesting-runner from 2.8.1 to 2.8.3. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibili

[PR] deps(java): bump de.undercouch.download from 5.2.0 to 5.6.0 [lucene]

2025-04-15 Thread via GitHub
dependabot[bot] opened a new pull request, #14503: URL: https://github.com/apache/lucene/pull/14503 Bumps [de.undercouch.download](https://github.com/michel-kraemer/gradle-download-task) from 5.2.0 to 5.6.0. Release notes Sourced from https://github.com/michel-kraemer/gradle-downl

[PR] deps(java): bump xerces:xercesImpl from 2.12.0 to 2.12.2 [lucene]

2025-04-15 Thread via GitHub
dependabot[bot] opened a new pull request, #14502: URL: https://github.com/apache/lucene/pull/14502 Bumps xerces:xercesImpl from 2.12.0 to 2.12.2. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=xerces:xercesImp

Re: [PR] Remove dependabot pr limit=1 for java and actions ecosystems [lucene]

2025-04-15 Thread via GitHub
rmuir merged PR #14501: URL: https://github.com/apache/lucene/pull/14501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

Re: [PR] Remove dependabot pr limit=1 for java and actions ecosystems [lucene]

2025-04-15 Thread via GitHub
rmuir commented on PR #14501: URL: https://github.com/apache/lucene/pull/14501#issuecomment-2807751266 this will probably result in a quantity of PRs... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] OptimisticKnnVectorQuery [lucene]

2025-04-15 Thread via GitHub
msokolov commented on PR #14226: URL: https://github.com/apache/lucene/pull/14226#issuecomment-2807641552 > I'm also in favor of making this the default behavior. Maybe we can let the lambda parameter to be tuned with a reasonable default value (similar to greediness in the current collecto

Re: [PR] Add a Faiss codec for KNN searches [lucene]

2025-04-15 Thread via GitHub
msokolov commented on PR #14178: URL: https://github.com/apache/lucene/pull/14178#issuecomment-2807590241 I don't think we should block on the luceneutil improvements. Do we have consensus that this should become the default as implemented by AbstractKnnVectorQuery? We've done some testing

Re: [I] Dynamic threshold for DocIdSetBuilder [lucene]

2025-04-15 Thread via GitHub
jainankitk commented on issue #14485: URL: https://github.com/apache/lucene/issues/14485#issuecomment-2807333746 I was wondering how do is the min/max docId partitioning managed by something like `PointRangeQuery` as it doesn't iterate over the documents in `docId` order. Realized that we d

Re: [I] Add a timeout for forceMergeDeletes in IndexWriter [lucene]

2025-04-15 Thread via GitHub
vigyasharma commented on issue #14431: URL: https://github.com/apache/lucene/issues/14431#issuecomment-2807330038 For some Amazon Product Search context, we do a searcher switch-over to the newly built index once it is declared healthy and ready to use. The idea here is to first build the i

Re: [PR] A specialized Trie for Block Tree Index [lucene]

2025-04-15 Thread via GitHub
msokolov commented on PR #14333: URL: https://github.com/apache/lucene/pull/14333#issuecomment-2807271469 I saw a message raising concern about some OOM test failures possibly related to this? Am I confused? Is that a potential problem? -- This is an automated message from the Apache Git

Re: [PR] [10x] Move some DocValuesConsumer merge logic to helper methods. [lucene]

2025-04-15 Thread via GitHub
martijnvg merged PR #14500: URL: https://github.com/apache/lucene/pull/14500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

[PR] [10x] Move some DocValuesConsumer merge logic to helper methods. [lucene]

2025-04-15 Thread via GitHub
martijnvg opened a new pull request, #14500: URL: https://github.com/apache/lucene/pull/14500 Backporting #14459 to `branch_10x` branch. Move code that creates merged doc value instances and ordinal map to protected helper methods. This will allow custom DocValuesConsumer implementat

Re: [PR] Move some DocValuesConsumer merge logic to helper methods. [lucene]

2025-04-15 Thread via GitHub
martijnvg merged PR #14459: URL: https://github.com/apache/lucene/pull/14459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [PR] Move some DocValuesConsumer merge logic to helper methods. [lucene]

2025-04-15 Thread via GitHub
martijnvg commented on PR #14459: URL: https://github.com/apache/lucene/pull/14459#issuecomment-2807092322 Thanks for the reviews @dnhatn and @stefanvodita. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Add a Faiss codec for KNN searches [lucene]

2025-04-15 Thread via GitHub
mikemccand commented on PR #14178: URL: https://github.com/apache/lucene/pull/14178#issuecomment-2801937523 This conda prereq is "just" to get a snapshot (tip of feature branch) build of FAISS, right? I.e. once the next [feature release of FAISS is out (1.11.0?)](https://github.com/f

Re: [I] Dump hprof on OOM from tests [lucene]

2025-04-15 Thread via GitHub
uschindler commented on issue #14481: URL: https://github.com/apache/lucene/issues/14481#issuecomment-2802496845 I don't exactly remeber why we instructed jenkins to copy over all the hprof files to a separate directory. I think it was because the Ant build cleaned up the stuff to early whe

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

2025-04-15 Thread via GitHub
thecoop commented on PR #14482: URL: https://github.com/apache/lucene/pull/14482#issuecomment-2805013373 To stop this PR getting too big, I suggest merging this here (which doesn't change any existing behaviour), and work on updating uses of IOContext to use hints rather than ReadAdvice in

Re: [I] update PRs for java dependencies [lucene]

2025-04-15 Thread via GitHub
rmuir commented on issue #14490: URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804025900 Thanks for hacking at this one, I appreciate it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] better pin github actions versions [lucene]

2025-04-15 Thread via GitHub
rmuir closed issue #14491: better pin github actions versions URL: https://github.com/apache/lucene/issues/14491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] TestFloatVectorSimilarityQuery.testTimeout fails intermittently [lucene]

2025-04-15 Thread via GitHub
dweiss commented on issue #14480: URL: https://github.com/apache/lucene/issues/14480#issuecomment-2802449583 Repro, just fyi: ``` ./gradlew test --tests TestFloatVectorSimilarityQuery.testTimeout -Dtests.seed=9843678908EBB30D -Dtests.multiplier=3 -Dtests.locale=ru -Dtests.timezone=Ame

[PR] Move version catalog and enable dependabot scanning of gradle dependencies [lucene]

2025-04-15 Thread via GitHub
dweiss opened a new pull request, #14495: URL: https://github.com/apache/lucene/pull/14495 #14490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: i

Re: [I] update PRs for java dependencies [lucene]

2025-04-15 Thread via GitHub
rmuir commented on issue #14490: URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804159900 I see your point: I see it from your fork at the expected place that requires no special permissions: https://github.com/dweiss/lucene/network/dependencies?q=ecosystem%3AMaven

Re: [I] TestIndexWriterMergePolicy opens too many file handles at night [lucene]

2025-04-15 Thread via GitHub
rmuir commented on issue #14483: URL: https://github.com/apache/lucene/issues/14483#issuecomment-2803756019 Goes without saying that I can change it to ByteBuffersDirectory, but it seems to get slow under pressure, I'm not comfortable with that as a file-handle reducer. It may just instead

Re: [PR] Fix RegExp.toString generating invalid RE for CHAR and CHAR_RANGE [lucene]

2025-04-15 Thread via GitHub
rmuir commented on PR #14493: URL: https://github.com/apache/lucene/pull/14493#issuecomment-2804210293 > What would be the right way to get the original input string then, please? Or do you just declare that `RegExp` does not support that? > It doesn't have a method to support thi

Re: [PR] ci: pin github actions versions in use [lucene]

2025-04-15 Thread via GitHub
rmuir merged PR #14492: URL: https://github.com/apache/lucene/pull/14492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

Re: [PR] ci: pin github actions versions in use [lucene]

2025-04-15 Thread via GitHub
rmuir commented on PR #14492: URL: https://github.com/apache/lucene/pull/14492#issuecomment-2803999569 @dweiss I do like the renovatebot for that use-case, it runs stateless e.g. as a `docker run`. It works great for managing front-end dependencies and runs the real `npm` (for better or wor

Re: [PR] test: AwaitFix TestIndexWriterMergePolicy.stressUpdateSameDocumentWithMergeOnX [lucene]

2025-04-15 Thread via GitHub
rmuir merged PR #14489: URL: https://github.com/apache/lucene/pull/14489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

[I] Dynamic threshold for DocIdSetBuilder [lucene]

2025-04-15 Thread via GitHub
jainankitk opened a new issue, #14485: URL: https://github.com/apache/lucene/issues/14485 ### Description Currently, we are using `maxDoc >>> 7` as the default threshold before upgrading to BitSet. I am wondering if there is more optimal way of determining the right threshold.

Re: [PR] Add a Faiss codec for KNN searches [lucene]

2025-04-15 Thread via GitHub
msokolov commented on PR #14178: URL: https://github.com/apache/lucene/pull/14178#issuecomment-2801592335 I did download miniconda, but I have to say its license terms are not very appealing. For example: ``` 2.1 Organizational Use. Your registration, download, use, installation,

Re: [I] Dump hprof on OOM from tests [lucene]

2025-04-15 Thread via GitHub
dweiss closed issue #14481: Dump hprof on OOM from tests URL: https://github.com/apache/lucene/issues/14481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] A specialized Trie for Block Tree Index [lucene]

2025-04-15 Thread via GitHub
mikemccand commented on PR #14333: URL: https://github.com/apache/lucene/pull/14333#issuecomment-2806504615 > Nightly confirmed the speedup. That's ~1.2 M primary key lookups per second, yay! PK lookups are used all the time, not just the "key/value store" use case... e.g. upda

Re: [I] Support modifying segmentInfos.counter in IndexWriter [lucene]

2025-04-15 Thread via GitHub
vigyasharma closed issue #14362: Support modifying segmentInfos.counter in IndexWriter URL: https://github.com/apache/lucene/issues/14362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] A specialized Trie for Block Tree Index [lucene]

2025-04-15 Thread via GitHub
gf2121 commented on PR #14333: URL: https://github.com/apache/lucene/pull/14333#issuecomment-2805221641 Nightly confirmed the speedup. https://benchmarks.mikemccandless.com/2025.04.14.18.05.20.html https://benchmarks.mikemccandless.com/PKLookup.html Annotation PR: https://git

Re: [PR] ci: bump actions/stale from 5 to 9 [lucene]

2025-04-15 Thread via GitHub
dependabot[bot] closed pull request #14466: ci: bump actions/stale from 5 to 9 URL: https://github.com/apache/lucene/pull/14466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] ci: bump actions/stale from 5.2.0 to 9.1.0 [lucene]

2025-04-15 Thread via GitHub
dependabot[bot] opened a new pull request, #14498: URL: https://github.com/apache/lucene/pull/14498 Bumps [actions/stale](https://github.com/actions/stale) from 5.2.0 to 9.1.0. Release notes Sourced from https://github.com/actions/stale/releases";>actions/stale's releases. v

[PR] deps(java): bump flexmark from 0.61.24 to 0.64.8 [lucene]

2025-04-15 Thread via GitHub
dependabot[bot] opened a new pull request, #14499: URL: https://github.com/apache/lucene/pull/14499 Bumps `flexmark` from 0.61.24 to 0.64.8. Updates `com.vladsch.flexmark:flexmark` from 0.61.24 to 0.64.8 Commits See full diff in https://github.com/vsch/flexmark-java/commits";

Re: [PR] ci: bump actions/stale from 5 to 9 [lucene]

2025-04-15 Thread via GitHub
dependabot[bot] commented on PR #14466: URL: https://github.com/apache/lucene/pull/14466#issuecomment-2804946688 Superseded by #14498. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] update PRs for java dependencies [lucene]

2025-04-15 Thread via GitHub
dweiss commented on issue #14490: URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804947353 I've merged this on main. Let's see what happens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Move version catalog and enable dependabot scanning of gradle dependencies [lucene]

2025-04-15 Thread via GitHub
dweiss merged PR #14495: URL: https://github.com/apache/lucene/pull/14495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Add support for determining off-heap memory requirements for KnnVectorsReader [lucene]

2025-04-15 Thread via GitHub
ChrisHegarty merged PR #14426: URL: https://github.com/apache/lucene/pull/14426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [I] update PRs for java dependencies [lucene]

2025-04-15 Thread via GitHub
dweiss commented on issue #14490: URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804005231 Let me take a look on my fork. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Add support for determining off-heap memory requirements for KnnVectorsReader [lucene]

2025-04-15 Thread via GitHub
navneet1v commented on PR #14426: URL: https://github.com/apache/lucene/pull/14426#issuecomment-2804604505 > > @ChrisHegarty this PR provides the info on how much off heap space is needed but this doesn't provide info on how much is loaded into memory correct? and do we have any plans to ex

Re: [PR] Add support for determining off-heap memory requirements for KnnVectorsReader [lucene]

2025-04-15 Thread via GitHub
ChrisHegarty commented on code in PR #14426: URL: https://github.com/apache/lucene/pull/14426#discussion_r2043960727 ## lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsReader.java: ## @@ -130,4 +134,48 @@ public KnnVectorsReader getMergeInstance() { * The default imp

Re: [PR] ci: bump actions/stale from 5 to 9 [lucene]

2025-04-15 Thread via GitHub
rmuir commented on PR #14466: URL: https://github.com/apache/lucene/pull/14466#issuecomment-2804109445 at least we got the PR we were looking for (unrelated to the magnitude of changes). -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [10.x] Add support for determining off-heap memory requirements for KnnVectorsReader [lucene]

2025-04-15 Thread via GitHub
ChrisHegarty merged PR #14497: URL: https://github.com/apache/lucene/pull/14497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

[PR] [10.x] Add support for determining off-heap memory requirements for KnnVectorsReader [lucene]

2025-04-15 Thread via GitHub
ChrisHegarty opened a new pull request, #14497: URL: https://github.com/apache/lucene/pull/14497 Backport of: * #14426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

2025-04-15 Thread via GitHub
ChrisHegarty commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2044187179 ## lucene/core/src/test/org/apache/lucene/store/TestDirectory.java: ## @@ -126,4 +126,27 @@ public void testListAll() throws Throwable { assertTrue(files.con

Re: [I] [Bug] Stored fields force merge regression between Lucene 9.12 and Lucene 10.0 [lucene]

2025-04-15 Thread via GitHub
mgodwan commented on issue #14463: URL: https://github.com/apache/lucene/issues/14463#issuecomment-2804548615 Thanks @bharath-techie for the dive deep and root causing this. @uschindler Thoughts on this if it is ok to proceed with updating readadvice for merges? -- This is an autom

Re: [I] Backport Bot [lucene]

2025-04-15 Thread via GitHub
mikemccand commented on issue #14496: URL: https://github.com/apache/lucene/issues/14496#issuecomment-2804427926 Very cool! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Dump hprof on OOM from tests [lucene]

2025-04-15 Thread via GitHub
dweiss commented on issue #14481: URL: https://github.com/apache/lucene/issues/14481#issuecomment-2802438002 They are written to the current working dir of the test task's jvm. So, for each project, this would be ```build/tmp/tests-cwd/*.hprof```. Won't jenkins copy over those artifacts so

Re: [PR] Move some DocValuesConsumer merge logic to helper methods. [lucene]

2025-04-15 Thread via GitHub
stefanvodita commented on PR #14459: URL: https://github.com/apache/lucene/pull/14459#issuecomment-2804349293 Thanks for the explanation! The new revision looks good as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Add support for determining off-heap memory requirements for KnnVectorsReader [lucene]

2025-04-15 Thread via GitHub
ChrisHegarty commented on PR #14426: URL: https://github.com/apache/lucene/pull/14426#issuecomment-2804247850 > @ChrisHegarty this PR provides the info on how much off heap space is needed but this doesn't provide info on how much is loaded into memory correct? and do we have any plans to e

[I] Backport Bot [lucene]

2025-04-15 Thread via GitHub
rmuir opened a new issue, #14496: URL: https://github.com/apache/lucene/issues/14496 ### Description Lucene issues stable releases via backporting. But the backporting is a manual `git cherry-pick` of the committer: maybe they run all tests, maybe some, maybe not. It wo

Re: [PR] Move version catalog and enable dependabot scanning of gradle dependencies [lucene]

2025-04-15 Thread via GitHub
rmuir commented on code in PR #14495: URL: https://github.com/apache/lucene/pull/14495#discussion_r2043945611 ## .github/dependabot.yml: ## @@ -20,3 +20,13 @@ updates: prefix: build(deps) labels: - dependencies + + - package-ecosystem: gradle +directory:

Re: [I] update PRs for java dependencies [lucene]

2025-04-15 Thread via GitHub
rmuir commented on issue #14490: URL: https://github.com/apache/lucene/issues/14490#issuecomment-2803979497 @dweiss mainly I am curious if we can see the new dependencies under https://github.com/apache/lucene/network/dependencies I don't know how to test this (i think it only evals d

Re: [I] update PRs for java dependencies [lucene]

2025-04-15 Thread via GitHub
dweiss commented on issue #14490: URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804189280 This is I think the least invasive change: https://github.com/apache/lucene/pull/14495 -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [I] update PRs for java dependencies [lucene]

2025-04-15 Thread via GitHub
dweiss commented on issue #14490: URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804184837 > I dont know what this "Github Dependency Graph Gradle Plugin" is doing at all I think it's computing a dependency graph inside gradle, then submitting it to github via their

Re: [PR] Fix RegExp.toString generating invalid RE for CHAR and CHAR_RANGE [lucene]

2025-04-15 Thread via GitHub
Tasssadar commented on PR #14493: URL: https://github.com/apache/lucene/pull/14493#issuecomment-2804173363 > Separately: the output of .toString() is just that, for humans, and not guaranteed to be reparsable. I can practically guarantee it is a bad idea to do this. What would be the

Re: [I] update PRs for java dependencies [lucene]

2025-04-15 Thread via GitHub
dweiss commented on issue #14490: URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804108791 Ok, so I think that: - adding gradle dependencies requires moving the catalog, it's a simple change and is fine, - we get update PRs for free then - adding dependency graph r

Re: [PR] ci: pin github actions versions in use [lucene]

2025-04-15 Thread via GitHub
rmuir commented on PR #14492: URL: https://github.com/apache/lucene/pull/14492#issuecomment-2804090222 I'll check the outstanding dependabot PR's response for this one, worst-case we can revert it, if something goes wrong. -- This is an automated message from the Apache Git Service. To re

Re: [I] update PRs for java dependencies [lucene]

2025-04-15 Thread via GitHub
dweiss commented on issue #14490: URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804115889 Here is why I think adding dependency graph will require some filtering - these reports very likely originate from gradle plugins somewhere. It's hard to even track them down: ht

Re: [PR] Move some DocValuesConsumer merge logic to helper methods. [lucene]

2025-04-15 Thread via GitHub
martijnvg commented on PR #14459: URL: https://github.com/apache/lucene/pull/14459#issuecomment-2804123675 Thanks for taking a look @stefanvodita! I've added the CHANGES entry. > Curious if you can share more about what you're trying to achieve! We have [a specialized doc values

Re: [I] update PRs for java dependencies [lucene]

2025-04-15 Thread via GitHub
rmuir commented on issue #14490: URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804123037 > Here is why I think adding dependency graph will require some filtering - these reports very likely originate from gradle plugins somewhere. It's hard to even track them down: >

Re: [I] update PRs for java dependencies [lucene]

2025-04-15 Thread via GitHub
rmuir commented on issue #14490: URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804120377 Is the catalog treated separately than the ordinary java library deps (e.g. commons-whatever)? Ideally we bring all the deps into automation, but for this issue I figured the java lib

Re: [I] better pin github actions versions [lucene]

2025-04-15 Thread via GitHub
rmuir closed issue #14491: better pin github actions versions URL: https://github.com/apache/lucene/issues/14491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] update PRs for java dependencies [lucene]

2025-04-15 Thread via GitHub
dweiss commented on issue #14490: URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804061293 I don't think the dependency graph supports gradle out of the box - https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/depe

Re: [PR] Fix RegExp.toString generating invalid RE for CHAR and CHAR_RANGE [lucene]

2025-04-15 Thread via GitHub
rmuir commented on PR #14493: URL: https://github.com/apache/lucene/pull/14493#issuecomment-2804077216 I like the change. We can get fancy and extend it in the future, but the `toString()` today does not do its one job, the output is not readable. This fixes it to be more practical and not

Re: [I] update PRs for java dependencies [lucene]

2025-04-15 Thread via GitHub
dweiss commented on issue #14490: URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804071176 The documentation for dependency submission action is here: https://github.com/gradle/actions/blob/main/docs/dependency-submission.md it is verbose. I'm not sure we need to u

Re: [I] update PRs for java dependencies [lucene]

2025-04-15 Thread via GitHub
dweiss commented on issue #14490: URL: https://github.com/apache/lucene/issues/14490#issuecomment-2804036034 Can't see the dependencies in gradle ecosystem here, perhaps yet: https://github.com/dweiss/lucene/network/dependencies but something did run: https://github.com/dweiss/lucen