vigyasharma commented on PR #14443:
URL: https://github.com/apache/lucene/pull/14443#issuecomment-2798439844
Another scenario where adaptive refresh might be useful is with heterogenous
search fleets. Searchers with less memory would benefit from stepping through
smaller commit deltas, whil
vsop-479 commented on code in PR #13923:
URL: https://github.com/apache/lucene/pull/13923#discussion_r2040500344
##
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##
@@ -819,17 +819,11 @@ private void freezeTail(int prefixLenPlus1) throws
IOException {
github-actions[bot] commented on PR #14356:
URL: https://github.com/apache/lucene/pull/14356#issuecomment-2798252344
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
msokolov commented on issue #14455:
URL: https://github.com/apache/lucene/issues/14455#issuecomment-2798234028
We tie-break on docid so that the sort order is well-defined and stable
w.r.t. multiple executions of the same query. Maybe there is some other reason
like making index-time sorti
msokolov commented on PR #14443:
URL: https://github.com/apache/lucene/pull/14443#issuecomment-2798221555
> Sorry I'm still a bit confused: how is this approach better than just
committing more frequently, replicating commits as soon as they are created,
and refreshing searchers as soon as
HoustonPutman commented on issue #14455:
URL: https://github.com/apache/lucene/issues/14455#issuecomment-2798145654
I just realized that the first part of the method resorts on docId to start.
So we would need to sort the original-order `hits` from the
`firstPassTopDocs` passed to the
HoustonPutman commented on issue #14455:
URL: https://github.com/apache/lucene/issues/14455#issuecomment-2798129113
Can two different docs have the same id? I don't think so. Then your example
is functionally the same as it is now.
In my mind, it would be:
```java
Comparator
jpountz commented on PR #14475:
URL: https://github.com/apache/lucene/pull/14475#issuecomment-2797989784
Indeed `advanceExact` is ofter used from within collectors. It proved often
faster than calling `advance` and checking if it returns the target doc ID.
I agree that it is not great
vibrantvarun commented on issue #14455:
URL: https://github.com/apache/lucene/issues/14455#issuecomment-2797975149
Maybe something like this
```
private static final Comparator SORTING_TIE_BREAKER = (o1, o2) -> {
int scoreComparison = Double.compare(o1.score, o2.score);
rmuir commented on PR #14476:
URL: https://github.com/apache/lucene/pull/14476#issuecomment-2797897063
Thank you @jainankitk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rmuir merged PR #14476:
URL: https://github.com/apache/lucene/pull/14476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
HoustonPutman commented on issue #14455:
URL: https://github.com/apache/lucene/issues/14455#issuecomment-2797855886
The sort criteria can include the score. And in this case, we are talking
about re-scoring. So consider the original sort is `score, price asc`, then we
use the QueryRescorer.
rmuir commented on code in PR #14433:
URL: https://github.com/apache/lucene/pull/14433#discussion_r2040160001
##
lucene/core/src/java/org/apache/lucene/search/similarities/Similarity.java:
##
@@ -161,6 +162,17 @@ public long computeNorm(FieldInvertState state) {
return Smal
vibrantvarun commented on code in PR #14395:
URL: https://github.com/apache/lucene/pull/14395#discussion_r2040138727
##
lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java:
##
@@ -59,6 +59,13 @@ private abstract class TopFieldLeafCollector implements
LeafCollec
vibrantvarun commented on PR #14395:
URL: https://github.com/apache/lucene/pull/14395#issuecomment-2797801131
Overall code looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
vibrantvarun commented on issue #14455:
URL: https://github.com/apache/lucene/issues/14455#issuecomment-2797782367
@HoustonPutman When the user has provided a sort criteria then why would the
score be calculated at the first place. My understanding is query X says give
me results from the s
jainankitk commented on code in PR #13923:
URL: https://github.com/apache/lucene/pull/13923#discussion_r2039940112
##
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##
@@ -819,17 +819,11 @@ private void freezeTail(int prefixLenPlus1) throws
IOException {
jainankitk commented on code in PR #13923:
URL: https://github.com/apache/lucene/pull/13923#discussion_r2039939835
##
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##
@@ -819,17 +819,11 @@ private void freezeTail(int prefixLenPlus1) throws
IOException {
jainankitk commented on code in PR #14476:
URL: https://github.com/apache/lucene/pull/14476#discussion_r2039927980
##
lucene/core/src/java/org/apache/lucene/geo/ComponentTree.java:
##
@@ -48,23 +50,18 @@ final class ComponentTree implements Component2D {
// child components,
jainankitk opened a new pull request, #14476:
URL: https://github.com/apache/lucene/pull/14476
### Description
IMO, storing splitX for every `TreeNode` makes sense, only if we are
exposing API to partially search `ComponentTree` from arbitrary `TreeNode`
which is not allowed today. Hence
vsop-479 commented on code in PR #13923:
URL: https://github.com/apache/lucene/pull/13923#discussion_r2039417117
##
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##
@@ -819,17 +819,11 @@ private void freezeTail(int prefixLenPlus1) throws
IOException {
gf2121 commented on PR #14475:
URL: https://github.com/apache/lucene/pull/14475#issuecomment-2796358462
I like the idea!
Think out loud: `advanceExact` is a rather frequently used method in past
experience of using docvalues. I wonder if we can make it also included in the
iterator b
stefanvodita merged PR #14474:
URL: https://github.com/apache/lucene/pull/14474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
vsop-479 commented on code in PR #13923:
URL: https://github.com/apache/lucene/pull/13923#discussion_r2038934742
##
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##
@@ -819,17 +819,11 @@ private void freezeTail(int prefixLenPlus1) throws
IOException {
24 matches
Mail list logo
