Re: [PR] Fix TestIndexWriter.testDeleteUnusedFiles' failure on Windows 11 [lucene]

2025-04-09 Thread via GitHub
vsop-479 closed pull request #13183: Fix TestIndexWriter.testDeleteUnusedFiles' failure on Windows 11 URL: https://github.com/apache/lucene/pull/13183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Add an IndexDeletion policy that retains the last N commits [lucene]

2025-04-09 Thread via GitHub
owaiskazi19 opened a new pull request, #14458: URL: https://github.com/apache/lucene/pull/14458 ### Description This change introduces a new IndexDeletion policy called as `KeepLastNCommitsDeletionPolicy` that retains the last N commits and removes all prior commits after a new commit is

Re: [I] Add an IndexDeletion policy that retains the last N commits [lucene]

2025-04-09 Thread via GitHub
owaiskazi19 commented on issue #1: URL: https://github.com/apache/lucene/issues/1#issuecomment-2791533738 @vigyasharma opened https://github.com/apache/lucene/pull/14458 for the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Logic for collecting Histogram efficiently using Point Trees [lucene]

2025-04-09 Thread via GitHub
jainankitk commented on PR #14439: URL: https://github.com/apache/lucene/pull/14439#issuecomment-2791267186 > Sorry, I only had a quick look. Is the opimisation here analogous to the one `HistogramLeafCollector` does with the skipper? No, this approach is different from the skipper as

Re: [PR] Adding TestSpanWithinQuery with basic test cases for SpanWithinQuery [lucene]

2025-04-09 Thread via GitHub
github-actions[bot] commented on PR #14405: URL: https://github.com/apache/lucene/pull/14405#issuecomment-2791251513 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

[PR] tests: set a socket timeout on replicator tests [lucene]

2025-04-09 Thread via GitHub
rmuir opened a new pull request, #14457: URL: https://github.com/apache/lucene/pull/14457 These nightly tests sometimes hang and are killed by timeout, instead of passing or failing. Upon inspection of one of the failures, the hung thread is stuck in `SocketDispatcher.read0()` native code,

Re: [I] replicator/ tests sometimes hang with Nightly [lucene]

2025-04-09 Thread via GitHub
rmuir commented on issue #14454: URL: https://github.com/apache/lucene/issues/14454#issuecomment-2791055271 the test framework had clearly pointed directly at the suspect all along. here is is: ``` 2> Apr 08, 2025 9:14:26 AM com.carrotsearch.randomizedtesting.ThreadLeakControl tryTo

Re: [I] TestInt7HnswBackwardsCompatibility fails when new codec introduced [lucene]

2025-04-09 Thread via GitHub
jpountz commented on issue #14456: URL: https://github.com/apache/lucene/issues/14456#issuecomment-2790967690 Oh it looks like this is my bad, because of #13970. I had not paid attention to the fact that this test was used to create bwc indexes. So we need to revert changes on this test and

Re: [I] replicator/ tests sometimes hang with Nightly [lucene]

2025-04-09 Thread via GitHub
rmuir commented on issue #14454: URL: https://github.com/apache/lucene/issues/14454#issuecomment-2790990751 I found suspicious stuff :) Now i just have to review more stacktraces. I'm attaching the jenkins console output to the issue so it doesn't get lost (i dont know policeman retention p

Re: [PR] Clean up how the test framework creates asserting scorables. [lucene]

2025-04-09 Thread via GitHub
jpountz commented on code in PR #14452: URL: https://github.com/apache/lucene/pull/14452#discussion_r2036125856 ## lucene/test-framework/src/java/org/apache/lucene/tests/search/AssertingScorer.java: ## @@ -80,8 +74,8 @@ boolean iterating() { @Override public void setMinC

Re: [I] replicator/ tests sometimes hang with Nightly [lucene]

2025-04-09 Thread via GitHub
rmuir commented on issue #14454: URL: https://github.com/apache/lucene/issues/14454#issuecomment-2790957026 I dug into it a bit more, here is where it hangs. The test thinks it is done after 200s, but then hangs until the timeout in this loop, trying to cleanup: ```java message("TE

Re: [PR] Migrate away from per-segment-per-threadlocals on SegmentReader [lucene]

2025-04-09 Thread via GitHub
rmuir commented on PR #11998: URL: https://github.com/apache/lucene/pull/11998#issuecomment-2790896753 @0ctopus13prime see recent dev list thread on this very subject: https://lists.apache.org/thread/d14b5bftl50dmycq08kq76jwb1kk4wts I think @uschindler summarizes it well in his last r

Re: [PR] A specialized Trie for Block Tree Index [lucene]

2025-04-09 Thread via GitHub
jpountz commented on code in PR #14333: URL: https://github.com/apache/lucene/pull/14333#discussion_r2035921332 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene101/PostingDecodingUtil.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Fo

[I] TestInt7HnswBackwardsCompatibility fails when new codec introduced [lucene]

2025-04-09 Thread via GitHub
gf2121 opened a new issue, #14456: URL: https://github.com/apache/lucene/issues/14456 ### Description Context: https://github.com/apache/lucene/pull/14333#issuecomment-2790381195. We were using the`AssertingCodec` to create bwc indices so tests get failed when we update `Assert

Re: [PR] Reduce the number of comparisons when lowerPoint is equal to upperPoint [lucene]

2025-04-09 Thread via GitHub
jainankitk commented on PR #14267: URL: https://github.com/apache/lucene/pull/14267#issuecomment-2790508595 > @gsmiller @jainankitk I haven't carefully studied the implementation of benchmark sin Lucene too, which may take sometime. @hanbj - Please take your time. You can follow the i

Re: [PR] A specialized Trie for Block Tree Index [lucene]

2025-04-09 Thread via GitHub
gf2121 commented on code in PR #14333: URL: https://github.com/apache/lucene/pull/14333#discussion_r2035753834 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene101/PostingDecodingUtil.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] A specialized Trie for Block Tree Index [lucene]

2025-04-09 Thread via GitHub
gf2121 commented on code in PR #14333: URL: https://github.com/apache/lucene/pull/14333#discussion_r2035743271 ## lucene/core/src/java/org/apache/lucene/codecs/lucene103/blocktree/TrieBuilder.java: ## @@ -0,0 +1,640 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] A specialized Trie for Block Tree Index [lucene]

2025-04-09 Thread via GitHub
gf2121 commented on PR #14333: URL: https://github.com/apache/lucene/pull/14333#issuecomment-2790381195 I am seeing all tests in `TestInt7HnswBackwardsCompatibility` get failed: ``` org.apache.lucene.index.CorruptIndexException: codec mismatch: actual codec=Lucene101PostingsWriterM

Re: [PR] Fix TestIndexWriterWithThreads#testIOExceptionDuringAbortWithThreadsOnlyOnce [lucene]

2025-04-09 Thread via GitHub
aoli-al commented on PR #14424: URL: https://github.com/apache/lucene/pull/14424#issuecomment-2790341462 Nice! I tested the patch using [Fray](https://github.com/cmu-pasta/fray) and confirmed that there is no longer a RuntimeException. You can check how I use Fray to run the test her

Re: [I] Add more information to IOContext [lucene]

2025-04-09 Thread via GitHub
thecoop commented on issue #14422: URL: https://github.com/apache/lucene/issues/14422#issuecomment-2789635909 That's a good idea - we can separate it out by type, allowing for more granular specifications, whilst keeping it flexible. How about - we could use the same pattern as Java I

Re: [PR] A specialized Trie for Block Tree Index [lucene]

2025-04-09 Thread via GitHub
mikemccand commented on code in PR #14333: URL: https://github.com/apache/lucene/pull/14333#discussion_r2035324851 ## lucene/core/src/java/org/apache/lucene/codecs/lucene103/ForDeltaUtil.java: ## @@ -0,0 +1,471 @@ +// This file has been automatically generated, DO NOT EDIT + +/*

Re: [PR] A specialized Trie for Block Tree Index [lucene]

2025-04-09 Thread via GitHub
mikemccand commented on PR #14333: URL: https://github.com/apache/lucene/pull/14333#issuecomment-2789601238 > > f we stick not to make it default, maybe this codec should be moved into test / sandbox / codec module? > > I don't have a strong opinion about making it the default right n