jpountz commented on code in PR #14452: URL: https://github.com/apache/lucene/pull/14452#discussion_r2036125856
########## lucene/test-framework/src/java/org/apache/lucene/tests/search/AssertingScorer.java: ########## @@ -80,8 +74,8 @@ boolean iterating() { @Override public void setMinCompetitiveScore(float score) throws IOException { - assert scoreMode == ScoreMode.TOP_SCORES; - assert canCallMinCompetitiveScore; + assert canScore; + assert canSetMinCompetitiveScore; Review Comment: This is a good point, I pushed a commit that makes sure setMinCompetitiveScore may only be called with TOP_SCORES. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org