Re: [PR] Not maintain docBufferUpTo when only docs needed [lucene]

2025-01-24 Thread via GitHub
gf2121 merged PR #14164: URL: https://github.com/apache/lucene/pull/14164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[PR] Rename`mergeThreadCount` in ConcurrentMergeScheduler to avoid clashing with method of the same name [lucene]

2025-01-24 Thread via GitHub
cwperks opened a new pull request, #14171: URL: https://github.com/apache/lucene/pull/14171 ### Description Opening up this small PR to rename `mergeThreadCount` (the field) to `mergeThreadCounter` to avoid clashing with a method in the same class also named `mergeThreadCount`

Re: [PR] SortedSet DV Multi Range query [lucene]

2025-01-24 Thread via GitHub
gsmiller commented on code in PR #13974: URL: https://github.com/apache/lucene/pull/13974#discussion_r1929422639 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/SortedSetMultiRangeQuery.java: ## @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Upgrade commons-codec from 1.13.0 to 1.17.2 [lucene]

2025-01-24 Thread via GitHub
github-actions[bot] commented on PR #14129: URL: https://github.com/apache/lucene/pull/14129#issuecomment-2613644597 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Add nullability annotations to IndexSearcher APIs [lucene]

2025-01-24 Thread via GitHub
github-actions[bot] commented on PR #14132: URL: https://github.com/apache/lucene/pull/14132#issuecomment-2613644568 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Add new Acorn-esque filtered HNSW search heuristic [lucene]

2025-01-24 Thread via GitHub
benchaplin commented on code in PR #14160: URL: https://github.com/apache/lucene/pull/14160#discussion_r1929362321 ## lucene/core/src/java/org/apache/lucene/util/hnsw/FilteredHnswGraphSearcher.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Add new Acorn-esque filtered HNSW search heuristic [lucene]

2025-01-24 Thread via GitHub
benwtrent commented on code in PR #14160: URL: https://github.com/apache/lucene/pull/14160#discussion_r1929278355 ## lucene/core/src/java/org/apache/lucene/util/hnsw/FilteredHnswGraphSearcher.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Add new Acorn-esque filtered HNSW search heuristic [lucene]

2025-01-24 Thread via GitHub
benwtrent commented on code in PR #14160: URL: https://github.com/apache/lucene/pull/14160#discussion_r1929275595 ## lucene/core/src/java/org/apache/lucene/util/hnsw/FilteredHnswGraphSearcher.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Add new Acorn-esque filtered HNSW search heuristic [lucene]

2025-01-24 Thread via GitHub
benchaplin commented on code in PR #14160: URL: https://github.com/apache/lucene/pull/14160#discussion_r1929224104 ## lucene/core/src/java/org/apache/lucene/util/hnsw/FilteredHnswGraphSearcher.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Add new Acorn-esque filtered HNSW search heuristic [lucene]

2025-01-24 Thread via GitHub
benchaplin commented on code in PR #14160: URL: https://github.com/apache/lucene/pull/14160#discussion_r1929218346 ## lucene/core/src/java/org/apache/lucene/util/hnsw/FilteredHnswGraphSearcher.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[PR] Optimize ContextQuery with big number of contexts [lucene]

2025-01-24 Thread via GitHub
mayya-sharipova opened a new pull request, #14169: URL: https://github.com/apache/lucene/pull/14169 When there are big number of contexts, ContextQuery may take a lot of time because of how context automata are constructed. Instead of the current approach of repeatedly concatenating a

Re: [PR] Add UnwrappingReuseStrategy for AnalyzerWrapper [lucene]

2025-01-24 Thread via GitHub
benwtrent commented on code in PR #14154: URL: https://github.com/apache/lucene/pull/14154#discussion_r1929163572 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/query/QueryAutoStopWordAnalyzer.java: ## @@ -126,7 +126,7 @@ public QueryAutoStopWordAnalyzer( publi

Re: [PR] Add small bias towards bit set encoding. [lucene]

2025-01-24 Thread via GitHub
rmuir commented on PR #14155: URL: https://github.com/apache/lucene/pull/14155#issuecomment-2613009514 You need a telescope to see the difference -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] UnsupportedOperationException instead of IllegalArgumentException from PointInSetQuery when values are out of order [lucene]

2025-01-24 Thread via GitHub
gsmiller commented on issue #14161: URL: https://github.com/apache/lucene/issues/14161#issuecomment-2612934639 @jhinch-at-atlassian-com agreed. I might lean towards implementing a `BytesRefBuilder#toString` method since it could potentially help in other places where this trappy behavior mi

Re: [I] Remove the @Deprecated methods from TopScoreDocCollector and TopFieldCollector [lucene]

2025-01-24 Thread via GitHub
parastooGit commented on issue #13499: URL: https://github.com/apache/lucene/issues/13499#issuecomment-2612740260 Hello, Thank you for response, I have some code that are not mine but deprected: var collector = TopScoreDocCollector.create(1, Integer.MAX_VALUE); indexSearch

Re: [PR] Add new Acorn-esque filtered HNSW search heuristic [lucene]

2025-01-24 Thread via GitHub
benwtrent commented on PR #14160: URL: https://github.com/apache/lucene/pull/14160#issuecomment-2612693554 @msokolov I wonder your opinion here? Do you think the behavior change/result change is worth waiting for a major? I do think folks should be able to use this now, but be able t

Re: [I] Should we explore DiskANN for aKNN vector search? [lucene]

2025-01-24 Thread via GitHub
kaivalnp commented on issue #12615: URL: https://github.com/apache/lucene/issues/12615#issuecomment-2612374897 I'm also tinkering with a Faiss (https://github.com/facebookresearch/faiss) wrapper to perform KNN searches in Lucene (i.e. a standalone [`KnnVectorsFormat`](https://github.com/apa

Re: [PR] supports force merge based on specified segments. [lucene]

2025-01-24 Thread via GitHub
mikemccand commented on PR #14163: URL: https://github.com/apache/lucene/pull/14163#issuecomment-2612308360 If you are able to turn on `InfoStream` for the ES shard that won't merge segments with so many deletions, and post a chunk here, I can have a look and see if there are clues. -- T

Re: [PR] supports force merge based on specified segments. [lucene]

2025-01-24 Thread via GitHub
mikemccand commented on PR #14163: URL: https://github.com/apache/lucene/pull/14163#issuecomment-2612285079 It's terrible that `TieredMergePolicy` was not merging these segments, naturally or under `forceMerge` -- let's understand why it's failing to do so? It's like we need an `explain` A

Re: [PR] add RawTFSimilarity class [lucene]

2025-01-24 Thread via GitHub
cpoerschke commented on PR #13749: URL: https://github.com/apache/lucene/pull/13749#issuecomment-2612244980 https://issues.apache.org/jira/browse/SOLR-17626 and https://github.com/apache/solr/pull/2715 for Solr integration. -- This is an automated message from the Apache Git Service. To r