cwperks opened a new pull request, #14171: URL: https://github.com/apache/lucene/pull/14171
### Description Opening up this small PR to rename `mergeThreadCount` (the field) to `mergeThreadCounter` to avoid clashing with a method in the same class also named `mergeThreadCount` This variable is used to [assign merge thread numbers](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/index/ConcurrentMergeScheduler.java#L671-L678) by incrementing from 0 so I thought `mergeThreadCounter` may be a more appropriate name. Resolves: https://github.com/apache/lucene/issues/13114 Below is a snippet of the current state of the class where the field and method have the same name. ``` /** How many {@link MergeThread}s have kicked off (this is use to name them). */ protected int mergeThreadCount; /** * Returns the number of merge threads that are alive, ignoring the calling thread if it is a * merge thread. Note that this number is ≤ {@link #mergeThreads} size. * * @lucene.internal */ public synchronized int mergeThreadCount() { Thread currentThread = Thread.currentThread(); int count = 0; for (MergeThread mergeThread : mergeThreads) { if (currentThread != mergeThread && mergeThread.isAlive() && mergeThread.merge.isAborted() == false) { count++; } } return count; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
