Re: [I] TestBooleanRewrites.testRandom fails [lucene]

2024-11-29 Thread via GitHub
jpountz closed issue #14026: TestBooleanRewrites.testRandom fails URL: https://github.com/apache/lucene/issues/14026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [I] TestBooleanRewrites.testRandom fails [lucene]

2024-11-29 Thread via GitHub
jpountz commented on issue #14026: URL: https://github.com/apache/lucene/issues/14026#issuecomment-2507848755 I found the problem. When adding the new rewrite rule, I was assuming that we would have rewritten a query where the number of should clauses is less than `minimumShouldMatch` but w

[PR] Make SegmentInfos#readCommit(Directory, String, int) public [lucene]

2024-11-29 Thread via GitHub
javanna opened a new pull request, #14027: URL: https://github.com/apache/lucene/pull/14027 The corresponding readLatestCommit method is public and can be used to read segment infos from indices that are older than N - 1. The same should be possible for readCommit, but that requires the met

Re: [I] TestBooleanRewrites.testRandom fails [lucene]

2024-11-29 Thread via GitHub
ChrisHegarty commented on issue #14026: URL: https://github.com/apache/lucene/issues/14026#issuecomment-2507765415 Taking a sample query from a failing occurrence, this query seems to not rewrite correctly. ``` Query query = new BooleanQuery.Builder() .add(new BooleanQuery.B

Re: [I] TestBooleanRewrites.testRandom fails [lucene]

2024-11-29 Thread via GitHub
jpountz commented on issue #14026: URL: https://github.com/apache/lucene/issues/14026#issuecomment-2507723822 Woops, I'll look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Make inlining decisions a bit more predictable in our main queries. [lucene]

2024-11-29 Thread via GitHub
jpountz merged PR #14023: URL: https://github.com/apache/lucene/pull/14023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Make inlining decisions a bit more predictable in our main queries. [lucene]

2024-11-29 Thread via GitHub
jpountz commented on PR #14023: URL: https://github.com/apache/lucene/pull/14023#issuecomment-2507707084 Benchmarks results are still good: ``` TaskQPS baseline StdDevQPS my_modified_version StdDevPct diff p-value

Re: [PR] Make inlining decisions a bit more predictable in our main queries. [lucene]

2024-11-29 Thread via GitHub
jpountz commented on PR #14023: URL: https://github.com/apache/lucene/pull/14023#issuecomment-2507695294 Thanks @ChrisHegarty for looking, I was about to ping you. :) I reflected more on this change. The bits about specializing our bulk scorers that compute top-k hits by score with `I

Re: [I] TestBooleanRewrites.testRandom fails [lucene]

2024-11-29 Thread via GitHub
ChrisHegarty commented on issue #14026: URL: https://github.com/apache/lucene/issues/14026#issuecomment-2507561516 git bisect tells me that #14014 is where this failure first started occurring. -- This is an automated message from the Apache Git Service. To respond to the message, please

[I] TestBooleanRewrites.testRandom fails [lucene]

2024-11-29 Thread via GitHub
ChrisHegarty opened a new issue, #14026: URL: https://github.com/apache/lucene/issues/14026 ``` NOTE: reproduce with: gradlew test --tests TestBooleanRewrites.testRandom -Dtests.seed=40799F643C3392AF -Dtests.locale=fr-TN -Dtests.timezone=Europe/Simferopol -Dtests.asserts=true -Dtest

Re: [PR] Add IndexInput isLoaded [lucene]

2024-11-29 Thread via GitHub
ChrisHegarty merged PR #13998: URL: https://github.com/apache/lucene/pull/13998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen