Re: [I] KnnFloatVectorQuery#toString should show the filter [lucene]

2024-11-11 Thread via GitHub
viswanathk commented on issue #13983: URL: https://github.com/apache/lucene/issues/13983#issuecomment-2469602539 Seems like a good first issue - I can contribute this @jpountz. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] Pruning of estimating the point value count in BooleanScorerSupplier [lucene]

2024-11-11 Thread via GitHub
kkewwei opened a new pull request, #13988: URL: https://github.com/apache/lucene/pull/13988 ### Description The pr aims to speed up computing cost in `BooleanScorerSupplier` with the `leadCost`, just as #13199. Lucene benchmark: `python3 src/python/localrun.py wikimedium10m` Har

Re: [PR] Pruning of estimating the point value count in BooleanScorerSupplier [lucene]

2024-11-11 Thread via GitHub
kkewwei commented on PR #13988: URL: https://github.com/apache/lucene/pull/13988#issuecomment-2469378470 @jpountz please have a look when you are free. I will add additional tests if it makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[PR] Update lastDoc in ScoreCachingWrappingScorer [lucene]

2024-11-11 Thread via GitHub
msfroh opened a new pull request, #13987: URL: https://github.com/apache/lucene/pull/13987 ### Description I noticed that ScoreCachingWrappingScorer never updates lastDoc, so it's always -1. Technically, it's probably fine, since it still ends up returning the same score for multiple

Re: [PR] Allow easier verification of the Panama Vectorization provider with newer Java versions [lucene]

2024-11-11 Thread via GitHub
ChrisHegarty commented on code in PR #13986: URL: https://github.com/apache/lucene/pull/13986#discussion_r1836935485 ## gradle/testing/defaults-tests.gradle: ## @@ -128,7 +128,13 @@ allprojects { jvmArgs '--add-modules', 'jdk.management' // Enable the vector incu

Re: [PR] Introduces IndexInput#updateReadAdvice to change the readadvice while [lucene]

2024-11-11 Thread via GitHub
shatejas commented on code in PR #13985: URL: https://github.com/apache/lucene/pull/13985#discussion_r1836913408 ## lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java: ## @@ -113,6 +114,25 @@ public Lucene99HnswVectorsReader(SegmentReadState st

Re: [PR] Allow easier verification of the Panama Vectorization provider with newer Java versions [lucene]

2024-11-11 Thread via GitHub
dweiss commented on code in PR #13986: URL: https://github.com/apache/lucene/pull/13986#discussion_r1836911525 ## gradle/testing/defaults-tests.gradle: ## @@ -128,7 +128,13 @@ allprojects { jvmArgs '--add-modules', 'jdk.management' // Enable the vector incubator

[PR] Allow easier verification of the Panama Vectorization provider with newer Java versions [lucene]

2024-11-11 Thread via GitHub
ChrisHegarty opened a new pull request, #13986: URL: https://github.com/apache/lucene/pull/13986 This commit allows easier verification of the Panama Vectorization provider with newer Java versions. The upper bound Java version of the Vectorization provider is hardcoded to the versio

Re: [I] Unable to Tessellate shape for a valid Polygon according to GDAL/OGR and PostGIS [lucene]

2024-11-11 Thread via GitHub
iverase closed issue #13841: Unable to Tessellate shape for a valid Polygon according to GDAL/OGR and PostGIS URL: https://github.com/apache/lucene/issues/13841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Tessellator: Improve logic when two holes share the same vertex with the polygon [lucene]

2024-11-11 Thread via GitHub
iverase merged PR #13980: URL: https://github.com/apache/lucene/pull/13980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] [DRAFT] Change vector input from IndexInput to RandomAccessInput [lucene]

2024-11-11 Thread via GitHub
shubhamvishu commented on code in PR #13981: URL: https://github.com/apache/lucene/pull/13981#discussion_r1836169621 ## lucene/core/src/java/org/apache/lucene/store/RandomAccessInput.java: ## @@ -77,4 +85,6 @@ default void readBytes(long pos, byte[] bytes, int offset, int lengt

Re: [PR] [DRAFT] Change vector input from IndexInput to RandomAccessInput [lucene]

2024-11-11 Thread via GitHub
shubhamvishu commented on code in PR #13981: URL: https://github.com/apache/lucene/pull/13981#discussion_r1836169057 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/Lucene99MemorySegmentByteVectorScorer.java: ## @@ -40,8 +41,14 @@ abstract sealed class Lucene9