github-actions[bot] commented on PR #13864:
URL: https://github.com/apache/lucene/pull/13864#issuecomment-2433864889
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
mdmarshmallow opened a new pull request, #13951:
URL: https://github.com/apache/lucene/pull/13951
### Description
Draft PR to outline my initial approach. I introduced
`IndexWriterRamManager` to control writer flushes. I also have a function
`IndexWriterRamManager#chooseWrite
mdmarshmallow commented on issue #13913:
URL: https://github.com/apache/lucene/issues/13913#issuecomment-2433693397
Here is a draft PR if anyone is interested in sanity checking my approach:
https://github.com/apache/lucene/pull/13951
--
This is an automated message from the Apache Git Se
msokolov commented on code in PR #13950:
URL: https://github.com/apache/lucene/pull/13950#discussion_r1813555056
##
lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java:
##
@@ -87,6 +87,28 @@ public Builder add(BooleanClause clause) {
return this;
}
+
javanna commented on PR #13926:
URL: https://github.com/apache/lucene/pull/13926#issuecomment-2433270359
Thanks @dweiss ! Those manual steps worked for me as well. Good to know that
there is at least a way to get the IDE to do something useful with those files,
especially needing to make ch
ljak commented on PR #13944:
URL: https://github.com/apache/lucene/pull/13944#issuecomment-2433229507
I needed to sort the `Query`s in some ways, so I compare them according to
their toString representation:
`orderedQueries.sort(Comparator.comparing(Query::toString));`
Not sure
msokolov commented on code in PR #13572:
URL: https://github.com/apache/lucene/pull/13572#discussion_r1813272520
##
lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/VectorUtilBenchmark.java:
##
@@ -84,6 +91,76 @@ public void init() {
floatsA[i] = random.nextF
shubhamvishu opened a new pull request, #13950:
URL: https://github.com/apache/lucene/pull/13950
### Description
Changes in this PR :
1. Makes some `BooleanQuery` methods that seem useful to user public. Like
the `getClauses(Occur occur` to get the collection of one type of cla
albogdano opened a new pull request, #13949:
URL: https://github.com/apache/lucene/pull/13949
### Description
This PR adds a new module `s3directory` to Lucene, containing a new
`Directory` implementation for AWS S3.
The code was adapted from the
[lucene-s3-directory](https://gith
benwtrent commented on PR #13910:
URL: https://github.com/apache/lucene/pull/13910#issuecomment-2432746347
@mikemccand I have a PR open for this bug fix for 9.12. Will merge soon.
Could you add a CHANGES entry in 9.12 for your bug fix for 9.12.1?
--
This is an automated message fro
jpountz commented on PR #13944:
URL: https://github.com/apache/lucene/pull/13944#issuecomment-2432515126
See `BooleanQuery#clauseSets`, which is used for equals()/hashcode() and
`BooleanQuery#clauses`, which is used for toString().
--
This is an automated message from the Apache Git Servi
ljak commented on PR #13944:
URL: https://github.com/apache/lucene/pull/13944#issuecomment-2432492876
Thanks for the feedback. Looking at `BooleanQuery`, it "only" has one list
`List clauses`. So, is the idea to have 2 structures for the
`DisjunctionMaxQuery`, the unordered multiset of quer
jpountz commented on code in PR #13948:
URL: https://github.com/apache/lucene/pull/13948#discussion_r1812935475
##
lucene/core/src/java/org/apache/lucene/index/BinaryDocValues.java:
##
@@ -33,4 +34,15 @@ protected BinaryDocValues() {}
* @return binary value
*/
public
mikemccand commented on PR #13910:
URL: https://github.com/apache/lucene/pull/13910#issuecomment-2432474472
> This seems like something we maybe ought to make the user community aware
of.
+1 thanks @msokolov.
> @msokolov could we do a simpler patch for 9.12.1?
+1. 9.12.
mikemccand commented on code in PR #13910:
URL: https://github.com/apache/lucene/pull/13910#discussion_r1812937509
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsReader.java:
##
@@ -260,7 +260,7 @@ public void search(String field
iverase closed pull request #12460: Allow reading binary doc values as a
DataInput
URL: https://github.com/apache/lucene/pull/12460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
iverase commented on PR #12460:
URL: https://github.com/apache/lucene/pull/12460#issuecomment-2432383872
I open https://github.com/apache/lucene/pull/13948 which is clearly less
invasive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
iverase opened a new pull request, #13948:
URL: https://github.com/apache/lucene/pull/13948
Following up this
[suggestion](https://github.com/apache/lucene/pull/12460#issuecomment-1715126194)
from @jpountz, here I propose to add a new method to the BinaryDocValues API
that returns the cont
jpountz commented on PR #13943:
URL: https://github.com/apache/lucene/pull/13943#issuecomment-2432246400
Actually, while I was at it, I also removed `TopFieldCollector`'s dependency
on HitsThresholdChecker, and then removed `HitsThresholdChecker`.
```
Ta
gsmiller commented on code in PR #13886:
URL: https://github.com/apache/lucene/pull/13886#discussion_r1812687585
##
lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java:
##
@@ -397,106 +413,80 @@ private boolean matchAll(PointValues points
benwtrent opened a new pull request, #13947:
URL: https://github.com/apache/lucene/pull/13947
Bug discovered in https://github.com/apache/lucene/pull/13910
This corrects the logic so that users in lucene 9.12.1 will be able to
correctly read from Lucene 9.0.0 HNSW indices. Previously,
benwtrent opened a new issue, #13946:
URL: https://github.com/apache/lucene/issues/13946
### Description
git bisect indicated: b940511b07b
```
TestCommonTermsQuery > testMinShouldMatch FAILED
--
| org.junit.ComparisonFailure: expected:<[2]> but was:<[3]>
| at
__
jpountz commented on PR #13941:
URL: https://github.com/apache/lucene/pull/13941#issuecomment-2431805003
There is a good speedup on `OrMany` as expected:
https://benchmarks.mikemccandless.com/OrMany.html. I'll push an annotation.
--
This is an automated message from the Apache Git Service
iverase commented on code in PR #12460:
URL: https://github.com/apache/lucene/pull/12460#discussion_r1812371829
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java:
##
@@ -820,6 +822,201 @@ public BytesRef binaryValue() throws IOException {
iverase commented on code in PR #12460:
URL: https://github.com/apache/lucene/pull/12460#discussion_r1812371829
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java:
##
@@ -820,6 +822,201 @@ public BytesRef binaryValue() throws IOException {
iverase commented on code in PR #12460:
URL: https://github.com/apache/lucene/pull/12460#discussion_r1812371829
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java:
##
@@ -820,6 +822,201 @@ public BytesRef binaryValue() throws IOException {
iverase commented on issue #12459:
URL: https://github.com/apache/lucene/issues/12459#issuecomment-2431552556
Now that lucene 10 has been released and our java minimum version is 21, the
RandomAccessInput API got efficient methods to read byte[] from the method
#readBytes, I think this API
LuXugang opened a new issue, #13945:
URL: https://github.com/apache/lucene/issues/13945
### Description
It seems like we could use
SortedNumericDocValuesRangeQuery#getDocIdSetIteratorOrNullForPrimarySort to
implement Weight#count of SortedNumericDocValuesRangeQuery ?
--
This is an
28 matches
Mail list logo
