javanna opened a new issue, #13791:
URL: https://github.com/apache/lucene/issues/13791
We recently made a change to `TotalHitCountCollectorManager`, to make it
take the leaf slices in its constructor, so that we can automatically decide
what type of collectors are needed. That is because th
javanna commented on issue #11041:
URL: https://github.com/apache/lucene/issues/11041#issuecomment-2351046379
Only the actual removal of the deprecated search(Query, Collector) is left
to do. That is tracked by #12892 hence this issue can be closed/
--
This is an automated message from th
javanna closed issue #11041: Remove IndexSearcher#search(Query,Collector) in
favor of IndexSearcher#search(Query,CollectorManager) [LUCENE-10002]
URL: https://github.com/apache/lucene/issues/11041
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
javanna opened a new pull request, #13790:
URL: https://github.com/apache/lucene/pull/13790
We have recently (see #13735) introduced this utility method that creates a
collector manager which only works when a searcher does not have an executor
set, otherwise it throws exception once we att
mrhbj commented on PR #13788:
URL: https://github.com/apache/lucene/pull/13788#issuecomment-2351022335
@mikemccand You are welcome. I am a ream human. no an AI. -_-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
javanna commented on PR #13735:
URL: https://github.com/apache/lucene/pull/13735#issuecomment-2351020586
I've been changing my mind a few times on the topic, but I am concluding
that it probably was not a good idea to expose the sequential collector
manager. I think we are ok using it inter
mikemccand merged PR #13788:
URL: https://github.com/apache/lucene/pull/13788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1759746984
##
lucene/core/src/java/org/apache/lucene/search/BulkScorer.java:
##
@@ -27,18 +27,6 @@
*/
public abstract class BulkScorer {
- /**
- * Scores and collects all
uschindler commented on PR #13723:
URL: https://github.com/apache/lucene/pull/13723#issuecomment-2350956051
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
mikemccand commented on PR #13767:
URL: https://github.com/apache/lucene/pull/13767#issuecomment-2350934386
I plan to resolve the conflict (just `MIGRATE.md`) and merge this in the
next day or so!
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
stefanvodita closed issue #13720: Reproducible test failure in
TestTaxonomyFacetAssociations.testFloatSumAssociation -- ULP float issue?
URL: https://github.com/apache/lucene/issues/13720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
stefanvodita merged PR #13723:
URL: https://github.com/apache/lucene/pull/13723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
stefanvodita commented on PR #13723:
URL: https://github.com/apache/lucene/pull/13723#issuecomment-2350917639
Thank you Mike and Uwe! I opened a separate issue to replace various
epsilon-based equality checks (#13789), since that could be a large enough
task, and I'll merge this one.
--
gf2121 commented on code in PR #13521:
URL: https://github.com/apache/lucene/pull/13521#discussion_r1759694410
##
lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/DocIdEncodingBenchmark.java:
##
@@ -0,0 +1,404 @@
+/*
+ * Licensed to the Apache Software Foundation (A
vsop-479 commented on PR #13486:
URL: https://github.com/apache/lucene/pull/13486#issuecomment-2350906740
> BTW, since we applyDeletes before writeTerms, should we skip deleted docs
when writing postings(maybe skip storedFields too).
I see this has been discussed in
https://issues.ap
uschindler commented on PR #13572:
URL: https://github.com/apache/lucene/pull/13572#issuecomment-2350900783
> > Anyways: At moment we do not want to have native code in Lucene Core.
>
> +1, we don't put native code in Lucene's `core`.
>
> But @uschindler is there maybe a way for
uschindler commented on code in PR #13572:
URL: https://github.com/apache/lucene/pull/13572#discussion_r1759686028
##
gradle/java/javac.gradle:
##
@@ -24,7 +24,11 @@ allprojects { project ->
// Use 'release' flag instead of 'source' and 'target'
tasks.withType(JavaCo
17 matches
Mail list logo
