Re: [PR] Aggregate files from the same segment into a single Arena [lucene]

ChrisHegarty commented on PR #13570: URL: https://github.com/apache/lucene/pull/13570#issuecomment-2241152532 Subject to review comment, I think the only thing that remains is whether we want to allow the default number of total ref counting to be configurable, say by a system property or s

Re: [PR] Aggregate files from the same segment into a single Arena [lucene]

ChrisHegarty commented on code in PR #13570: URL: https://github.com/apache/lucene/pull/13570#discussion_r1685433634 ## lucene/core/src/java21/org/apache/lucene/store/RefCountedSharedArena.java: ## @@ -47,9 +48,12 @@ boolean acquire() { int value; while (true) {

Re: [PR] Aggregate files from the same segment into a single Arena [lucene]

ChrisHegarty commented on code in PR #13570: URL: https://github.com/apache/lucene/pull/13570#discussion_r1685433524 ## lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInputProvider.java: ## @@ -157,6 +157,8 @@ static Arena getSharedArena( arenas.comp

[PR] [KNN] Add comment and remove duplicate code [lucene]

dungba88 opened a new pull request, #13594: URL: https://github.com/apache/lucene/pull/13594 ### Description - Add comments to methods for easier to understand their behaviors - Remove duplicate codes to createBitSet used in both the main top-k KNN query and vector similarity query