Re: [PR] Add prefetching support to stored fields. [lucene]

2024-05-28 Thread via GitHub
gf2121 commented on code in PR #13424: URL: https://github.com/apache/lucene/pull/13424#discussion_r1618303808 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -609,6 +622,23 @@ public void skipBytes(long num

Re: [PR] Allow users to retrieve counts from taxo association facets [lucene]

2024-05-28 Thread via GitHub
stefanvodita merged PR #13414: URL: https://github.com/apache/lucene/pull/13414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [I] Virtual threads and Lucene (support async tasks) [lucene]

2024-05-28 Thread via GitHub
jpountz closed issue #12531: Virtual threads and Lucene (support async tasks) URL: https://github.com/apache/lucene/issues/12531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Virtual threads and Lucene (support async tasks) [lucene]

2024-05-28 Thread via GitHub
jpountz commented on issue #12531: URL: https://github.com/apache/lucene/issues/12531#issuecomment-2135735022 I think it's fair to close this issue in favor of #13179 since this is mostly about I/O concurrency? -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Reproducible failure TestOrdinalMap.testRamBytesUsed [lucene]

2024-05-28 Thread via GitHub
jpountz closed issue #13372: Reproducible failure TestOrdinalMap.testRamBytesUsed URL: https://github.com/apache/lucene/issues/13372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Fixes failing test case for TestOrdinalMap.testRamBytesUsed [lucene]

2024-05-28 Thread via GitHub
jpountz merged PR #13421: URL: https://github.com/apache/lucene/pull/13421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] hunspell: speed up "compress"; minimize the number of the generated entries; don't even consider "forbidden" entries anymore [lucene]

2024-05-28 Thread via GitHub
donnerpeter merged PR #13429: URL: https://github.com/apache/lucene/pull/13429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

Re: [PR] Use SPI instead of Enum for VectorSimilarityFunctions [lucene]

2024-05-28 Thread via GitHub
Pulkitg64 commented on code in PR #13401: URL: https://github.com/apache/lucene/pull/13401#discussion_r1617506291 ## lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java: ## @@ -3216,10 +3215,11 @@ public static BytesRef newBytesRef(byte[] bytesIn, int

Re: [PR] Rewrite newSlowRangeQuery to MatchNoDocsQuery when upper > lower [lucene]

2024-05-28 Thread via GitHub
jpountz commented on PR #13425: URL: https://github.com/apache/lucene/pull/13425#issuecomment-2135418249 This makes sense to me, can you add a CHANGES entry under 9.11? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Allow users to retrieve counts from taxo association facets [lucene]

2024-05-28 Thread via GitHub
stefanvodita commented on code in PR #13414: URL: https://github.com/apache/lucene/pull/13414#discussion_r1617221613 ## lucene/facet/src/java/org/apache/lucene/facet/LabelAndValue.java: ## @@ -24,10 +24,21 @@ public final class LabelAndValue { /** Value associated with this l

Re: [PR] Allow users to retrieve counts from taxo association facets [lucene]

2024-05-28 Thread via GitHub
slow-J commented on code in PR #13414: URL: https://github.com/apache/lucene/pull/13414#discussion_r1617205193 ## lucene/facet/src/java/org/apache/lucene/facet/LabelAndValue.java: ## @@ -24,10 +24,21 @@ public final class LabelAndValue { /** Value associated with this label.

Re: [PR] Add prefetching support to stored fields. [lucene]

2024-05-28 Thread via GitHub
rmuir commented on code in PR #13424: URL: https://github.com/apache/lucene/pull/13424#discussion_r1617177543 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -609,6 +622,23 @@ public void skipBytes(long numB

Re: [PR] Allow users to retrieve counts from taxo association facets [lucene]

2024-05-28 Thread via GitHub
stefanvodita commented on PR #13414: URL: https://github.com/apache/lucene/pull/13414#issuecomment-2135108041 It would be good to get this out in 9.11, so that we're not computing those counts just for internal usage without letting the user access them. @benwtrent wanted to start the relea

Re: [PR] Optimize Japanese UserDictionary. [lucene]

2024-05-28 Thread via GitHub
bruno-roustant commented on code in PR #13431: URL: https://github.com/apache/lucene/pull/13431#discussion_r1617116464 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/UserDictionary.java: ## @@ -168,33 +171,53 @@ public UserMorphData getMorphAttributes()

Re: [PR] Optimize Japanese UserDictionary. [lucene]

2024-05-28 Thread via GitHub
bruno-roustant commented on code in PR #13431: URL: https://github.com/apache/lucene/pull/13431#discussion_r1617111686 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/UserDictionary.java: ## @@ -168,33 +171,53 @@ public UserMorphData getMorphAttributes()