github-actions[bot] commented on PR #12857:
URL: https://github.com/apache/lucene/pull/12857#issuecomment-2134164315
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
github-actions[bot] commented on PR #13285:
URL: https://github.com/apache/lucene/pull/13285#issuecomment-2134164108
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
uschindler commented on PR #13428:
URL: https://github.com/apache/lucene/pull/13428#issuecomment-2134102574
Merged. I also removed the useless extra "uses" clause in test-frameworks
module-info.java. Missed to do this here.
--
This is an automated message from the Apache Git Service.
To r
uschindler merged PR #13428:
URL: https://github.com/apache/lucene/pull/13428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
jpountz commented on code in PR #13424:
URL: https://github.com/apache/lucene/pull/13424#discussion_r1616375903
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java:
##
@@ -609,6 +622,23 @@ public void skipBytes(long nu
carlosdelest opened a new pull request, #13430:
URL: https://github.com/apache/lucene/pull/13430
Closes https://github.com/apache/lucene/issues/12877
Adds a minimum number of segments to `TieredMergePolicy`. This allows to
ensure that a minimum search concurrency parallelism is achiev
dweiss commented on PR #13323:
URL: https://github.com/apache/lucene/pull/13323#issuecomment-2133921546
Apologies for the delay, @benchaplin - I've merged this test into the main
branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dweiss merged PR #13323:
URL: https://github.com/apache/lucene/pull/13323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
navneet1v commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2133915854
> At moment there's also missing the getter for list of names.
@uschindler, when raising the PR I saw this and thought is it needed or not.
To ensure the scope of the PR was
navneet1v commented on PR #13394:
URL: https://github.com/apache/lucene/pull/13394#issuecomment-2133913068
@uschindler thanks. I didn't realize it. Generally I see labels added or
last time I raised the PR manually for backport. Thanks for confirming this
code is merged.
--
This is an au
uschindler commented on PR #13429:
URL: https://github.com/apache/lucene/pull/13429#issuecomment-2133898015
@rmuir can you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
dweiss commented on PR #13429:
URL: https://github.com/apache/lucene/pull/13429#issuecomment-2133896366
> I can add some comments with explanations :)
No need. I glanced through the code and it doesn't seem to be a backdoor. :)
You know better what works here anyway.
--
This is an
uschindler commented on PR #13394:
URL: https://github.com/apache/lucene/pull/13394#issuecomment-2133895659
thats already merged (see above @ "asfgit pushed").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
donnerpeter commented on PR #13429:
URL: https://github.com/apache/lucene/pull/13429#issuecomment-2133893031
> I admit I've no idea what improvement I'm looking at here but I trust you
know!
I can add some comments with explanations :)
--
This is an automated message from the Apach
navneet1v commented on PR #13394:
URL: https://github.com/apache/lucene/pull/13394#issuecomment-2133879878
@uschindler do i need to create a separate PR for porting this change to
branch_9x or there is any automated way to do this?
--
This is an automated message from the Apache Git Servi
uschindler commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1616292043
##
lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java:
##
@@ -16,104 +16,88 @@
*/
package org.apache.lucene.index;
-import static org.a
uschindler commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1616291449
##
lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java:
##
@@ -16,104 +16,88 @@
*/
package org.apache.lucene.index;
-import static org.a
uschindler commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1616290305
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java:
##
@@ -3216,10 +3215,11 @@ public static BytesRef newBytesRef(byte[] bytesIn, in
uschindler commented on PR #13428:
URL: https://github.com/apache/lucene/pull/13428#issuecomment-2133868897
This also make the method static to be in conformance with other
LuceneTestCase methods
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
uschindler commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2133868504
see #13428
This also fixed the concern in other PR with SPI named similarity functions
--
This is an automated message from the Apache Git Service.
To respond to the mes
uschindler opened a new pull request, #13428:
URL: https://github.com/apache/lucene/pull/13428
This cleans up the code:
- Remove expensive usage of ServiceLoader which might be inconsistent with
the NamedSPI code
- Add a better readable version with comment about the special case
rega
uschindler closed issue #13393: Add support for reloading the SPI for
KnnVectorsFormat class
URL: https://github.com/apache/lucene/issues/13393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
uschindler commented on issue #13393:
URL: https://github.com/apache/lucene/issues/13393#issuecomment-2133837367
Thanks for bringing this up.
Unfortunately we have no way to automatically enforce this for our NamedSPI
provides (as it is static methods), but we should keep all of them
uschindler commented on PR #13394:
URL: https://github.com/apache/lucene/pull/13394#issuecomment-2133833594
Done! Thanks, @navneet1v
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
uschindler merged PR #13394:
URL: https://github.com/apache/lucene/pull/13394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
navneet1v commented on PR #13394:
URL: https://github.com/apache/lucene/pull/13394#issuecomment-2133829356
@ChrisHegarty , @uschindler can merge the code and add the backport label to
backport the code to branch_9x
--
This is an automated message from the Apache Git Service.
To respond to
ChrisHegarty closed issue #13426: Examine assertion in
org.apache.lucene.analysis.ko.dict.UserDictionary
URL: https://github.com/apache/lucene/issues/13426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ChrisHegarty merged PR #13427:
URL: https://github.com/apache/lucene/pull/13427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
uschindler commented on code in PR #13427:
URL: https://github.com/apache/lucene/pull/13427#discussion_r1616257319
##
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/UserDictionary.java:
##
@@ -134,7 +135,9 @@ private UserDictionary(List entries) throws
IOExcep
rmuir commented on code in PR #13424:
URL: https://github.com/apache/lucene/pull/13424#discussion_r1616256454
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java:
##
@@ -609,6 +622,23 @@ public void skipBytes(long numB
rmuir commented on code in PR #13424:
URL: https://github.com/apache/lucene/pull/13424#discussion_r1616250356
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java:
##
@@ -609,6 +622,23 @@ public void skipBytes(long numB
ChrisHegarty commented on code in PR #13427:
URL: https://github.com/apache/lucene/pull/13427#discussion_r1616246358
##
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/UserDictionary.java:
##
@@ -134,7 +135,9 @@ private UserDictionary(List entries) throws
IOExc
uschindler commented on code in PR #13427:
URL: https://github.com/apache/lucene/pull/13427#discussion_r1616243372
##
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/UserDictionary.java:
##
@@ -134,7 +135,9 @@ private UserDictionary(List entries) throws
IOExcep
uschindler commented on code in PR #13427:
URL: https://github.com/apache/lucene/pull/13427#discussion_r1616243372
##
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/UserDictionary.java:
##
@@ -134,7 +135,9 @@ private UserDictionary(List entries) throws
IOExcep
bruno-roustant commented on PR #13427:
URL: https://github.com/apache/lucene/pull/13427#issuecomment-2133794952
The Japanese UserDictionary is quite different, and I didn't touch it.
Although I plan later to replace the TreeMap of Integer if possible.
--
This is an automated message from
ChrisHegarty merged PR #13423:
URL: https://github.com/apache/lucene/pull/13423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
ChrisHegarty commented on PR #13427:
URL: https://github.com/apache/lucene/pull/13427#issuecomment-2133790710
org.apache.lucene.analysis.ja.dict.UserDictionary looks ok to me - no issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
uschindler commented on PR #13427:
URL: https://github.com/apache/lucene/pull/13427#issuecomment-2133787102
Do we have the same issue in kuromoji's UserDictionary? I just want to make
sure about this because both nori and kuromoji use similar code.
In @bruno-roustant 's PR where he ch
bruno-roustant commented on PR #13427:
URL: https://github.com/apache/lucene/pull/13427#issuecomment-2133781188
I'm glad to have added this assertion :) It caught a misunderstanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
bruno-roustant commented on PR #13427:
URL: https://github.com/apache/lucene/pull/13427#issuecomment-2133778754
The recent code change replaced the previous List by a primitive
structure.
To avoid yet another hppc primitive list in the Lucene fork, this time I
replaced by a basic short a
ChrisHegarty commented on code in PR #13427:
URL: https://github.com/apache/lucene/pull/13427#discussion_r1616231384
##
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/UserDictionary.java:
##
@@ -134,7 +134,6 @@ private UserDictionary(List entries) throws
IOExc
bruno-roustant commented on code in PR #13427:
URL: https://github.com/apache/lucene/pull/13427#discussion_r1616229789
##
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/UserDictionary.java:
##
@@ -134,7 +134,6 @@ private UserDictionary(List entries) throws
IOE
ChrisHegarty commented on PR #13427:
URL: https://github.com/apache/lucene/pull/13427#issuecomment-2133741247
Unless I'm mistaken, this recently added assertion is incorrect, so should
simply be removed.
--
This is an automated message from the Apache Git Service.
To respond to the messa
bruno-roustant commented on issue #13426:
URL: https://github.com/apache/lucene/issues/13426#issuecomment-2133732763
Thanks for the heads up. I look at that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
ChrisHegarty commented on issue #13426:
URL: https://github.com/apache/lucene/issues/13426#issuecomment-2133707953
@bruno-roustant Unless I'm mistaken, this issue relates to your change in
#13406. I think that the assertion is just incorrect?
--
This is an automated message from the Apach
ChrisHegarty opened a new issue, #13426:
URL: https://github.com/apache/lucene/issues/13426
A recent change, #13406 , added an assertion that may be incorrect.
The assertion asserts that the number of entries matches that of the number
of inputs processed. This may not be the case the
jpountz commented on PR #13424:
URL: https://github.com/apache/lucene/pull/13424#issuecomment-2133420215
Like for previous changes, I wrote a synthetic benchmark to make sure that
this new API actually helps.
This benchmark simulates fetching 20 random stored documents in
paralle
ioanatia opened a new pull request, #13425:
URL: https://github.com/apache/lucene/pull/13425
We already have a check in place that rewrites
`SortedNumericDocValuesRangeQuery` to a `FieldExistsQuery` when the lookup
range interval is `[ Long.MIN_VALUE, Long.MAX_VALUE]`.
This PR adds a
jpountz opened a new pull request, #13424:
URL: https://github.com/apache/lucene/pull/13424
This adds `StoredFields#prefetch(int)`, which mostly delegates to
`IndexInput#prefetch`. Callers can take advantage of this API to parallelize
I/O across multiple stored documents by first calling `S
RS146BIJAY commented on issue #13387:
URL: https://github.com/apache/lucene/issues/13387#issuecomment-2133354180
> I agree that better organizing data across segments yields significant
benefits, I'm only advocating for doing this by maintaining a separate
IndexWriter for each group instead
bruno-roustant commented on PR #13422:
URL: https://github.com/apache/lucene/pull/13422#issuecomment-2133194059
Backport to branch_9x complete!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
uschindler commented on PR #13422:
URL: https://github.com/apache/lucene/pull/13422#issuecomment-2133150944
Go ahead!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
bruno-roustant merged PR #13422:
URL: https://github.com/apache/lucene/pull/13422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@luc
dweiss commented on PR #13422:
URL: https://github.com/apache/lucene/pull/13422#issuecomment-2133132538
I'd merge it right away, I don't see the point in waiting. If there are
conflicts - they should be easy to resolve.
--
This is an automated message from the Apache Git Service.
To respo
bruno-roustant commented on PR #13422:
URL: https://github.com/apache/lucene/pull/13422#issuecomment-2133113969
Thank you Dawid!
I can work on the backport to 9x.
How long should we wait for this PR before merging it?
Given it is large, it has higher probabilities of conflicts, i
dweiss commented on PR #13422:
URL: https://github.com/apache/lucene/pull/13422#issuecomment-2133074149
I can't remember what the problem was, to be honest. Will have to return to
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dweiss commented on PR #13422:
URL: https://github.com/apache/lucene/pull/13422#issuecomment-2133003069
I think the only thing missing is perhaps a changes entry and migration
entry warning people that the dependency is gone and that the currently exposed
internal package will be gone witho
vsop-479 commented on code in PR #13253:
URL: https://github.com/apache/lucene/pull/13253#discussion_r1615722587
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnum.java:
##
@@ -434,8 +436,29 @@ public boolean seekExact(BytesRef target) throws
I
bruno-roustant commented on PR #13422:
URL: https://github.com/apache/lucene/pull/13422#issuecomment-2132983280
I agree with the baby step, and this PR is already massive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
pseudo-nymous commented on code in PR #13421:
URL: https://github.com/apache/lucene/pull/13421#discussion_r1615714149
##
lucene/core/src/test/org/apache/lucene/index/TestOrdinalMap.java:
##
@@ -52,7 +53,9 @@ public long accumulateObject(
long shallowSize,
ChrisHegarty commented on PR #13401:
URL: https://github.com/apache/lucene/pull/13401#issuecomment-2132962554
> The main motivation behind this change was to get rid of ENUM
implementation which is tightly coupled to field-info. This has caused
inconvenience in deprecating the COSINE functi
vsop-479 commented on code in PR #13253:
URL: https://github.com/apache/lucene/pull/13253#discussion_r1615706277
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnum.java:
##
@@ -434,8 +436,29 @@ public boolean seekExact(BytesRef target) throws
I
dweiss commented on PR #13422:
URL: https://github.com/apache/lucene/pull/13422#issuecomment-2132910636
So compilation works, but tests won't fly with this change. Recall we run
tests in "classpath mode" so even though modules compile, for tests they're on
classpath and then can't access in
jpountz commented on issue #13410:
URL: https://github.com/apache/lucene/issues/13410#issuecomment-2132905389
@navneet1v Since a `Scorer` must be created from a `Weight`, callers would
be expected to keep track of the `Weight` that created the `Scorer` if they
need it instead of relying on
jpountz commented on PR #13359:
URL: https://github.com/apache/lucene/pull/13359#issuecomment-2132902792
Now that #13408 has been merged, I could update the benchmark to simply call
IndexSearcher#search.
```java
import java.io.IOException;
import java.io.UncheckedIOE
vsop-479 commented on code in PR #13253:
URL: https://github.com/apache/lucene/pull/13253#discussion_r1615655198
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnum.java:
##
@@ -434,8 +436,29 @@ public boolean seekExact(BytesRef target) throws
I
vsop-479 commented on code in PR #13253:
URL: https://github.com/apache/lucene/pull/13253#discussion_r1615651266
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnum.java:
##
@@ -573,7 +609,20 @@ public boolean seekExact(BytesRef target) throws
I
vsop-479 commented on code in PR #13253:
URL: https://github.com/apache/lucene/pull/13253#discussion_r1615650665
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnum.java:
##
@@ -710,8 +761,28 @@ public SeekStatus seekCeil(BytesRef target) throws
vsop-479 commented on code in PR #13253:
URL: https://github.com/apache/lucene/pull/13253#discussion_r1615645890
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java:
##
@@ -287,6 +287,68 @@ void rewind() {
*/
}
+ // Only rewi
dweiss commented on PR #13422:
URL: https://github.com/apache/lucene/pull/13422#issuecomment-2132876361
I'll push to this PR, if you don't mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
jpountz merged PR #13408:
URL: https://github.com/apache/lucene/pull/13408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
bruno-roustant commented on PR #13422:
URL: https://github.com/apache/lucene/pull/13422#issuecomment-2132844966
Do you want to move in this PR, or in another PR once this one is merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
bruno-roustant commented on PR #13422:
URL: https://github.com/apache/lucene/pull/13422#issuecomment-2132834604
Ok, Dawid I let you move the fork.
I added the @lucene.internal annotations. I like that this hppc integration
is cleaner and well defined now.
--
This is an automated messag
dweiss commented on PR #13422:
URL: https://github.com/apache/lucene/pull/13422#issuecomment-2132824844
I'll do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
uschindler commented on PR #13422:
URL: https://github.com/apache/lucene/pull/13422#issuecomment-2132806647
Ah I see you mentioned the missing move in the PR description, sorry!
So except the `@lucene.internal` javadocs (should be added always, also when
in private package), +1
--
bruno-roustant opened a new pull request, #13422:
URL: https://github.com/apache/lucene/pull/13422
- Add the required classes to the hppc fork.
- Remove the hppc dependency from the facet, join, spatial modules.
- Remove the hppc version from versions.props and versions.lock.
It
76 matches
Mail list logo
