dweiss commented on PR #13422:
URL: https://github.com/apache/lucene/pull/13422#issuecomment-2132910636
So compilation works, but tests won't fly with this change. Recall we run
tests in "classpath mode" so even though modules compile, for tests they're on
classpath and then can't access internal packages from the core. Here's an
example:
```
> java.lang.IllegalAccessError: class
org.apache.lucene.search.join.DiversifyingNearestChildrenKnnCollector$NodeIdCachingHeap
(in unnamed module @0x68472863) cannot access class
org.apache.lucene.util.hppc.IntIntHashMap (in module org.apache.lucene.core)
because module org.apache.lucene.core does not export
org.apache.lucene.util.hppc to unnamed module @0x68472863
> at
__randomizedtesting.SeedInfo.seed([9A5633A49FE14BF7:FC682151F0E8CD34]:0)
> at
org.apache.lucene.search.join.DiversifyingNearestChildrenKnnCollector$NodeIdCachingHeap.<init>(DiversifyingNearestChildrenKnnCollector.java:132)
> at
org.apache.lucene.search.join.DiversifyingNearestChildrenKnnCollector.<init>(DiversifyingNearestChildrenKnnCollector.java:47)
> at
org.apache.lucene.search.join.DiversifyingNearestChildrenKnnCollectorManager.newCollector(DiversifyingNearestChildrenKnnCollectorManager.java:68)
> at
org.apache.lucene.core@10.0.0-SNAPSHOT/org.apache.lucene.search.TimeLimitingKnnCollectorManager.newCollector(TimeLimitingKnnCollectorManager.java:41)
```
Fixing this requires going down the rabbit hole of compiling and running
tests with module patching and/or moving tests to a separate module and
reorganizing their internals so that there are no split packages. Invasive...
I wonder if the first baby step shouldn't be to move the hppc forked classes
to .internal. (with proper annotation), but - sadly - export that package until
we figure out how to compile and run tests in full modular mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
