[PR] Fix test failure TestKnnByteVectorQuery.testTimeLimitingKnnCollectorManager [lucene]

2024-04-16 Thread via GitHub
easyice opened a new pull request, #13312: URL: https://github.com/apache/lucene/pull/13312 `TopKnnCollectorManager#newCollector` will return `MultiLeafKnnCollector` instance if the index has multiple segments ``` org.apache.lucene.search.TestKnnByteVectorQuery > testTimeLimitingK

Re: [PR] Use jdk11 primitives to allow backport to branch_9x [lucene]

2024-04-16 Thread via GitHub
vigyasharma merged PR #13311: URL: https://github.com/apache/lucene/pull/13311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

[PR] Use jdk11 primitives to allow backport to branch_9x [lucene]

2024-04-16 Thread via GitHub
vigyasharma opened a new pull request, #13311: URL: https://github.com/apache/lucene/pull/13311 `BaseKnnVectorQueryTestCase#testTimeLimitingKnnCollectorManager` uses some new java primitives that are breaking on backport to branch_9x, which builds with OpenJdk 11. We don't really need the n

Re: [PR] Change MASKS from int[] to byte[], and assign it with left shift in UTF32ToUTF8 [lucene]

2024-04-16 Thread via GitHub
vsop-479 commented on PR #13310: URL: https://github.com/apache/lucene/pull/13310#issuecomment-2060280881 Add optimization: Only set first byte for tmpUTF8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Remove unnecessary `AbstractKnnVectorQuery.exactSearch()` [lucene]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #13143: URL: https://github.com/apache/lucene/pull/13143#issuecomment-2060105356 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Pass custom similarity function to similarityToQueryVector API [lucene]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #13187: URL: https://github.com/apache/lucene/pull/13187#issuecomment-2060105283 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [I] Deprecate `COSINE` before Lucene 10 release [lucene]

2024-04-16 Thread via GitHub
jmazanec15 commented on issue #13281: URL: https://github.com/apache/lucene/issues/13281#issuecomment-2059602419 Thanks @benwtrent that makes sense -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Add BitVectors format and make flat vectors format easier to extend [lucene]

2024-04-16 Thread via GitHub
jimczi commented on PR #13288: URL: https://github.com/apache/lucene/pull/13288#issuecomment-2059552949 > I am not a huge fan of how every scorer can now just get a "queryOrdinal" and overwrite whatever query was passed to it. Yep that's tricky. I couldn't find a better way since my g

Re: [I] Deprecate `COSINE` before Lucene 10 release [lucene]

2024-04-16 Thread via GitHub
jmazanec15 commented on issue #13281: URL: https://github.com/apache/lucene/issues/13281#issuecomment-2059318306 @benwtrent Is the main reason to deprecate to stop enabling users to setup non-optimal configurations? Or are there limitations cosine similarity imposes on implementation/optimi

Re: [PR] SOLR-14763 SolrJ HTTP/2 Async API using CompletableFuture [lucene-solr]

2024-04-16 Thread via GitHub
itygh commented on PR #1770: URL: https://github.com/apache/lucene-solr/pull/1770#issuecomment-2059285160 这是来自QQ邮箱的假期自动回复邮件。您好,我最近正在休假中,无法亲自回复您的邮件。我将在假期结束后,尽快给您回复。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] SOLR-14763 SolrJ HTTP/2 Async API using CompletableFuture [lucene-solr]

2024-04-16 Thread via GitHub
jdyer1 commented on PR #1770: URL: https://github.com/apache/lucene-solr/pull/1770#issuecomment-205928 Superseded by PR 2402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] SOLR-14763 SolrJ HTTP/2 Async API using CompletableFuture [lucene-solr]

2024-04-16 Thread via GitHub
jdyer1 closed pull request #1770: SOLR-14763 SolrJ HTTP/2 Async API using CompletableFuture URL: https://github.com/apache/lucene-solr/pull/1770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-16 Thread via GitHub
Pulkitg64 commented on code in PR #13308: URL: https://github.com/apache/lucene/pull/13308#discussion_r1567435158 ## lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java: ## @@ -61,24 +60,6 @@ public float compare(byte[] v1, byte[] v2) { } }, - /

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-16 Thread via GitHub
benwtrent commented on code in PR #13308: URL: https://github.com/apache/lucene/pull/13308#discussion_r1567337317 ## lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java: ## @@ -61,24 +60,6 @@ public float compare(byte[] v1, byte[] v2) { } }, - /

Re: [PR] Add more backwards compability tests for Scalar quantization [lucene]

2024-04-16 Thread via GitHub
benwtrent merged PR #13298: URL: https://github.com/apache/lucene/pull/13298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [PR] Add more backwards compability tests for Scalar quantization [lucene]

2024-04-16 Thread via GitHub
benwtrent commented on code in PR #13298: URL: https://github.com/apache/lucene/pull/13298#discussion_r1567290940 ## lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99ScalarQuantizedVectorsWriter.java: ## @@ -453,10 +492,6 @@ private ScalarQuantizedCloseableRandomVe

Re: [PR] Convert FieldEntry to record [lucene]

2024-04-16 Thread via GitHub
uschindler commented on PR #13296: URL: https://github.com/apache/lucene/pull/13296#issuecomment-2058660008 Thanks, will merge soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Convert FieldEntry to record [lucene]

2024-04-16 Thread via GitHub
uschindler merged PR #13296: URL: https://github.com/apache/lucene/pull/13296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[PR] Change MASKS from int[] to byte[], and assign it with left shift in UTF32ToUTF8 [lucene]

2024-04-16 Thread via GitHub
vsop-479 opened a new pull request, #13310: URL: https://github.com/apache/lucene/pull/13310 ### Description Change `MASKS` from `int[]` to `byte[]`, and assign it with left shift in `UTF32ToUTF8`. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Convert FieldEntry to record [lucene]

2024-04-16 Thread via GitHub
uschindler commented on code in PR #13296: URL: https://github.com/apache/lucene/pull/13296#discussion_r1566932111 ## lucene/CHANGES.txt: ## @@ -102,6 +102,9 @@ API Changes Additionally, deprecated methods have been removed from ByteBuffersIndexInput, BooleanQuery and others

Re: [PR] Convert FieldEntry to record [lucene]

2024-04-16 Thread via GitHub
uschindler commented on code in PR #13296: URL: https://github.com/apache/lucene/pull/13296#discussion_r1566931179 ## lucene/CHANGES.txt: ## @@ -102,6 +102,9 @@ API Changes Additionally, deprecated methods have been removed from ByteBuffersIndexInput, BooleanQuery and others

Re: [PR] Convert FieldEntry to record [lucene]

2024-04-16 Thread via GitHub
uschindler commented on code in PR #13296: URL: https://github.com/apache/lucene/pull/13296#discussion_r1566931179 ## lucene/CHANGES.txt: ## @@ -102,6 +102,9 @@ API Changes Additionally, deprecated methods have been removed from ByteBuffersIndexInput, BooleanQuery and others