Re: [I] LUCENE-9071: Speed up BM25 scores. (#1043) [lucene]

2024-04-15 Thread via GitHub
IcanDoItL commented on issue #13299: URL: https://github.com/apache/lucene/issues/13299#issuecomment-2058217482 @jpountz thanks > Try to compute BM25 scores with a few freqs and you'll find cases when you get a lower score evern though freq is greater by one ulp. I didn't find during m

Re: [PR] Terminate automaton after matched the whole prefix for PrefixQuery. [lucene]

2024-04-15 Thread via GitHub
vsop-479 commented on code in PR #13072: URL: https://github.com/apache/lucene/pull/13072#discussion_r1565442746 ## lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java: ## @@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) { } }

Re: [PR] Add more backwards compability tests for Scalar quantization [lucene]

2024-04-15 Thread via GitHub
jpountz commented on code in PR #13298: URL: https://github.com/apache/lucene/pull/13298#discussion_r1566470754 ## lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99ScalarQuantizedVectorsWriter.java: ## @@ -98,18 +98,49 @@ public final class Lucene99ScalarQuantizedV

Re: [I] LUCENE-9071: Speed up BM25 scores. (#1043) [lucene]

2024-04-15 Thread via GitHub
jpountz commented on issue #13299: URL: https://github.com/apache/lucene/issues/13299#issuecomment-2057854057 The problem is not with `norm` but with `freq` in that case. Try to compute BM25 scores with a few freqs and you'll find cases when you get a lower score evern though freq is greate

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-15 Thread via GitHub
Pulkitg64 commented on PR #13308: URL: https://github.com/apache/lucene/pull/13308#issuecomment-205980 `TestInt8HnswBackwardsCompatibility.java` and `TestBasicBackwardsCompatibility` test cases failing for Lucene versions older than `LUCENE_10_0_0`. For older Lucene version, we try to r

[PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-15 Thread via GitHub
Pulkitg64 opened a new pull request, #13308: URL: https://github.com/apache/lucene/pull/13308 ### Description Tries to solve #13281 by deprecating `COSINE` VectorSimilarity function for Vector Search. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Add BitVectors format and make flat vectors format easier to extend [lucene]

2024-04-15 Thread via GitHub
benwtrent commented on PR #13288: URL: https://github.com/apache/lucene/pull/13288#issuecomment-2057715372 @jimczi OK, I read a bit more of your suggestion. I am not a huge fan of how every scorer can now just get a "queryOrdinal" and overwrite whatever query was passed to it.

Re: [PR] Add BitVectors format and make flat vectors format easier to extend [lucene]

2024-04-15 Thread via GitHub
ChrisHegarty commented on PR #13288: URL: https://github.com/apache/lucene/pull/13288#issuecomment-2057682888 I would like to suggest that we reintroduce `getSlice`. The `getSlice` method is critical to any serious implementation that wants to take things into its own hands. The `getSlice`

Re: [PR] Fix test failure TestDocumentsImpl.testGetDocumentFields [lucene]

2024-04-15 Thread via GitHub
easyice merged PR #13303: URL: https://github.com/apache/lucene/pull/13303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Fix test failure TestDocumentsImpl.testGetDocumentFields [lucene]

2024-04-15 Thread via GitHub
easyice commented on PR #13303: URL: https://github.com/apache/lucene/pull/13303#issuecomment-2056925945 @benwtrent Thank you for reviewing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [I] Reproducible failure in TestXYPoint.testEqualsAndHashCode [lucene]

2024-04-15 Thread via GitHub
easyice closed issue #13292: Reproducible failure in TestXYPoint.testEqualsAndHashCode URL: https://github.com/apache/lucene/issues/13292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Use Float.compare/Double.compare instead of '==' in geo classes [lucene]

2024-04-15 Thread via GitHub
easyice merged PR #13301: URL: https://github.com/apache/lucene/pull/13301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Use Float.compare/Double.compare instead of '==' in geo classes [lucene]

2024-04-15 Thread via GitHub
timgrein commented on PR #13301: URL: https://github.com/apache/lucene/pull/13301#issuecomment-2056734019 > Thanks for adding those tests! this change looks good to me. Thanks! Feel free to merge as I don't have write access to the repo :) -- This is an automated message from the Ap

Re: [PR] Fix test failure TestDocumentsImpl.testGetDocumentFields [lucene]

2024-04-15 Thread via GitHub
easyice commented on PR #13303: URL: https://github.com/apache/lucene/pull/13303#issuecomment-2056727178 This PR will also fix failure `TestDocumentsImpl.testNextTermDoc` ``` org.apache.lucene.luke.models.documents.TestDocumentsImpl > testNextTermDoc FAILED java.lang.Ass

[I] Reproducible failure in TestXYLineShapeDVQueries.testRandomBig [lucene]

2024-04-15 Thread via GitHub
easyice opened a new issue, #13307: URL: https://github.com/apache/lucene/issues/13307 ### Description ``` org.apache.lucene.document.TestXYLineShapeDVQueries > testRandomBig FAILED java.lang.AssertionError: wrong hit (first of possibly more): FAIL: id=33539 should

[PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-15 Thread via GitHub
boicehuang opened a new pull request, #13306: URL: https://github.com/apache/lucene/pull/13306 Elasticsearch (which based on lucene) can automatically infer types for users with its dynamic mapping feature. When users index some low cardinality fields, such as gender / age / status... they

[I] Reproducible failure in TestRandomSpatialOpFuzzyPrefixTree50.testContains [lucene]

2024-04-15 Thread via GitHub
easyice opened a new issue, #13305: URL: https://github.com/apache/lucene/issues/13305 ### Description ``` org.apache.lucene.spatial.prefix.TestRandomSpatialOpFuzzyPrefixTree50 > testContains {seed=[D8D9377B6829FC6:8722AB73973A7961]} FAILED java.lang.AssertionError: Shou

[I] Reproducible failure in TestNRTThreads.testNRTThreads [lucene]

2024-04-15 Thread via GitHub
easyice opened a new issue, #13304: URL: https://github.com/apache/lucene/issues/13304 ### Description ``` org.apache.lucene.index.TestNRTThreads > testNRTThreads FAILED java.io.IOException: MockDirectoryWrapper: file "_3.cfs" is still open: cannot delete at

Re: [PR] Use Float.compare/Double.compare instead of '==' in geo classes [lucene]

2024-04-15 Thread via GitHub
easyice commented on PR #13301: URL: https://github.com/apache/lucene/pull/13301#issuecomment-2056595089 Thanks for adding those tests! this change looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Converted FieldEntry to record [lucene]

2024-04-15 Thread via GitHub
uschindler commented on PR #13296: URL: https://github.com/apache/lucene/pull/13296#issuecomment-2056532260 > The change looks good to me, I'd like @uschindler to have a look since he knows more about records than I do. They are not too complicated, you just have to think simpler and

Re: [PR] Converted FieldEntry to record [lucene]

2024-04-15 Thread via GitHub
uschindler commented on code in PR #13296: URL: https://github.com/apache/lucene/pull/13296#discussion_r1565551378 ## lucene/MIGRATE.md: ## @@ -180,6 +180,8 @@ access the members using method calls instead of field accesses. Affected classe - `IOContext`, `MergeInfo`, and `F

Re: [PR] Terminate automaton after matched the whole prefix for PrefixQuery. [lucene]

2024-04-15 Thread via GitHub
vsop-479 commented on code in PR #13072: URL: https://github.com/apache/lucene/pull/13072#discussion_r1565442746 ## lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java: ## @@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) { } }

Re: [PR] Terminate automaton after matched the whole prefix for PrefixQuery. [lucene]

2024-04-15 Thread via GitHub
vsop-479 commented on code in PR #13072: URL: https://github.com/apache/lucene/pull/13072#discussion_r1515861738 ## lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java: ## @@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) { } }

Re: [PR] Terminate automaton after matched the whole prefix for PrefixQuery. [lucene]

2024-04-15 Thread via GitHub
vsop-479 commented on code in PR #13072: URL: https://github.com/apache/lucene/pull/13072#discussion_r1544202746 ## lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java: ## @@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) { } }

Re: [PR] Use Float.compare/Double.compare instead of '==' in geo classes [lucene]

2024-04-15 Thread via GitHub
timgrein commented on PR #13301: URL: https://github.com/apache/lucene/pull/13301#issuecomment-2056057821 @easyice Adapted the PR with some changes I've described in the PR description 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Terminate automaton after matched the whole prefix for PrefixQuery. [lucene]

2024-04-15 Thread via GitHub
vsop-479 commented on code in PR #13072: URL: https://github.com/apache/lucene/pull/13072#discussion_r1565285501 ## lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java: ## @@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) { } }