Re: [I] gradlew regenerate fails with current gradle version [lucene]

2024-04-08 Thread via GitHub
dweiss closed issue #13240: gradlew regenerate fails with current gradle version URL: https://github.com/apache/lucene/issues/13240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Schedule compileJava after the internal task if it affects source files [lucene]

2024-04-08 Thread via GitHub
dweiss merged PR #13282: URL: https://github.com/apache/lucene/pull/13282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Schedule compileJava after the internal task if it affects source files [lucene]

2024-04-08 Thread via GitHub
dweiss commented on PR #13282: URL: https://github.com/apache/lucene/pull/13282#issuecomment-2044189934 Ah, forgot to revert that help commit - thank you for remembering about this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [I] Multi-value Support for KnnVectorField [lucene]

2024-04-08 Thread via GitHub
vigyasharma commented on issue #12313: URL: https://github.com/apache/lucene/issues/12313#issuecomment-2044076948 What are some use-cases for multi-valued vectors that are not easily supported using parent-child block joins? I'd like to contribute here, trying to understand our main

Re: [PR] Add WrappedCandidateMatcher for composing matchers [lucene]

2024-04-08 Thread via GitHub
github-actions[bot] commented on PR #13109: URL: https://github.com/apache/lucene/pull/13109#issuecomment-2043922410 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Fix failing BaseKnnVectorQueryTestCase#testTimeout [lucene]

2024-04-08 Thread via GitHub
kaivalnp commented on PR #13283: URL: https://github.com/apache/lucene/pull/13283#issuecomment-2043802370 Side note: the original command to reproduce from https://github.com/apache/lucene/pull/13202#issuecomment-2037932211: ``` gradlew :lucene:core:test --tests "org.apache.lucene

[PR] Fix failing BaseKnnVectorQueryTestCase#testTimeout [lucene]

2024-04-08 Thread via GitHub
kaivalnp opened a new pull request, #13283: URL: https://github.com/apache/lucene/pull/13283 ### Description Fixes #13272 The failure happens because of [this assumption](https://github.com/apache/lucene/blob/df0384c34fde8118513e7bc7b79dbde923070c8b/lucene/core/src/test/org/ap

Re: [PR] Schedule compileJava after the internal task if it affects source files [lucene]

2024-04-08 Thread via GitHub
rmuir commented on PR #13282: URL: https://github.com/apache/lucene/pull/13282#issuecomment-2043647391 running a test of this "real quick", thank you. The DFA isn't as hugely painful as it was, I think we made it faster a while back, even on my machine. -- This is an automated message fro

[PR] Schedule compileJava after the internal task if it affects source files [lucene]

2024-04-08 Thread via GitHub
dweiss opened a new pull request, #13282: URL: https://github.com/apache/lucene/pull/13282 Fixes #13240, hopefully. I've added a manual ordering of compileJava to be scheduled after the internal regeneration tasks, where applicable (which is in most cases). I ran most regeneration wi

Re: [PR] UnifiedHighlighter highlight on multiple fields [lucene]

2024-04-08 Thread via GitHub
jimczi commented on code in PR #13268: URL: https://github.com/apache/lucene/pull/13268#discussion_r1556370339 ## lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java: ## @@ -712,17 +712,21 @@ public String[] highlight(String field, Query query

Re: [PR] UnifiedHighlighter highlight on multiple fields [lucene]

2024-04-08 Thread via GitHub
mayya-sharipova commented on PR #13268: URL: https://github.com/apache/lucene/pull/13268#issuecomment-2043534438 @jimczi Thanks for your initial review. I've tried to address all your comments, so this is ready for another review. -- This is an automated message from the Apache Git Servic

Re: [PR] UnifiedHighlighter highlight on multiple fields [lucene]

2024-04-08 Thread via GitHub
mayya-sharipova commented on code in PR #13268: URL: https://github.com/apache/lucene/pull/13268#discussion_r1556357241 ## lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java: ## @@ -712,17 +712,21 @@ public String[] highlight(String field, Qu

Re: [PR] UnifiedHighlighter highlight on multiple fields [lucene]

2024-04-08 Thread via GitHub
mayya-sharipova commented on code in PR #13268: URL: https://github.com/apache/lucene/pull/13268#discussion_r1556357241 ## lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java: ## @@ -712,17 +712,21 @@ public String[] highlight(String field, Qu

Re: [PR] IndexWriter: Treat java.lang.Error as tragedy [lucene]

2024-04-08 Thread via GitHub
rmuir commented on PR #13277: URL: https://github.com/apache/lucene/pull/13277#issuecomment-2043294016 Yes, there is real work to do there. I dug into it, I think we will need multiple issues for that one... -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] IndexWriter: Treat java.lang.Error as tragedy [lucene]

2024-04-08 Thread via GitHub
uschindler commented on PR #13277: URL: https://github.com/apache/lucene/pull/13277#issuecomment-2042666045 All fine, maybe I was not clear! I just wanted to mention the "catch Throwable" issue and that we should additionally deal with it. -- This is an automated message from the Apache G

Re: [PR] Remove Accountable interface in KnnVectorsReader [lucene]

2024-04-08 Thread via GitHub
jpountz commented on PR #13255: URL: https://github.com/apache/lucene/pull/13255#issuecomment-2042550105 I opened #13280 as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] Remove Accountable interface on KnnVectorsReader [lucene]

2024-04-08 Thread via GitHub
jpountz closed issue #13241: Remove Accountable interface on KnnVectorsReader URL: https://github.com/apache/lucene/issues/13241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Remove Accountable interface in KnnVectorsReader [lucene]

2024-04-08 Thread via GitHub
jpountz merged PR #13255: URL: https://github.com/apache/lucene/pull/13255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [I] Remove Accountable interface on KnnVectorsReader [lucene]

2024-04-08 Thread via GitHub
benwtrent commented on issue #13241: URL: https://github.com/apache/lucene/issues/13241#issuecomment-2042541321 @jpountz I do not have a strong opinion :). Its cool to remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] UnifiedHighlighter highlight on multiple fields [lucene]

2024-04-08 Thread via GitHub
jimczi commented on code in PR #13268: URL: https://github.com/apache/lucene/pull/13268#discussion_r1555668470 ## lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java: ## @@ -712,17 +712,21 @@ public String[] highlight(String field, Query query

Re: [I] Introduce estimatedMergeBytes attribute in SegmentInfo [lucene]

2024-04-08 Thread via GitHub
sarthakaggarwal97 commented on issue #13278: URL: https://github.com/apache/lucene/issues/13278#issuecomment-2042113310 yeah, this is helpful. I was also thinking of setting dynamic compression modes during segment flushes, there FlushInfo could be handy. thank you! -- This is an automate

Re: [I] Remove Accountable interface on KnnVectorsReader [lucene]

2024-04-08 Thread via GitHub
jpountz commented on issue #13241: URL: https://github.com/apache/lucene/issues/13241#issuecomment-2042111883 @benwtrent Do you have a strong opinion on keeping the `Accountable` interface? I remember keeping it in 9.0 because vectors were new and wanting to be careful, but I'm keen on clea

Re: [I] Introduce estimatedMergeBytes attribute in SegmentInfo [lucene]

2024-04-08 Thread via GitHub
sarthakaggarwal97 closed issue #13278: Introduce estimatedMergeBytes attribute in SegmentInfo URL: https://github.com/apache/lucene/issues/13278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] Introduce estimatedMergeBytes attribute in SegmentInfo [lucene]

2024-04-08 Thread via GitHub
sarthakaggarwal97 commented on issue #13278: URL: https://github.com/apache/lucene/issues/13278#issuecomment-2042103999 I have not tried this. Thanks for point this out @jpountz Will close this issue! -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [I] Introduce estimatedMergeBytes attribute in SegmentInfo [lucene]

2024-04-08 Thread via GitHub
jpountz commented on issue #13278: URL: https://github.com/apache/lucene/issues/13278#issuecomment-2042106287 You can check out `NRTCachingDirectory` for an example of something that takes advantage of this. -- This is an automated message from the Apache Git Service. To respond to the me