dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1487332805
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCompat
gf2121 merged PR #13089:
URL: https://github.com/apache/lucene/pull/13089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
github-actions[bot] commented on PR #13041:
URL: https://github.com/apache/lucene/pull/13041#issuecomment-1939836557
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
github-actions[bot] commented on PR #13045:
URL: https://github.com/apache/lucene/pull/13045#issuecomment-1939836328
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486879238
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486879238
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486881008
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486879238
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler opened a new pull request, #13097:
URL: https://github.com/apache/lucene/pull/13097
This PR changes all references to the Lucene homepage from the DOAP file to
use the canonic HTTPS link.
P.S.: This cannot change the namespace links as they are identifiers in XML
world. Al
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486846219
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCompat
uschindler commented on PR #13096:
URL: https://github.com/apache/lucene/pull/13096#issuecomment-1939589434
P.S.: Unrelated to this issue here: we should update the doap file to use
https links.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
uschindler commented on PR #13096:
URL: https://github.com/apache/lucene/pull/13096#issuecomment-1939582769
> @uschindler I also have a bias against adding more dependencies on network
resources, this is why I was thinking of the DOAP files since we have them in
the repository:
https://git
jpountz commented on PR #13096:
URL: https://github.com/apache/lucene/pull/13096#issuecomment-1939540968
@uschindler I also have a bias against adding more dependencies on network
resources, this is why I was thinking of the DOAP files since we have them in
the repository:
https://github.c
uschindler commented on PR #13096:
URL: https://github.com/apache/lucene/pull/13096#issuecomment-1939421071
`@RmuirSays`: "yes please, lets not do the network. the smoketester can do
that. In fact mike already wrote the code."
--
This is an automated message from the Apache Git Service.
T
uschindler commented on PR #13096:
URL: https://github.com/apache/lucene/pull/13096#issuecomment-1939418280
See this issue for more insights to the "crazy logic":
https://issues.apache.org/jira/browse/LUCENE-5936
--
This is an automated message from the Apache Git Service.
To respond to t
uschindler commented on PR #13096:
URL: https://github.com/apache/lucene/pull/13096#issuecomment-1939413767
> We used to have logic to allow up to one missing file to account for
in-progress releases:
https://github.com/apache/lucene/blob/releases/lucene/9.8.0/lucene/backward-codecs/src/tes
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486656215
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486656215
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486656215
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486645486
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCompat
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486640670
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486637570
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486632751
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486628856
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486550352
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCompat
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486545976
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCompat
jpountz commented on PR #13096:
URL: https://github.com/apache/lucene/pull/13096#issuecomment-1939220460
We used to have logic to allow up to one missing file to account for
in-progress releases:
https://github.com/apache/lucene/blob/releases/lucene/9.8.0/lucene/backward-codecs/src/test/org
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486539904
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCo
jpountz commented on PR #13096:
URL: https://github.com/apache/lucene/pull/13096#issuecomment-1939207592
More fixes are needed, I'm looking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486535126
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCompat
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1486531645
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -47,25 +47,64 @@
public abstract class BackwardsCompat
jpountz opened a new pull request, #13096:
URL: https://github.com/apache/lucene/pull/13096
This would avoid test failures when a release is in progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jpountz commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1939072225
@uschindler I have been blindly following the release wizard, I'll look into
the failure in a bit and see how we can address it.
--
This is an automated message from the Apache Git Ser
uschindler commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1939064842
@jpountz fixed the duplicate `@Deprecated` but it still fails because it
can't find v9.11.0. I have no idea how it handles the last version of a
previous stable branch. For sure from
uschindler commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1938981480
> @uschindler i think it's because @jpountz added a new version on branch_9x
I spoke to him already I think it breaks tests as well on the stable branch
Yeah, I also see this on
s1monw commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1938967335
@uschindler i think it's because @jpountz added a new version on branch_9x I
spoke to him already I think it breaks tests as well on the stable branch
--
This is an automated messag
uschindler commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1938959760
Great! I haven't seen we use `//spotless:off` already and its enabled in the
config. So I think this is best option here. This also allows the regexes for
the script to not break sudd
s1monw commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1938895854
@uschindler this works. it's funky if one of the strings has a certain
length it will allow the bock-like strucuture.
--
This is an automated message from the Apache Git Service.
To res
AndreyBozhko commented on PR #13077:
URL: https://github.com/apache/lucene/pull/13077#issuecomment-1938870965
Checks are failing due to unrelated error from
314c553bdce22bc1bc08e46b218691575c2287e0:
```
Deprecated is not a repeatable annotation type
@Deprecated public static final
uschindler commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1938869700
I'd like for the reasons described before to enable this option:
https://stackoverflow.com/a/76221803
--
This is an automated message from the Apache Git Service.
To respond t
uschindler commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1938862855
What's the exact problem with tidy?
I think after adding the new version, we should run tidy to let it cleanup
the code.
I will check if there are some comment signals to ti
AndreyBozhko commented on PR #13077:
URL: https://github.com/apache/lucene/pull/13077#issuecomment-1938846917
@mkhludnev Makes sense - I added a simple test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
s1monw commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1938803239
this fixes the release script but I can't get tidy to not wrap the array
[here](https://github.com/apache/lucene/pull/13095/files#diff-8946e557343c70aadb734c2f1bdceeed366f32c6f667ea75b89b8
s1monw opened a new pull request, #13095:
URL: https://github.com/apache/lucene/pull/13095
In #13046 several changes broke the addBackcompatIndexes.py script to
properly add and test the unreleased version. This updates the script to again
properly add the new version.
Closes #13094
dweiss commented on issue #13073:
URL: https://github.com/apache/lucene/issues/13073#issuecomment-1938791677
I'm not sure what you're referring to. :) Please feel free to tweak - I just
wanted jenkins to quiet down because it started failing.
--
This is an automated message from the Apach
jzonthemtn commented on PR #12674:
URL: https://github.com/apache/lucene/pull/12674#issuecomment-1938717600
Thanks everyone involved in this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
s1monw commented on code in PR #13067:
URL: https://github.com/apache/lucene/pull/13067#discussion_r1486142786
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestIndexSortBackwardsCompatibility.java:
##
@@ -82,14 +84,20 @@ public void testSortedIndexAddDocBl
s1monw commented on PR #13089:
URL: https://github.com/apache/lucene/pull/13089#issuecomment-1938622498
LGTM too. lets merge it @gf2121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
s1monw commented on PR #13075:
URL: https://github.com/apache/lucene/pull/13075#issuecomment-1938619621
LGTM thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
s1monw commented on issue #13073:
URL: https://github.com/apache/lucene/issues/13073#issuecomment-1938617817
> @s1monw - some of those assertions added in
https://github.com/apache/lucene/pull/13046 only hold for the built-in
europarl. I fixed date parsing but I'm not sure how to deal with
epugh commented on PR #12674:
URL: https://github.com/apache/lucene/pull/12674#issuecomment-1938615618
Thank you all for sorting this... It will make some things downstream in
Solr much easier...
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
cpoerschke commented on PR #12674:
URL: https://github.com/apache/lucene/pull/12674#issuecomment-1938493400
Thanks @uschindler and @dweiss for reverting on `branch_9x` here!
minor: pushed
https://github.com/apache/lucene/commit/8bf10130e95c7b1b3da16606be0bf872c28fb6ed
to remove the e
uschindler commented on issue #13065:
URL: https://github.com/apache/lucene/issues/13065#issuecomment-1938448818
> > How can that be done?
>
> This is a question that is much harder to answer than I thought... Lucene
doesn't have a tutorial/user guide. The only place I could think of
53 matches
Mail list logo
