[GitHub] [lucene] kaivalnp commented on pull request #12590: Allow implementers of AbstractKnnVectorQuery to access final topK results

kaivalnp commented on PR #12590: URL: https://github.com/apache/lucene/pull/12590#issuecomment-1741698784 The previous build failed because a comment wasn't formatted correctly: ``` * What went wrong: Execution failed for task ':lucene:core:spotlessJavaCheck'. > The following

[GitHub] [lucene] gf2121 merged pull request #12591: Sort update terms with stable radix sorter

gf2121 merged PR #12591: URL: https://github.com/apache/lucene/pull/12591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] stefanvodita commented on issue #12585: Is it correct for facets to assume positive aggregation values?

stefanvodita commented on issue #12585: URL: https://github.com/apache/lucene/issues/12585#issuecomment-1741471016 > not try to modify the faceting module as-is, but rather spin up a new "aggregations" module I'm definitely leaning that way too right now. @Shradha26 and I were consid

[GitHub] [lucene] gsmiller commented on issue #12585: Is it correct for facets to assume positive aggregation values?

gsmiller commented on issue #12585: URL: https://github.com/apache/lucene/issues/12585#issuecomment-1741276611 Yeah, this is a good callout. I ran into this when adding more flexibility to association faceting a while back (making note that supporting, e.g., "min" would require rethinking t

[GitHub] [lucene] gf2121 opened a new pull request, #12610: Improve fallback sorter for BKD

gf2121 opened a new pull request, #12610: URL: https://github.com/apache/lucene/pull/12610 ### Description This PR proposes to use a more efficient way to compare bytes when RadixSorter fallback to MergeSorter. -- This is an automated message from the Apache Git Service. To res

[GitHub] [lucene] gf2121 commented on pull request #12604: Reduce FST block size for BlockTreeTermsWriter

gf2121 commented on PR #12604: URL: https://github.com/apache/lucene/pull/12604#issuecomment-1741082917 Here is the young GC statistics and allocation profile after indexing`wikimedium10m` (without facets and dvs) https://bytedance.feishu.cn/sheets/G5dwsdvZ7hOxXftyfDkcvUkYnqB"; data

[GitHub] [lucene] Shradha26 commented on issue #12553: [DISCUSS] Identifying Gaps in Lucene’s Faceting

Shradha26 commented on issue #12553: URL: https://github.com/apache/lucene/issues/12553#issuecomment-1741079621 Thanks, Mike! > What do you mean by an aggregation group? Is this like counting documents that are either red or blue? Yes, exactly. > Do we need to do the low-lev

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12606: Create a task executor when executor is not provided

shubhamvishu commented on code in PR #12606: URL: https://github.com/apache/lucene/pull/12606#discussion_r1341413183 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -420,13 +418,12 @@ public int count(Query query) throws IOException { } /** -

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12606: Create a task executor when executor is not provided

shubhamvishu commented on code in PR #12606: URL: https://github.com/apache/lucene/pull/12606#discussion_r1341413183 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -420,13 +418,12 @@ public int count(Query query) throws IOException { } /** -

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12606: Create a task executor when executor is not provided

shubhamvishu commented on code in PR #12606: URL: https://github.com/apache/lucene/pull/12606#discussion_r1341393303 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -420,13 +418,12 @@ public int count(Query query) throws IOException { } /** -

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12606: Create a task executor when executor is not provided

shubhamvishu commented on code in PR #12606: URL: https://github.com/apache/lucene/pull/12606#discussion_r1341393303 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -420,13 +418,12 @@ public int count(Query query) throws IOException { } /** -

[GitHub] [lucene] kaivalnp commented on a diff in pull request #12590: Allow implementers of AbstractKnnVectorQuery to access final topK results

kaivalnp commented on code in PR #12590: URL: https://github.com/apache/lucene/pull/12590#discussion_r1341368597 ## lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java: ## @@ -216,6 +216,10 @@ protected TopDocs exactSearch(LeafReaderContext context, DocIdS

[GitHub] [lucene] jpountz commented on a diff in pull request #12591: Sort update terms with stable radix sorter

jpountz commented on code in PR #12591: URL: https://github.com/apache/lucene/pull/12591#discussion_r1341368129 ## lucene/core/src/java/org/apache/lucene/util/StableStringSorter.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [lucene] javanna commented on pull request #12606: Create a task executor when executor is not provided

javanna commented on PR #12606: URL: https://github.com/apache/lucene/pull/12606#issuecomment-1740890009 Thanks for looking @shubhamvishu ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [lucene] gf2121 commented on a diff in pull request #12591: Sort update terms with stable radix sorter

gf2121 commented on code in PR #12591: URL: https://github.com/apache/lucene/pull/12591#discussion_r1341354760 ## lucene/core/src/java/org/apache/lucene/util/StableStringSorter.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [lucene] javanna commented on a diff in pull request #12606: Create a task executor when executor is not provided

javanna commented on code in PR #12606: URL: https://github.com/apache/lucene/pull/12606#discussion_r1341305002 ## lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java: ## Review Comment: Yep. -- This is an automated message from the Apache Git Service.

[GitHub] [lucene] javanna commented on a diff in pull request #12606: Create a task executor when executor is not provided

javanna commented on code in PR #12606: URL: https://github.com/apache/lucene/pull/12606#discussion_r1341307528 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -420,13 +418,12 @@ public int count(Query query) throws IOException { } /** - * Re

[GitHub] [lucene] javanna commented on a diff in pull request #12606: Create a task executor when executor is not provided

javanna commented on code in PR #12606: URL: https://github.com/apache/lucene/pull/12606#discussion_r1341307014 ## lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java: ## @@ -79,10 +79,11 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOExcept

[GitHub] [lucene] mikemccand commented on a diff in pull request #12590: Allow implementers of AbstractKnnVectorQuery to access final topK results

mikemccand commented on code in PR #12590: URL: https://github.com/apache/lucene/pull/12590#discussion_r1341253190 ## lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java: ## @@ -216,6 +216,10 @@ protected TopDocs exactSearch(LeafReaderContext context, DocI

[GitHub] [lucene] cpoerschke merged pull request #12609: SuggestIndexSearcher.suggest catches any CollectionTerminatedException (theoretically) thrown by getLeafCollector

cpoerschke merged PR #12609: URL: https://github.com/apache/lucene/pull/12609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] cpoerschke merged pull request #12605: IndexingChain.validateMaxVectorDimension: add missing space in IllegalArgumentException wording

cpoerschke merged PR #12605: URL: https://github.com/apache/lucene/pull/12605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] jpountz commented on a diff in pull request #12591: Sort update terms with stable radix sorter

jpountz commented on code in PR #12591: URL: https://github.com/apache/lucene/pull/12591#discussion_r1341195931 ## lucene/core/src/java/org/apache/lucene/util/StableStringSorter.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12606: Create a task executor when executor is not provided

shubhamvishu commented on code in PR #12606: URL: https://github.com/apache/lucene/pull/12606#discussion_r1341158559 ## lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java: ## Review Comment: We should change the `assertNull ` to `assertNotNull` in `testGet

[GitHub] [lucene] shubhamvishu commented on pull request #12606: Create a task executor when executor is not provided

shubhamvishu commented on PR #12606: URL: https://github.com/apache/lucene/pull/12606#issuecomment-1740631119 I really like this! This looks much more cleaner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [lucene] cpoerschke commented on a diff in pull request #12436: Move max vector dims limit to Codec

cpoerschke commented on code in PR #12436: URL: https://github.com/apache/lucene/pull/12436#discussion_r1341157051 ## lucene/core/src/java/org/apache/lucene/index/IndexingChain.java: ## @@ -831,6 +837,20 @@ private static void verifyUnIndexedFieldType(String name, IndexableFiel

[GitHub] [lucene] cpoerschke commented on a diff in pull request #12380: Add a post-collection hook to LeafCollector.

cpoerschke commented on code in PR #12380: URL: https://github.com/apache/lucene/pull/12380#discussion_r1341153435 ## lucene/suggest/src/java/org/apache/lucene/search/suggest/document/SuggestIndexSearcher.java: ## @@ -67,14 +68,16 @@ public void suggest(CompletionQuery query, T

[GitHub] [lucene] cpoerschke opened a new pull request, #12609: SuggestIndexSearcher.suggest catches any CollectionTerminatedException (theoretically) thrown by getLeafCollector

cpoerschke opened a new pull request, #12609: URL: https://github.com/apache/lucene/pull/12609 please see https://github.com/apache/lucene/pull/12380#discussion_r1340380526 and https://github.com/apache/lucene/pull/12380#discussion_r1340582160 for context -- This is an automated message

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #12606: Create a task executor when executor is not provided

shubhamvishu commented on code in PR #12606: URL: https://github.com/apache/lucene/pull/12606#discussion_r1341149197 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -420,13 +418,12 @@ public int count(Query query) throws IOException { } /** -

[GitHub] [lucene] jpountz commented on pull request #12382: Run top-level conjunctions of term queries with a specialized BulkScorer.

jpountz commented on PR #12382: URL: https://github.com/apache/lucene/pull/12382#issuecomment-1740478404 This gave a good speedup to [AndHighHigh](http://people.apache.org/~mikemccand/lucenebench/AndHighHigh.html) on nightlies: +15%, but [AndHighMed](http://people.apache.org/~mikemccand/lu