gf2121 commented on code in PR #12591: URL: https://github.com/apache/lucene/pull/12591#discussion_r1341354760
########## lucene/core/src/java/org/apache/lucene/util/StableStringSorter.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.util; + +import java.util.Comparator; + +abstract class StableStringSorter extends StringSorter { + + StableStringSorter(Comparator<BytesRef> cmp) { + super(cmp); + } + + /** Save the i-th value into the j-th position in temporary storage. */ + protected abstract void save(int i, int j); + + /** Restore values between i-th and j-th(excluding) in temporary storage into original storage. */ + protected abstract void restore(int i, int j); + + @Override + protected Sorter radixSorter(BytesRefComparator cmp) { + return new StableMSBRadixSorter(cmp.comparedBytesCount) { + + @Override + protected void save(int i, int j) { + StableStringSorter.this.save(i, j); + } + + @Override + protected void restore(int i, int j) { + StableStringSorter.this.restore(i, j); + } + + @Override + protected void swap(int i, int j) { + StableStringSorter.this.swap(i, j); + } + + @Override + protected int byteAt(int i, int k) { + get(scratch1, scratchBytes1, i); + return cmp.byteAt(scratchBytes1, k); + } + + @Override + protected Sorter getFallbackSorter(int k) { + return fallbackSorter((o1, o2) -> cmp.compare(o1, o2, k)); Review Comment: Thanks for the feedback! In this way, we are callling [`BytesRefComparator#compare(BytesRef o1, BytesRef o2, int k)`](https://github.com/apache/lucene/blob/1c7e22f2acbe4b32d13e2e51794c613b788455ba/lucene/core/src/java/org/apache/lucene/util/BytesRefComparator.java#L77) instead of [`BytesRefComparator#compare(BytesRef o1, BytesRef o2)`](https://github.com/apache/lucene/blob/1c7e22f2acbe4b32d13e2e51794c613b788455ba/lucene/core/src/java/org/apache/lucene/util/BytesRefComparator.java#L72) , which tries to avoid comparing first k bytes as they are already guaranteed equals by RadixSorter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
