Tony-X commented on PR #12552:
URL: https://github.com/apache/lucene/pull/12552#issuecomment-1726671056
Thanks @msokolov !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
jmazanec15 commented on issue #12570:
URL: https://github.com/apache/lucene/issues/12570#issuecomment-1726544154
For dynamically changing M, I would be a little hesitant IMO. It could lead
to inconsistent behavior, where some segments are searched very fast and others
slow. If we were to su
msokolov merged PR #12552:
URL: https://github.com/apache/lucene/pull/12552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
benwtrent merged PR #12571:
URL: https://github.com/apache/lucene/pull/12571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
msokolov commented on PR #12552:
URL: https://github.com/apache/lucene/pull/12552#issuecomment-1726315384
Thanks for the CHANGES entry - I'll push shortly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
shubhamvishu commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1330561055
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
@@ -22,18 +22,29 @@
import java.util.Collection;
import java.util.List;
import java.util
shubhamvishu commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1330549252
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
@@ -22,18 +22,28 @@
import java.util.Collection;
import java.util.List;
import java.util
eraneverlaw commented on issue #12561:
URL: https://github.com/apache/lucene/issues/12561#issuecomment-1726278027
> awesome find, wow, embedded sneaky range in the grammar :)
>
> Locally I modified the grammar per your suggestion and ran `gradle
regenerate`, tests seemed happy. i want
jmazanec15 commented on PR #12002:
URL: https://github.com/apache/lucene/pull/12002#issuecomment-1726189550
Closing as this was moved to lucenutil. Will raise a PR over there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jmazanec15 closed pull request #12002: Set algorithm params during force merge
in KnnGraphTester
URL: https://github.com/apache/lucene/pull/12002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jmazanec15 commented on issue #12570:
URL: https://github.com/apache/lucene/issues/12570#issuecomment-1726067867
Oh right I actually raised a PR sometime back around this but forgot about
it: https://github.com/apache/lucene/pull/12002.
> The question then becomes, is this a valid us
uschindler commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1330398850
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
@@ -22,18 +22,28 @@
import java.util.Collection;
import java.util.List;
import java.util.O
jpountz commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1330366074
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
@@ -22,18 +22,28 @@
import java.util.Collection;
import java.util.List;
import java.util.Obje
jpountz commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1330338668
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
@@ -64,4 +82,26 @@ final List invokeAll(Collection>
tasks) throws IOExcept
}
return
uschindler commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1330347382
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
@@ -22,18 +22,28 @@
import java.util.Collection;
import java.util.List;
import java.util.O
uschindler commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1330330240
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
@@ -22,18 +22,28 @@
import java.util.Collection;
import java.util.List;
import java.util.O
javanna commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1330265734
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
@@ -22,18 +22,28 @@
import java.util.Collection;
import java.util.List;
import java.util.Obje
javanna commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1330223982
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
@@ -22,18 +22,28 @@
import java.util.Collection;
import java.util.List;
import java.util.Obje
javanna commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1330223982
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
@@ -22,18 +22,28 @@
import java.util.Collection;
import java.util.List;
import java.util.Obje
javanna commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1330215231
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
Review Comment:
> why not move to work-stealing fork/join here?
There were concerns
javanna commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1330212822
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
Review Comment:
which public methods require changing? As far as I understand visibility of
javanna commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1330210656
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
@@ -22,18 +22,28 @@
import java.util.Collection;
import java.util.List;
import java.util.Obje
rmuir commented on issue #12561:
URL: https://github.com/apache/lucene/issues/12561#issuecomment-1725653759
awesome find, wow, embedded sneaky range in the grammar :)
Locally I modified the grammar per your suggestion and ran `gradle
regenerate`, tests seemed happy. i want to add a si
msokolov commented on issue #12553:
URL: https://github.com/apache/lucene/issues/12553#issuecomment-1725489583
So many ideas here! It's clear we have some room to grow this API. I wonder
if we could organize them into a plan with dependencies and priorities. Also
some of the ideas I'm not
msokolov commented on code in PR #12547:
URL: https://github.com/apache/lucene/pull/12547#discussion_r1330093278
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FloatTaxonomyFacets.java:
##
@@ -37,33 +37,43 @@ abstract class FloatTaxonomyFacets extends TaxonomyFacets {
uschindler commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1330062036
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
@@ -22,18 +22,28 @@
import java.util.Collection;
import java.util.List;
import java.util.O
uschindler commented on PR #12568:
URL: https://github.com/apache/lucene/pull/12568#issuecomment-1725333605
MMap Jenkins tests were happy, all tests passed:
- https://jenkins.thetaphi.de/job/Lucene-MMAPv2-Linux/
- https://jenkins.thetaphi.de/job/Lucene-MMAPv2-Windows/
--
This is an a
jpountz commented on PR #12568:
URL: https://github.com/apache/lucene/pull/12568#issuecomment-1725228619
Oops, I think I confused the "Reviewers" and "Assignees" section, I didn't
mean to put it on your plate!
--
This is an automated message from the Apache Git Service.
To respond to the
uschindler commented on PR #12568:
URL: https://github.com/apache/lucene/pull/12568#issuecomment-1724994726
Thanks @jpountz for merging. I did not notice that you assigned the issue to
me so I should merge it. I was about to checkout the repo and test it
intensively. But as you have ran the
javanna commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1329674640
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
@@ -48,10 +58,17 @@ class TaskExecutor {
* @return a list containing the results from the ta
javanna commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1329673052
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
@@ -22,18 +22,28 @@
import java.util.Collection;
import java.util.List;
import java.util.Obje
javanna commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1329672558
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
@@ -22,18 +22,28 @@
import java.util.Collection;
import java.util.List;
import java.util.Obje
javanna commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1329665865
##
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##
Review Comment:
I am not entirely sure: one aspect is that I'd like to make sure that there
33 matches
Mail list logo
