javanna commented on code in PR #12569:
URL: https://github.com/apache/lucene/pull/12569#discussion_r1329674640
##########
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java:
##########
@@ -48,10 +58,17 @@ class TaskExecutor {
* @return a list containing the results from the tasks execution
* @param <T> the return type of the task execution
*/
- final <T> List<T> invokeAll(Collection<RunnableFuture<T>> tasks) throws
IOException {
- for (Runnable task : tasks) {
- executor.execute(task);
+ final <T> List<T> invokeAll(Collection<Task<T>> tasks) throws IOException {
Review Comment:
Good point: I'd consider deprecating getExecutor in favour of always going
through the TaskExecutor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
