mikemccand commented on PR #12545:
URL: https://github.com/apache/lucene/pull/12545#issuecomment-1712668955
I backported to 9.x as well:
https://github.com/apache/lucene/commit/d70c91134726ff5768c0bcdc7bce51f3fbfcac56
--
This is an automated message from the Apache Git Service.
To respond
mikemccand merged PR #12545:
URL: https://github.com/apache/lucene/pull/12545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
stefanvodita opened a new pull request, #12547:
URL: https://github.com/apache/lucene/pull/12547
Usually facets maintain a one-dimensional array indexed by ordinal which
keeps the values they're supposed to compute.
The change here is simple in principle - use a two-dimensional array,
in
stefanvodita opened a new issue, #12546:
URL: https://github.com/apache/lucene/issues/12546
### Description
When a user knows that they want multiple different aggregations, they have
to iterate the match-set once for each aggregation, which [is
inefficient](https://lists.apache.org/
mikemccand commented on PR #12545:
URL: https://github.com/apache/lucene/pull/12545#issuecomment-1712497190
OK `Test2BFST` is happy:
```
BUILD SUCCESSFUL in 54m 15s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mikemccand commented on PR #12545:
URL: https://github.com/apache/lucene/pull/12545#issuecomment-1712476087
For the record, this command seems to at least kick off `Test2BFST`:
`./gradlew test --max-workers=1 --tests org.apache.lucene.util.fst.Test2BFST
-Dtests.nightly=true -Dtests.mo
mikemccand commented on PR #12545:
URL: https://github.com/apache/lucene/pull/12545#issuecomment-1712474813
Tests and precommit passed locally (once) for me ... I'll make sure
`Test2BFST` passes once too.
--
This is an automated message from the Apache Git Service.
To respond to the messa
mikemccand opened a new pull request, #12545:
URL: https://github.com/apache/lucene/pull/12545
The bitsRequired passed during NodeHash rehash (when building an FST) was
too small, causing excess/wasted reallocations. This is just a performance
bug, especially impacting larger FSTs, but lik
mikemccand commented on issue #12542:
URL: https://github.com/apache/lucene/issues/12542#issuecomment-1712472912
> We seem to create a PagedGrowableWriter with [page size 128 MB
here](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/util/fst/NodeHash.java#L34
