stefanvodita opened a new pull request, #12547:
URL: https://github.com/apache/lucene/pull/12547

   Usually facets maintain a one-dimensional array indexed by ordinal which 
keeps the values they're supposed to compute.
   The change here is simple in principle - use a two-dimensional array, 
indexed by aggregation and ordinal, so we can do multiple aggregations at once.
   
   For the methods that get top children / all children / spcific values / 
dims, the default is to get the values corresponding to the first aggregation, 
but the aggregation can be specified.
   
   There is one tricky bit when we aggregate using provided values sources. In 
this case, we advance the values sources and get the values for each 
aggregation before iterating through the ordinals in each doc. When we iterate 
through the ordinals, we load each of the values we've already retrieved and 
update the corresponding accumulator.
   
   Addresses #12546 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to