rmuir opened a new pull request, #12010:
URL: https://github.com/apache/lucene/pull/12010
See https://errorprone.info/bugpattern/LongDoubleConversion
After seeing #12008 (Calling isNaN on long arguments), looked into this
check and it finds a few other things.
In general, we do
LuXugang commented on PR #12003:
URL: https://github.com/apache/lucene/pull/12003#issuecomment-1345785775
Thanks @gsmiller , a new syntactic sugar `record` to me and first time
appeard in lucene code.
--
This is an automated message from the Apache Git Service.
To respond to the message,
jpountz commented on PR #11997:
URL: https://github.com/apache/lucene/pull/11997#issuecomment-1345673357
I just found an issue with this PR which is that multi-valued floats and
doubles are encoded with `Double#doubleToLongBits` while they should use
`NumericUtil#doubleToSortableLong` to pr
rmuir commented on PR #11997:
URL: https://github.com/apache/lucene/pull/11997#issuecomment-1345666166
OK, well maybe defer it if we have options. I haven't thought about the
`SortField` approach, maybe it could be more natural that way.
--
This is an automated message from the Apache Git
rmuir commented on PR #11998:
URL: https://github.com/apache/lucene/pull/11998#issuecomment-1345665387
+1 to improve docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jpountz commented on PR #11997:
URL: https://github.com/apache/lucene/pull/11997#issuecomment-1345663912
Good point. I was thinking of making changes to `SortField` but adding
factory methods to these Field classes feels like a better approach to me.
--
This is an automated message from t
gsmiller merged PR #12008:
URL: https://github.com/apache/lucene/pull/12008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
rmuir commented on PR #11997:
URL: https://github.com/apache/lucene/pull/11997#issuecomment-1345588464
There is already `SortedSetSortField` and `SortedNumericSortField` that do
this. So I don't understand why it would be a big change? Maybe just add some
sugar (e.g. `newSortField` or simil
gsmiller commented on PR #12008:
URL: https://github.com/apache/lucene/pull/12008#issuecomment-1345585253
@rmuir done: GH#12009. Thanks for the suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gsmiller opened a new issue, #12009:
URL: https://github.com/apache/lucene/issues/12009
### Description
I fixed one instance of this I happened to run across (see GH#12008), which
appears to have just been a copy/paste issue, but as @rmuir points out (in the
same PR), we can use `err
gsmiller commented on PR #11997:
URL: https://github.com/apache/lucene/pull/11997#issuecomment-1345583546
> maybe we can tackle this in a follow up PR?
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
stefanvodita commented on PR #11780:
URL: https://github.com/apache/lucene/pull/11780#issuecomment-1345547314
@mikemccand’s feedback made me shift focus from rebuilding ordinal maps on
refresh to just making it convenient for the user to do so.
`SsdvReaderStatesManager` shows how that might
jpountz commented on PR #11997:
URL: https://github.com/apache/lucene/pull/11997#issuecomment-1345543447
Absolutely, adding support for multivalued fields to default sort fields
would be a big change too.
--
This is an automated message from the Apache Git Service.
To respond to the messa
fcofdez commented on PR #11997:
URL: https://github.com/apache/lucene/pull/11997#issuecomment-1345542724
Thanks all for the reviews!
> This sounds good to me. The main issue I see with this is that our default
SortFields fail if the field is indexed with multi-valued doc values. But
14 matches
Mail list logo
