jpountz commented on PR #11997: URL: https://github.com/apache/lucene/pull/11997#issuecomment-1345673357
I just found an issue with this PR which is that multi-valued floats and doubles are encoded with `Double#doubleToLongBits` while they should use `NumericUtil#doubleToSortableLong` to present ordering within a document. One way to fix it would be to change the encoding depending on whether the field is multi-valued, but this isn't great as we then also need to pass this flag to factor methods for queries (or sort fields in the future). So maybe we should go with @rmuir's earlier suggestion of only supporting multi-valued fields, so that there is a single encoding in doc values? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
