[
https://issues.apache.org/jira/browse/LUCENE-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551976#comment-17551976
]
Kaival Parikh edited comment on LUCENE-10606 at 6/9/22 6:29 AM:
-
kaivalnp commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r893116012
##
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##
@@ -225,6 +225,11 @@ public BitSetIterator getIterator(int contextOrd) {
return new BitSetI
[
https://issues.apache.org/jira/browse/LUCENE-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551976#comment-17551976
]
Kaival Parikh edited comment on LUCENE-10606 at 6/9/22 6:21 AM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kaival Parikh updated LUCENE-10606:
---
Description:
While working on this [PR|https://github.com/apache/lucene/pull/932] to add
p
[
https://issues.apache.org/jira/browse/LUCENE-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551976#comment-17551976
]
Kaival Parikh commented on LUCENE-10606:
Instead of collecting hit-by-hit using
Kaival Parikh created LUCENE-10606:
--
Summary: Optimize hit collection of prefilter in KnnVectorQuery
for BitSet backed queries
Key: LUCENE-10606
URL: https://issues.apache.org/jira/browse/LUCENE-10606
[
https://issues.apache.org/jira/browse/LUCENE-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sun wuqiang updated LUCENE-10605:
-
Affects Version/s: 8.11.1
(was: 9.2)
> fix error in 32bit jvm object
[
https://issues.apache.org/jira/browse/LUCENE-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sun wuqiang updated LUCENE-10605:
-
Description:
ArrayUtil.{*}oversize{*}(int minTargetSize, int bytesPerElement)
This method is us
[
https://issues.apache.org/jira/browse/LUCENE-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sun wuqiang updated LUCENE-10605:
-
Attachment: image-2022-06-09-08-26-36-528.png
> fix error in 32bit jvm object alignment gap cal
[
https://issues.apache.org/jira/browse/LUCENE-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sun wuqiang updated LUCENE-10605:
-
Description:
ArrayUtil.{*}oversize{*}(int minTargetSize, int bytesPerElement)
This method is us
[
https://issues.apache.org/jira/browse/LUCENE-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sun wuqiang updated LUCENE-10605:
-
Attachment: image-2022-06-09-08-25-55-289.png
> fix error in 32bit jvm object alignment gap cal
[
https://issues.apache.org/jira/browse/LUCENE-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sun wuqiang updated LUCENE-10605:
-
Issue Type: Bug (was: Improvement)
> fix error in 32bit jvm object alignment gap calculation
>
mdmarshmallow commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1150471678
So based on everyone's comments:
1. It seems like we should ditch the `hyperrectangle` implementation and
that `facetset` does everything we need for right now
2. When we deci
gsmiller commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1150439971
Let me try to summarize my understanding of the "future optimization" debate
as it pertains to this proposed API/implementation and see if we're on the same
page or if I'm overlooking somet
vigyasharma commented on PR #948:
URL: https://github.com/apache/lucene/pull/948#issuecomment-1150432604
The "force push" was a rebase on main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vigyasharma commented on PR #948:
URL: https://github.com/apache/lucene/pull/948#issuecomment-1150395272
> It looks to me as if the writer may intended `ImpactsEnum` there? Maybe
check git blame to see when that edit was made...
Good idea. I checked git history and found [this
commit
[
https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551750#comment-17551750
]
David Smiley commented on LUCENE-4574:
--
Maybe, but more recently, see LUCENE-10252
msokolov commented on PR #945:
URL: https://github.com/apache/lucene/pull/945#issuecomment-1150273382
Thanks, @dweiss -- still seems to work for me after your latest fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551745#comment-17551745
]
Kevin Risden commented on LUCENE-4574:
--
Ugh actually just after I sent that I found
msokolov commented on PR #948:
URL: https://github.com/apache/lucene/pull/948#issuecomment-1150259511
It looks to me as if the writer may intended `ImpactsEnum` there? Maybe
check git blame to see when that edit was made...
--
This is an automated message from the Apache Git Service.
To r
pminkov commented on PR #940:
URL: https://github.com/apache/lucene/pull/940#issuecomment-1150241668
I'm uploading the selected words file:
[mlt-selected-words.txt](https://github.com/apache/lucene/files/8863975/mlt-selected-words.txt)
And the input file:
[plots.txt](https://git
[
https://issues.apache.org/jira/browse/LUCENE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551732#comment-17551732
]
Kevin Risden commented on LUCENE-4574:
--
[~dsmiley] / [~jpountz] - is it possible th
zhaih commented on code in PR #935:
URL: https://github.com/apache/lucene/pull/935#discussion_r892682597
##
lucene/core/src/java/org/apache/lucene/index/LogMergePolicy.java:
##
@@ -568,23 +568,41 @@ public MergeSpecification findMerges(
// Finally, record all merges that
[
https://issues.apache.org/jira/browse/LUCENE-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551720#comment-17551720
]
Uwe Schindler commented on LUCENE-10602:
Theoretically you could also serialize
[
https://issues.apache.org/jira/browse/LUCENE-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551719#comment-17551719
]
Uwe Schindler commented on LUCENE-10602:
Elasticsearch could for example subcla
[
https://issues.apache.org/jira/browse/LUCENE-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551717#comment-17551717
]
Uwe Schindler commented on LUCENE-10602:
If all this is needed, why not impleme
[
https://issues.apache.org/jira/browse/LUCENE-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551712#comment-17551712
]
Adrien Grand commented on LUCENE-10602:
---
I work with Chris and I suggested him to
craigtaverner commented on code in PR #946:
URL: https://github.com/apache/lucene/pull/946#discussion_r892627220
##
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##
@@ -1444,6 +1471,71 @@ public static final boolean pointInPolygon(
return false;
}
+ /**
craigtaverner commented on code in PR #946:
URL: https://github.com/apache/lucene/pull/946#discussion_r892626127
##
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##
@@ -817,8 +841,12 @@ private static final boolean splitEarcut(
sortByMortonWithReset(s
craigtaverner commented on code in PR #946:
URL: https://github.com/apache/lucene/pull/946#discussion_r892608782
##
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##
@@ -1444,6 +1471,71 @@ public static final boolean pointInPolygon(
return false;
}
+ /**
jtibshirani commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r892605221
##
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##
@@ -225,6 +225,11 @@ public BitSetIterator getIterator(int contextOrd) {
return new BitS
msokolov commented on PR #947:
URL: https://github.com/apache/lucene/pull/947#issuecomment-1150043099
If folks have time to review, that would be great. The main thing to focus
on I think is
1. how the HnswGraphSearcher/Writer implementation is forked into `float[]`
and `BytesRef` u
iverase commented on code in PR #946:
URL: https://github.com/apache/lucene/pull/946#discussion_r892487112
##
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##
@@ -1444,6 +1471,71 @@ public static final boolean pointInPolygon(
return false;
}
+ /**
+ *
iverase commented on code in PR #946:
URL: https://github.com/apache/lucene/pull/946#discussion_r892482033
##
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##
@@ -817,8 +841,12 @@ private static final boolean splitEarcut(
sortByMortonWithReset(searchN
iverase commented on code in PR #946:
URL: https://github.com/apache/lucene/pull/946#discussion_r892481023
##
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##
@@ -1444,6 +1471,71 @@ public static final boolean pointInPolygon(
return false;
}
+ /**
+ *
iverase commented on code in PR #946:
URL: https://github.com/apache/lucene/pull/946#discussion_r892480730
##
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##
@@ -1444,6 +1471,71 @@ public static final boolean pointInPolygon(
return false;
}
+ /**
+ *
craigtaverner commented on code in PR #946:
URL: https://github.com/apache/lucene/pull/946#discussion_r892431465
##
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##
@@ -817,8 +841,12 @@ private static final boolean splitEarcut(
sortByMortonWithReset(s
craigtaverner commented on code in PR #946:
URL: https://github.com/apache/lucene/pull/946#discussion_r892430679
##
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##
@@ -817,8 +841,12 @@ private static final boolean splitEarcut(
sortByMortonWithReset(s
craigtaverner commented on code in PR #946:
URL: https://github.com/apache/lucene/pull/946#discussion_r892429207
##
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##
@@ -1444,6 +1472,60 @@ public static final boolean pointInPolygon(
return false;
}
+ /**
craigtaverner commented on code in PR #946:
URL: https://github.com/apache/lucene/pull/946#discussion_r892428974
##
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##
@@ -131,16 +136,24 @@ public static List tessellate(final Polygon
polygon, boolean checkSelf
wormday opened a new pull request, #949:
URL: https://github.com/apache/lucene/pull/949
### Description
https://issues.apache.org/jira/browse/LUCENE-10605
ArrayUtil.oversize()
The generated array length cannot eliminate the Object alignment gap,
wasting some space
--
This is an a
craigtaverner commented on code in PR #946:
URL: https://github.com/apache/lucene/pull/946#discussion_r892406529
##
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##
@@ -817,8 +841,12 @@ private static final boolean splitEarcut(
sortByMortonWithReset(s
sun wuqiang created LUCENE-10605:
Summary: fix error in 32bit jvm object alignment gap calculation
Key: LUCENE-10605
URL: https://issues.apache.org/jira/browse/LUCENE-10605
Project: Lucene - Core
iverase commented on code in PR #946:
URL: https://github.com/apache/lucene/pull/946#discussion_r892379156
##
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##
@@ -131,16 +136,24 @@ public static List tessellate(final Polygon
polygon, boolean checkSelf
}
iverase commented on code in PR #946:
URL: https://github.com/apache/lucene/pull/946#discussion_r892375896
##
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##
@@ -817,8 +841,12 @@ private static final boolean splitEarcut(
sortByMortonWithReset(searchN
mikemccand commented on PR #633:
URL: https://github.com/apache/lucene/pull/633#issuecomment-1149911664
My beasting has not uncovered any more failures! I think this is ready!
I'll try to merge soon, just to `main` ... let's let it bake there for a while
before backporting to 9.x? Thanks
kaivalnp commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r892189591
##
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##
@@ -225,6 +225,11 @@ public BitSetIterator getIterator(int contextOrd) {
return new BitSetI
jpountz commented on code in PR #935:
URL: https://github.com/apache/lucene/pull/935#discussion_r892164198
##
lucene/core/src/java/org/apache/lucene/index/LogMergePolicy.java:
##
@@ -568,23 +568,41 @@ public MergeSpecification findMerges(
// Finally, record all merges tha
jpountz commented on code in PR #935:
URL: https://github.com/apache/lucene/pull/935#discussion_r892145811
##
lucene/core/src/java/org/apache/lucene/index/LogMergePolicy.java:
##
@@ -568,23 +568,41 @@ public MergeSpecification findMerges(
// Finally, record all merges tha
[
https://issues.apache.org/jira/browse/LUCENE-10563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-10563.
---
Fix Version/s: 9.3
Assignee: Ignacio Vera
Resolution: Fixed
Note that polyg
[
https://issues.apache.org/jira/browse/LUCENE-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551498#comment-17551498
]
Craig Taverner commented on LUCENE-10604:
-
I have created a PR for this at http
[
https://issues.apache.org/jira/browse/LUCENE-10563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551493#comment-17551493
]
ASF subversion and git services commented on LUCENE-10563:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551492#comment-17551492
]
ASF subversion and git services commented on LUCENE-10563:
--
Co
iverase merged PR #933:
URL: https://github.com/apache/lucene/pull/933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
[
https://issues.apache.org/jira/browse/LUCENE-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551470#comment-17551470
]
Ignacio Vera commented on LUCENE-10604:
---
+1
This algorithm is very difficult to
Craig Taverner created LUCENE-10604:
---
Summary: Improve ability to test and debug triangulation algorithm
in Tessellator
Key: LUCENE-10604
URL: https://issues.apache.org/jira/browse/LUCENE-10604
Proj
[
https://issues.apache.org/jira/browse/LUCENE-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551429#comment-17551429
]
Adrien Grand commented on LUCENE-10396:
---
Another potential use-case we are intere
shaie commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1149554008
> `facetset` for the exact implementation and `hyperrectangle` for the range
implementation
If I understand correctly, @gsmiller's proposal was more about efficiency,
right? So if you h
58 matches
Mail list logo
