craigtaverner commented on code in PR #946:
URL: https://github.com/apache/lucene/pull/946#discussion_r892430679
##########
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##########
@@ -817,8 +841,12 @@ private static final boolean splitEarcut(
sortByMortonWithReset(searchNode);
sortByMortonWithReset(splitNode);
}
- earcutLinkedList(polygon, searchNode, tessellation, State.INIT,
mortonOptimized);
- earcutLinkedList(polygon, splitNode, tessellation, State.INIT,
mortonOptimized);
+ notifyMonitorSplit("SPLIT[" + depth + "]", monitor, searchNode,
splitNode);
Review Comment:
I realize that even though we create these strings infrequently, we should
not create them at all if `monitor==null`, so I moved the creation one level
down in the stack to get that behaviour. Hopefully this is sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
