[GitHub] [lucene] raminmjj commented on pull request #540: LUCENE-10312: Add PersianStemmer

raminmjj commented on PR #540: URL: https://github.com/apache/lucene/pull/540#issuecomment-1120148724 Sorry for the delay in responding. @mocobeta, I applied some changes based on your comments. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r867300189 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r867300189 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] mocobeta commented on pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

mocobeta commented on PR #868: URL: https://github.com/apache/lucene/pull/868#issuecomment-1120123174 here's Jenkins flavoured Policeman. sorry i might be a bit tired. 

[GitHub] [lucene] LuXugang commented on a diff in pull request #870: LUCENE-10502: Refactor hnswVectors format

LuXugang commented on code in PR #870: URL: https://github.com/apache/lucene/pull/870#discussion_r867296165 ## lucene/core/src/java/org/apache/lucene/codecs/lucene92/Lucene92HnswVectorsFormat.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [lucene] vigyasharma commented on pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

vigyasharma commented on PR #633: URL: https://github.com/apache/lucene/pull/633#issuecomment-1120074212 Rebased on main. Moved `changes` entry to `10.0.0` since we're close to cutting `9.2.0`, and it would be good to bake this in CI builds for a while. -- This is an automated message fro

[GitHub] [lucene] jtibshirani commented on pull request #872: LUCENE-10527 Use 2*maxConn for last layer in HNSW

jtibshirani commented on PR #872: URL: https://github.com/apache/lucene/pull/872#issuecomment-1120061467 @mayya-sharipova what is the ann-benchmarks set-up that you're using? I found that in order to get comparable results to hnswlib, I had to make sure to adjust `efSearch` to these paramet

[GitHub] [lucene] rmuir commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

rmuir commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r867220409 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java: ## @@ -86,6 +86,20 @@ public MergeSpecification findMerges( return mergeSpec;

[GitHub] [lucene] vigyasharma commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

vigyasharma commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r867198860 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java: ## @@ -86,6 +86,20 @@ public MergeSpecification findMerges( return merg

[GitHub] [lucene] jtibshirani commented on a diff in pull request #870: LUCENE-10502: Refactor hnswVectors format

jtibshirani commented on code in PR #870: URL: https://github.com/apache/lucene/pull/870#discussion_r867171666 ## lucene/core/src/java/org/apache/lucene/codecs/lucene92/Lucene92HnswVectorsFormat.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [lucene] mayya-sharipova commented on pull request #872: LUCENE-10527 Use 2*maxConn for last layer in HNSW

mayya-sharipova commented on PR #872: URL: https://github.com/apache/lucene/pull/872#issuecomment-1119937491 Also here is the comparison of recall with hnswlib (results from hnwlib are copied from the [Jira issue](https://issues.apache.org/jira/browse/LUCENE-10527), and not run on my machi

[GitHub] [lucene] mayya-sharipova commented on pull request #872: LUCENE-10527 Use 2*maxConn for last layer in HNSW

mayya-sharipova commented on PR #872: URL: https://github.com/apache/lucene/pull/872#issuecomment-1119928464 I've run an evaluation: baseline: main branch **glove-100-angular M:64 efConstruction:100** candidate: this PR **glove-100-angular M:32 efConstruction:100**, **M:64 is used for

[GitHub] [lucene] mayya-sharipova commented on pull request #872: LUCENE-10527 Use 2*maxConn for last layer in HNSW

mayya-sharipova commented on PR #872: URL: https://github.com/apache/lucene/pull/872#issuecomment-1119925540 This patch involves format change, but for now I made changes in Lucene91* files. The plan is once another https://github.com/apache/lucene/pull/870 that introduces Lucene92* for

[GitHub] [lucene] mayya-sharipova opened a new pull request, #872: LUCENE-10527 Use 2*maxConn for last layer in HNSW

mayya-sharipova opened a new pull request, #872: URL: https://github.com/apache/lucene/pull/872 The original HNSW paper (https://arxiv.org/pdf/1603.09320.pdf) suggests to use a different maxConn for the upper layers vs. the bottom one (which contains the full neighborhood graph). Specif

[GitHub] [lucene] LuXugang commented on a diff in pull request #870: LUCENE-10502: Refactor hnswVectors format

LuXugang commented on code in PR #870: URL: https://github.com/apache/lucene/pull/870#discussion_r867032344 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene91/Lucene91Codec.java: ## @@ -164,7 +161,7 @@ public final PointsFormat pointsFormat() { }

[GitHub] [lucene] LuXugang commented on a diff in pull request #870: LUCENE-10502: Refactor hnswVectors format

LuXugang commented on code in PR #870: URL: https://github.com/apache/lucene/pull/870#discussion_r867034389 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene91/Lucene91HnswVectorsFormat.java: ## @@ -82,7 +82,7 @@ * * @lucene.experimental */ -publi

[GitHub] [lucene] LuXugang commented on a diff in pull request #870: LUCENE-10502: Refactor hnswVectors format

LuXugang commented on code in PR #870: URL: https://github.com/apache/lucene/pull/870#discussion_r867032344 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene91/Lucene91Codec.java: ## @@ -164,7 +161,7 @@ public final PointsFormat pointsFormat() { }

[GitHub] [lucene] LuXugang commented on a diff in pull request #870: LUCENE-10502: Refactor hnswVectors format

LuXugang commented on code in PR #870: URL: https://github.com/apache/lucene/pull/870#discussion_r867032344 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene91/Lucene91Codec.java: ## @@ -164,7 +161,7 @@ public final PointsFormat pointsFormat() { }

[GitHub] [lucene] msokolov commented on a diff in pull request #870: LUCENE-10502: Refactor hnswVectors format

msokolov commented on code in PR #870: URL: https://github.com/apache/lucene/pull/870#discussion_r866972665 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene91/Lucene91Codec.java: ## @@ -164,7 +161,7 @@ public final PointsFormat pointsFormat() { }

[GitHub] [lucene] LuXugang commented on pull request #870: LUCENE-10502: Refactor hnswVectors format

LuXugang commented on PR #870: URL: https://github.com/apache/lucene/pull/870#issuecomment-1119767221 oh~, it seems IDEA's refator did not work on this. addressed in https://github.com/apache/lucene/pull/870/commits/3a7a61a0bdeaa2ce3ed019f585f8333022fbab6a . -- This is an automated messa

[GitHub] [lucene] rmuir commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

rmuir commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r866919777 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java: ## @@ -86,6 +86,20 @@ public MergeSpecification findMerges( return mergeSpec;

[GitHub] [lucene] mocobeta commented on pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on PR #540: URL: https://github.com/apache/lucene/pull/540#issuecomment-1119710029 FYI, the feature freeze for the next release will be 10th May, according to the proposal for 9.2 release at Lucene's dev mail list. We still have a few more days until then, so I optimist

[jira] [Resolved] (LUCENE-10558) Add URL constructors for classpath/module usage as complement to Path ctors in Kuromoji and Nori

[ https://issues.apache.org/jira/browse/LUCENE-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-10558. Resolution: Fixed Thanks to all who helped/commented/complained! > Add URL constructors

[jira] [Commented] (LUCENE-10558) Add URL constructors for classpath/module usage as complement to Path ctors in Kuromoji and Nori

[ https://issues.apache.org/jira/browse/LUCENE-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532905#comment-17532905 ] ASF subversion and git services commented on LUCENE-10558: -- Co

[jira] [Commented] (LUCENE-10558) Add URL constructors for classpath/module usage as complement to Path ctors in Kuromoji and Nori

[ https://issues.apache.org/jira/browse/LUCENE-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532904#comment-17532904 ] Uwe Schindler commented on LUCENE-10558: This was fixed in 9.x (9.2 is next rel

[GitHub] [lucene] uschindler merged pull request #871: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries (main branch)

uschindler merged PR #871: URL: https://github.com/apache/lucene/pull/871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[jira] [Commented] (LUCENE-10558) Add URL constructors for classpath/module usage as complement to Path ctors in Kuromoji and Nori

[ https://issues.apache.org/jira/browse/LUCENE-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532903#comment-17532903 ] Uwe Schindler commented on LUCENE-10558: Forward port to main branch: https://g

[jira] [Updated] (LUCENE-10558) Add URL constructors for classpath/module usage as complement to Path ctors in Kuromoji and Nori

[ https://issues.apache.org/jira/browse/LUCENE-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-10558: --- Component/s: modules/analysis > Add URL constructors for classpath/module usage as compleme

[jira] [Updated] (LUCENE-10558) Add URL constructors for classpath/module usage as complement to Path ctors in Kuromoji and Nori

[ https://issues.apache.org/jira/browse/LUCENE-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-10558: --- Affects Version/s: 9.1 > Add URL constructors for classpath/module usage as complement to P

[jira] [Updated] (LUCENE-10558) Add URL constructors for classpath/module usage as complement to Path ctors in Kuromoji and Nori

[ https://issues.apache.org/jira/browse/LUCENE-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-10558: --- Fix Version/s: 10.0 (main) 9.2 > Add URL constructors for classpath/modu

[GitHub] [lucene] uschindler closed pull request #867: LUCENE-10558: expose stream-based Kuromoji resource constructors

uschindler closed pull request #867: LUCENE-10558: expose stream-based Kuromoji resource constructors URL: https://github.com/apache/lucene/pull/867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [lucene] uschindler commented on pull request #867: LUCENE-10558: expose stream-based Kuromoji resource constructors

uschindler commented on PR #867: URL: https://github.com/apache/lucene/pull/867#issuecomment-1119701375 Close because superseeded by #868 and #871. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene] uschindler commented on pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

uschindler commented on PR #868: URL: https://github.com/apache/lucene/pull/868#issuecomment-1119699944 See #871 for the port to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [lucene] uschindler opened a new pull request, #871: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries (main branch)

uschindler opened a new pull request, #871: URL: https://github.com/apache/lucene/pull/871 see https://issues.apache.org/jira/browse/LUCENE-10558 This is the forward-port of #868 with deprecated code removed -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene] NightOwl888 commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

NightOwl888 commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866896180 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[jira] [Commented] (LUCENE-10558) Add URL constructors for classpath/module usage as complement to Path ctors in Kuromoji and Nori

[ https://issues.apache.org/jira/browse/LUCENE-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532885#comment-17532885 ] ASF subversion and git services commented on LUCENE-10558: -- Co

[GitHub] [lucene] uschindler merged pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

uschindler merged PR #868: URL: https://github.com/apache/lucene/pull/868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866869681 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] uschindler commented on pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

uschindler commented on PR #868: URL: https://github.com/apache/lucene/pull/868#issuecomment-1119664675 Changes added waiting for precommit checks before merge. Will open another PR for the forward port of the URL APIs. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [lucene] NightOwl888 commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

NightOwl888 commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866865906 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866859685 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866835280 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866852498 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] NightOwl888 commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

NightOwl888 commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866851935 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866843441 ## lucene/analysis/common/src/test/org/apache/lucene/analysis/fa/TestPersianStemFilter.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866843441 ## lucene/analysis/common/src/test/org/apache/lucene/analysis/fa/TestPersianStemFilter.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866835280 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866835280 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] NightOwl888 commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

NightOwl888 commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866793959 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [lucene] NightOwl888 commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

NightOwl888 commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866793959 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[jira] [Created] (LUCENE-10560) Can we speed up OrdinalMap construction?

Adrien Grand created LUCENE-10560: - Summary: Can we speed up OrdinalMap construction? Key: LUCENE-10560 URL: https://issues.apache.org/jira/browse/LUCENE-10560 Project: Lucene - Core Issue Ty

[GitHub] [lucene] mocobeta commented on pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

mocobeta commented on PR #868: URL: https://github.com/apache/lucene/pull/868#issuecomment-1119609843 > The Backwards Compatibility Policeman couldn't resist. ![duke_police](https://user-images.githubusercontent.com/1825333/167138767-e6c9f6dc-8c2c-4f4c-94dc-5608139d492f.png

[GitHub] [lucene] uschindler commented on pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

uschindler commented on PR #868: URL: https://github.com/apache/lucene/pull/868#issuecomment-1119600582 OK great, I will add some migration text and a good changes entry. So we have restored 9.0/earlier behaviour. Thanks @msokolov for trying out. Sorry for the noise, but luckily INFRA

[GitHub] [lucene] NightOwl888 commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

NightOwl888 commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866798287 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [lucene] NightOwl888 commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

NightOwl888 commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866802507 ## lucene/analysis/common/src/test/org/apache/lucene/analysis/fa/TestPersianStemFilter.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [lucene] NightOwl888 commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

NightOwl888 commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866798287 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [lucene] msokolov commented on pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

msokolov commented on PR #868: URL: https://github.com/apache/lucene/pull/868#issuecomment-1119583459 I tried to hide some sonatype noise as Spam but github thought I was calling Uwe's comment Spam - sorry! I don't see how to undo that. Anyway I tested the latest version here with our exist

[GitHub] [lucene] NightOwl888 commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

NightOwl888 commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866793959 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [lucene] wjp719 commented on pull request #780: LUCENE-10496: avoid unnecessary attempts to evaluate skipping doc if index sort and search sort are in opposite direction

wjp719 commented on PR #780: URL: https://github.com/apache/lucene/pull/780#issuecomment-1119568905 @jpountz Hi, I add an adaptive skip interval to avoid unnecessary frequent attempts to skip docs, can you help to review again. I also rerun the rally tests, following is the result:

[GitHub] [lucene] msokolov commented on a diff in pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

msokolov commented on code in PR #868: URL: https://github.com/apache/lucene/pull/868#discussion_r866758366 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java: ## @@ -140,19 +140,15 @@ public static final InputStream getResource(Resour

[GitHub] [lucene] uschindler commented on a diff in pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

uschindler commented on code in PR #868: URL: https://github.com/apache/lucene/pull/868#discussion_r866688004 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java: ## @@ -140,19 +140,15 @@ public static final InputStream getResource(Reso

[GitHub] [lucene] uschindler commented on a diff in pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

uschindler commented on code in PR #868: URL: https://github.com/apache/lucene/pull/868#discussion_r866685219 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java: ## @@ -140,19 +140,15 @@ public static final InputStream getResource(Reso

[GitHub] [lucene] mocobeta commented on pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on PR #540: URL: https://github.com/apache/lucene/pull/540#issuecomment-1119459461 I left some minor comments. I suppose we need a [CHANGES](https://github.com/apache/lucene/blob/main/lucene/CHANGES.txt) entry in the 9.2.0 New Features section. Could you add the line?

[GitHub] [lucene] uschindler commented on a diff in pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

uschindler commented on code in PR #868: URL: https://github.com/apache/lucene/pull/868#discussion_r89648 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java: ## @@ -140,19 +140,15 @@ public static final InputStream getResource(Reso

[GitHub] [lucene] uschindler commented on a diff in pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

uschindler commented on code in PR #868: URL: https://github.com/apache/lucene/pull/868#discussion_r89648 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java: ## @@ -140,19 +140,15 @@ public static final InputStream getResource(Reso

[GitHub] [lucene] uschindler commented on a diff in pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

uschindler commented on code in PR #868: URL: https://github.com/apache/lucene/pull/868#discussion_r84382 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java: ## @@ -140,19 +140,15 @@ public static final InputStream getResource(Reso

[GitHub] [lucene] uschindler commented on a diff in pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

uschindler commented on code in PR #868: URL: https://github.com/apache/lucene/pull/868#discussion_r84382 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java: ## @@ -140,19 +140,15 @@ public static final InputStream getResource(Reso

[jira] [Commented] (LUCENE-10436) Combine DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery into a single FieldExistsQuery?

[ https://issues.apache.org/jira/browse/LUCENE-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532719#comment-17532719 ] ASF subversion and git services commented on LUCENE-10436: -- Co

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866629297 ## lucene/analysis/common/src/test/org/apache/lucene/analysis/fa/TestPersianStemFilter.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866621533 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866616821 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[jira] [Commented] (LUCENE-10436) Combine DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery into a single FieldExistsQuery?

[ https://issues.apache.org/jira/browse/LUCENE-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532708#comment-17532708 ] ASF subversion and git services commented on LUCENE-10436: -- Co

[GitHub] [lucene] romseygeek merged pull request #869: LUCENE-10436: Reinstate public getdocValuesdocIdSetIterator method on DocValues

romseygeek merged PR #869: URL: https://github.com/apache/lucene/pull/869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866613607 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866610369 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866608310 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866604890 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866603221 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866598127 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemmer.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866590353 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemFilterFactory.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866588395 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemFilterFactory.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [lucene] LuXugang commented on pull request #792: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

LuXugang commented on PR #792: URL: https://github.com/apache/lucene/pull/792#issuecomment-1119360564 @mayya-sharipova I refer to what https://github.com/apache/lucene/pull/608 did before and do the format changes in new [RP](https://github.com/apache/lucene/pull/870) , hope that I did not

[GitHub] [lucene] mocobeta commented on a diff in pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on code in PR #540: URL: https://github.com/apache/lucene/pull/540#discussion_r866581696 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianStemFilter.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [lucene] mocobeta commented on a diff in pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

mocobeta commented on code in PR #868: URL: https://github.com/apache/lucene/pull/868#discussion_r866551533 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java: ## @@ -140,19 +140,15 @@ public static final InputStream getResource(Resour

[GitHub] [lucene] uschindler commented on pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

uschindler commented on PR #868: URL: https://github.com/apache/lucene/pull/868#issuecomment-1119321941 I did some more changes to the inconsistent API. We cannot support all "old" usage. If somebody calls the deprecated TokenInfoDictionary ctor with a null path, heshe gets a message to use