uschindler commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r866669648
##########
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java:
##########
@@ -140,19 +140,15 @@ public static final InputStream
getResource(ResourceScheme scheme, String path)
throws IOException {
switch (scheme) {
case CLASSPATH:
- return getClassResource(path);
+ return IOUtils.requireResourceNonNull(
+ BinaryDictionary.class.getClassLoader().getResourceAsStream(path),
path);
Review Comment:
Before mergings this I am hoping for @msokolov to try it out with his code
at amazon (not changing his code from Lucene 9.0 that broke at all). This
ensures that backwards layer is sufficient.
Of course Mike should later rewrite his code to use the new `URL` APIs
instead of deprecated ones with `HisClass.class.getResource()` or similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
