[
https://issues.apache.org/jira/browse/LUCENE-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530476#comment-17530476
]
Vigya Sharma commented on LUCENE-10216:
---
I think the PR is ready for review, with
rmuir commented on code in PR #858:
URL: https://github.com/apache/lucene/pull/858#discussion_r862383315
##
lucene/core/src/test/org/apache/lucene/util/compress/TestLowercaseAsciiCompression.java:
##
@@ -118,4 +134,12 @@ public void testRandom() throws IOException {
doTes
mikemccand commented on PR #858:
URL: https://github.com/apache/lucene/pull/858#issuecomment-1114025936
And to improve testing we should add a higher level test indexing
"difficult" terms through IW/blocktree so that the invocations in the test (via
blocktree and not the direct low-level AP
mikemccand opened a new pull request, #858:
URL: https://github.com/apache/lucene/pull/858
# Description
Just improving testing based on the user-reported
`IllegalArgumentException`, but the new tests seem to pass in my few runs ...
maybe Jenkins CI builds will uncover an interesting
[
https://issues.apache.org/jira/browse/LUCENE-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530423#comment-17530423
]
Michael McCandless commented on LUCENE-10551:
-
I think at a minimum we shou
[
https://issues.apache.org/jira/browse/LUCENE-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-10551:
Attachment: LUCENE-10551-test.patch
Status: Open (was: Open)
Hmm I wrote
LuXugang commented on code in PR #792:
URL: https://github.com/apache/lucene/pull/792#discussion_r862374612
##
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java:
##
@@ -320,13 +323,19 @@ private static class FieldEntry {
final int numLeve
LuXugang commented on code in PR #792:
URL: https://github.com/apache/lucene/pull/792#discussion_r862374612
##
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java:
##
@@ -320,13 +323,19 @@ private static class FieldEntry {
final int numLeve
LuXugang commented on code in PR #792:
URL: https://github.com/apache/lucene/pull/792#discussion_r862373384
##
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java:
##
@@ -258,14 +257,18 @@ public TopDocs search(String field, float[] target, int
LuXugang commented on PR #792:
URL: https://github.com/apache/lucene/pull/792#issuecomment-1114014473
> I've left a couple of comments, but I am also wondering what is the reason
you deleted `TestBackwardsCompatibility.java` in this PR?
Hi @mayya-sharipova , since `9.1.0-cfs` and `9.1
[
https://issues.apache.org/jira/browse/LUCENE-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530419#comment-17530419
]
Michael McCandless commented on LUCENE-10551:
-
Yeah this is definitely no g
mocobeta commented on PR #854:
URL: https://github.com/apache/lucene/pull/854#issuecomment-1113979801
Thanks everyone for your feedback. I don't think this is such a big deal
though, I'll wait for a few more days before merging as I wrote in the mail
list.
--
This is an automated message
mocobeta commented on code in PR #854:
URL: https://github.com/apache/lucene/pull/854#discussion_r862349332
##
lucene/CHANGES.txt:
##
@@ -175,6 +175,8 @@ Other
* LUCENE-10541: Test-framework: limit the default length of MockTokenizer
tokens to 255.
(Robert Muir, Uwe Schindl
13 matches
Mail list logo
