[GitHub] [lucene] gautamworah96 commented on pull request #779: LUCENE-10488: Optimize Facets#getTopDims in IntTaxonomyFacets

2022-04-16 Thread GitBox
gautamworah96 commented on PR #779: URL: https://github.com/apache/lucene/pull/779#issuecomment-1100800360 I have not taken a detailed look at the PR yet. From the benchmark results posted, I see that we've got a regression in several taxonomy tasks that utilize BInaryDocValues. See (-15, -

[GitHub] [lucene] yixunx commented on pull request #756: LUCENE-10470: [Tessellator] Prevent bridges that introduce collinear edges

2022-04-16 Thread GitBox
yixunx commented on PR #756: URL: https://github.com/apache/lucene/pull/756#issuecomment-1100790763 Hi @iverase it turns out that many of my failed shapes failed because they contain self-intersections and I set `checkSelfIntersections = true` when running the tessellator. They do not run i

[GitHub] [lucene] LuXugang commented on pull request #792: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

2022-04-16 Thread GitBox
LuXugang commented on PR #792: URL: https://github.com/apache/lucene/pull/792#issuecomment-1100685721 > @LuXugang Thanks a lot for your work. I was thinking may be a better way to present these changes is to leave all formats changes to a later PR. And for this PR just to make changes on `L

[GitHub] [lucene] LuXugang commented on a diff in pull request #792: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

2022-04-16 Thread GitBox
LuXugang commented on code in PR #792: URL: https://github.com/apache/lucene/pull/792#discussion_r851637023 ## lucene/core/src/java/org/apache/lucene/codecs/lucene92/Lucene92HnswVectorsWriter.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[jira] [Created] (LUCENE-10518) FieldInfos consistency check can refuse to open Lucene 8 index

2022-04-16 Thread Nhat Nguyen (Jira)
Nhat Nguyen created LUCENE-10518: Summary: FieldInfos consistency check can refuse to open Lucene 8 index Key: LUCENE-10518 URL: https://issues.apache.org/jira/browse/LUCENE-10518 Project: Lucene - Co

[GitHub] [lucene] mocobeta commented on pull request #811: Add some basic tasks to help/workflow

2022-04-16 Thread GitBox
mocobeta commented on PR #811: URL: https://github.com/apache/lucene/pull/811#issuecomment-1100650074 @dweiss would you mind if I push it to main? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to