[GitHub] [lucene] spike-liu opened a new pull request #678: LUCENE-10398: Add static method for getting Terms from LeafReader

2022-02-13 Thread GitBox
spike-liu opened a new pull request #678: URL: https://github.com/apache/lucene/pull/678 https://issues.apache.org/jira/browse/LUCENE-10398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Commented] (LUCENE-10398) Add static method for getting Terms from LeafReader

2022-02-13 Thread spike liu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491844#comment-17491844 ] spike liu commented on LUCENE-10398: I would like to take care of this. > Add stat

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491834#comment-17491834 ] Dawid Weiss commented on LUCENE-10419: -- Interesting, didn't even know such a thing

[GitHub] [lucene] vigyasharma opened a new pull request #677: LUCENE-10084: Rewrite DocValuesFieldExistsQuery to MatchAllDocsQuery when all docs have the field

2022-02-13 Thread GitBox
vigyasharma opened a new pull request #677: URL: https://github.com/apache/lucene/pull/677 # Description Since all documents are required to use the same features ([LUCENE-9334](https://issues.apache.org/jira/browse/LUCENE-9334)) we could rewrite DocValuesFieldExistsQuer

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491832#comment-17491832 ] Uwe Schindler commented on LUCENE-10419: Hi Dawid, the simple synchronized bloc

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491826#comment-17491826 ] Dawid Weiss commented on LUCENE-10419: -- > Maybe the rat task in our Gradle build s

[GitHub] [lucene] spike-liu commented on a change in pull request #676: Lucene-10176: Remove VectorValues#size()

2022-02-13 Thread GitBox
spike-liu commented on a change in pull request #676: URL: https://github.com/apache/lucene/pull/676#discussion_r805441501 ## File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java ## @@ -38,15 +38,6 @@ protected VectorValues() {} /** Return the dimension

[GitHub] [lucene-solr] itygh commented on pull request #2640: SOLR-15974: Remove Calcite's ENUMERABLE_AGGREGATE_RULE as Solr only s…

2022-02-13 Thread GitBox
itygh commented on pull request #2640: URL: https://github.com/apache/lucene-solr/pull/2640#issuecomment-1037330151 这是来自QQ邮箱的假期自动回复邮件。您好,我最近正在休假中,无法亲自回复您的邮件。我将在假期结束后,尽快给您回复。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [lucene] uschindler commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

2022-02-13 Thread GitBox
uschindler commented on a change in pull request #673: URL: https://github.com/apache/lucene/pull/673#discussion_r805154103 ## File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java ## @@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir) t

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #649: LUCENE-10408 Better encoding of doc Ids in vectors

2022-02-13 Thread GitBox
mayya-sharipova commented on a change in pull request #649: URL: https://github.com/apache/lucene/pull/649#discussion_r805395018 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsWriter.java ## @@ -206,14 +214,19 @@ private void writeMeta(

[GitHub] [lucene] mayya-sharipova commented on pull request #649: LUCENE-10408 Better encoding of doc Ids in vectors

2022-02-13 Thread GitBox
mayya-sharipova commented on pull request #649: URL: https://github.com/apache/lucene/pull/649#issuecomment-1038311005 @jpountz @jtibshirani Thank you for your suggestions. Are you ok if we keep this PR as it is now to optimize the dense case only, and explore Adrien's suggestions for a

[GitHub] [lucene-solr] thelabdude merged pull request #2640: SOLR-15974: Remove Calcite's ENUMERABLE_AGGREGATE_RULE as Solr only s…

2022-02-13 Thread GitBox
thelabdude merged pull request #2640: URL: https://github.com/apache/lucene-solr/pull/2640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene-solr] itygh removed a comment on pull request #2640: SOLR-15974: Remove Calcite's ENUMERABLE_AGGREGATE_RULE as Solr only s…

2022-02-13 Thread GitBox
itygh removed a comment on pull request #2640: URL: https://github.com/apache/lucene-solr/pull/2640#issuecomment-1037330151 这是来自QQ邮箱的假期自动回复邮件。您好,我最近正在休假中,无法亲自回复您的邮件。我将在假期结束后,尽快给您回复。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Commented] (LUCENE-10177) Rename VectorValues#dimension to VectorValues#getNumDimensions?

2022-02-13 Thread spike liu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491734#comment-17491734 ] spike liu commented on LUCENE-10177: Thanks for your review Michael. I am fine with

[GitHub] [lucene] spike-liu commented on a change in pull request #676: Lucene-10176: Remove VectorValues#size()

2022-02-13 Thread GitBox
spike-liu commented on a change in pull request #676: URL: https://github.com/apache/lucene/pull/676#discussion_r805442207 ## File path: lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java ## @@ -929,6 +931,17 @@ private void add(

[GitHub] [lucene] spike-liu commented on a change in pull request #676: Lucene-10176: Remove VectorValues#size()

2022-02-13 Thread GitBox
spike-liu commented on a change in pull request #676: URL: https://github.com/apache/lucene/pull/676#discussion_r805441501 ## File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java ## @@ -38,15 +38,6 @@ protected VectorValues() {} /** Return the dimension

[GitHub] [lucene] spike-liu commented on a change in pull request #676: Lucene-10176: Remove VectorValues#size()

2022-02-13 Thread GitBox
spike-liu commented on a change in pull request #676: URL: https://github.com/apache/lucene/pull/676#discussion_r805441501 ## File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java ## @@ -38,15 +38,6 @@ protected VectorValues() {} /** Return the dimension

[GitHub] [lucene] spike-liu commented on a change in pull request #676: Lucene-10176: Remove VectorValues#size()

2022-02-13 Thread GitBox
spike-liu commented on a change in pull request #676: URL: https://github.com/apache/lucene/pull/676#discussion_r805441501 ## File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java ## @@ -38,15 +38,6 @@ protected VectorValues() {} /** Return the dimension

[GitHub] [lucene] spike-liu commented on a change in pull request #676: Lucene-10176: Remove VectorValues#size()

2022-02-13 Thread GitBox
spike-liu commented on a change in pull request #676: URL: https://github.com/apache/lucene/pull/676#discussion_r805441501 ## File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java ## @@ -38,15 +38,6 @@ protected VectorValues() {} /** Return the dimension

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491658#comment-17491658 ] Uwe Schindler commented on LUCENE-10419: Hi Dawid, I am a bit afraid that our r

[GitHub] [lucene] mayya-sharipova commented on pull request #649: LUCENE-10408 Better encoding of doc Ids in vectors

2022-02-13 Thread GitBox
mayya-sharipova commented on pull request #649: URL: https://github.com/apache/lucene/pull/649#issuecomment-1038311005 @jpountz @jtibshirani Thank you for your suggestions. Are you ok if we keep this PR as it is now to optimize the dense case only, and explore Adrien's suggestions for a

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #649: LUCENE-10408 Better encoding of doc Ids in vectors

2022-02-13 Thread GitBox
mayya-sharipova commented on a change in pull request #649: URL: https://github.com/apache/lucene/pull/649#discussion_r805395172 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsWriter.java ## @@ -138,9 +140,20 @@ public void writeField(F

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #649: LUCENE-10408 Better encoding of doc Ids in vectors

2022-02-13 Thread GitBox
mayya-sharipova commented on a change in pull request #649: URL: https://github.com/apache/lucene/pull/649#discussion_r805395073 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java ## @@ -372,7 +393,9 @@ int size() { imple

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #649: LUCENE-10408 Better encoding of doc Ids in vectors

2022-02-13 Thread GitBox
mayya-sharipova commented on a change in pull request #649: URL: https://github.com/apache/lucene/pull/649#discussion_r805395018 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsWriter.java ## @@ -206,14 +214,19 @@ private void writeMeta(

[jira] [Updated] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10419: - Fix Version/s: 9.1 (was: 9.x) > Identify occasional validateSourcePatter

[jira] [Resolved] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10419. -- Fix Version/s: 9.x Resolution: Fixed > Identify occasional validateSourcePatterns erro

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491652#comment-17491652 ] ASF subversion and git services commented on LUCENE-10419: -- Co

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491653#comment-17491653 ] Dawid Weiss commented on LUCENE-10419: -- Thanks for your help, Uwe! > Identify occ

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491651#comment-17491651 ] ASF subversion and git services commented on LUCENE-10419: -- Co

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491649#comment-17491649 ] Dawid Weiss commented on LUCENE-10419: -- I can reproduce this elsewhere by magnifyi

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491643#comment-17491643 ] ASF subversion and git services commented on LUCENE-10419: -- Co

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491645#comment-17491645 ] ASF subversion and git services commented on LUCENE-10419: -- Co

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491640#comment-17491640 ] Dawid Weiss commented on LUCENE-10419: -- I know what this is. Thanks for sharing th

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491568#comment-17491568 ] Uwe Schindler commented on LUCENE-10419: I also deleted all shitty Gradle cache

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491545#comment-17491545 ] Uwe Schindler commented on LUCENE-10419: Hi, I will give you access. Check Goo

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491544#comment-17491544 ] Uwe Schindler commented on LUCENE-10419: Hi, it failed in the 3rd run of above

[jira] [Comment Edited] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491543#comment-17491543 ] Uwe Schindler edited comment on LUCENE-10419 at 2/13/22, 9:54 AM: ---

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491543#comment-17491543 ] Uwe Schindler commented on LUCENE-10419: Hi Dawid, will check now. I haven't s