uschindler commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r805154103
##########
File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java
##########
@@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir)
throws IOException {
* An IO operation with a single input.
*
* @see java.util.function.Consumer
+ * @deprecated was replaced by {@link org.apache.lucene.util.IOConsumer}.
*/
@FunctionalInterface
+ @Deprecated(forRemoval = true, since = "9.1")
public interface IOConsumer<T> {
Review comment:
I committed the remaining changes. The IOUtils.applyToAll method now
takes the old interface as parameter for backwards compatibility. Now code
compiled against Lucene 9.0 still works in 9.1
##########
File path: lucene/core/src/java/org/apache/lucene/util/IOConsumer.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.util;
+
+import java.io.IOException;
+
+/**
+ * An IO operation with a single input that may throw an IOException.
+ *
+ * @see java.util.function.Consumer
+ * @param <T> the consumer's input type.
+ */
+@FunctionalInterface
+@SuppressWarnings("removal")
+public interface IOConsumer<T> extends IOUtils.IOConsumer<T> {
+ /**
+ * Performs this operation on the given argument.
+ *
+ * @param input the input argument
+ * @throws IOException if producing the result throws an {@link IOException}
+ */
+ @Override
Review comment:
this annotation need to be removed in main
##########
File path: lucene/core/src/java/org/apache/lucene/util/IOConsumer.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.util;
+
+import java.io.IOException;
+
+/**
+ * An IO operation with a single input that may throw an IOException.
+ *
+ * @see java.util.function.Consumer
+ * @param <T> the consumer's input type.
+ */
+@FunctionalInterface
+@SuppressWarnings("removal")
+public interface IOConsumer<T> extends IOUtils.IOConsumer<T> {
Review comment:
the extends clause needs to be removed in main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
