[GitHub] [lucene] mocobeta commented on a change in pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

mocobeta commented on a change in pull request #643: URL: https://github.com/apache/lucene/pull/643#discussion_r799940540 ## File path: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java ## @@ -154,6 +153,98 @@ protected BinaryDictionary

[GitHub] [lucene] mocobeta commented on a change in pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

mocobeta commented on a change in pull request #643: URL: https://github.com/apache/lucene/pull/643#discussion_r799940540 ## File path: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java ## @@ -154,6 +153,98 @@ protected BinaryDictionary

[GitHub] [lucene] mocobeta commented on a change in pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

mocobeta commented on a change in pull request #643: URL: https://github.com/apache/lucene/pull/643#discussion_r799936524 ## File path: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java ## @@ -154,6 +153,98 @@ protected BinaryDictionary

[GitHub] [lucene] mocobeta commented on a change in pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

mocobeta commented on a change in pull request #643: URL: https://github.com/apache/lucene/pull/643#discussion_r799940540 ## File path: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java ## @@ -154,6 +153,98 @@ protected BinaryDictionary

[GitHub] [lucene] mocobeta commented on a change in pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

mocobeta commented on a change in pull request #643: URL: https://github.com/apache/lucene/pull/643#discussion_r799936766 ## File path: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/ConnectionCosts.java ## @@ -61,8 +68,63 @@ public ConnectionCosts(Binary

[GitHub] [lucene] mocobeta commented on a change in pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

mocobeta commented on a change in pull request #643: URL: https://github.com/apache/lucene/pull/643#discussion_r799936524 ## File path: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java ## @@ -154,6 +153,98 @@ protected BinaryDictionary

[GitHub] [lucene] jtibshirani commented on a change in pull request #649: LUCENE-10408 Better encoding of doc Ids in vectors

jtibshirani commented on a change in pull request #649: URL: https://github.com/apache/lucene/pull/649#discussion_r799925962 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsWriter.java ## @@ -140,7 +142,10 @@ public void writeField(Field

[jira] [Resolved] (LUCENE-10050) Remove DrillSideways#search(DrillDownQuery,Collector) in favor of DrillSideways#search(DrillDownQuery,CollectorManager)

[ https://issues.apache.org/jira/browse/LUCENE-10050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10050. -- Fix Version/s: 9.1 10.0 (main) Resolution: Fixed Merged onto {{main

[GitHub] [lucene] gsmiller commented on pull request #650: LUCENE-10050 Remove DrillSideways#search(DrillDownQuery,Collector) in favor of DrillSideways#search(DrillDownQuery,CollectorManager)

gsmiller commented on pull request #650: URL: https://github.com/apache/lucene/pull/650#issuecomment-1030451682 Thanks again @gautamworah96 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (LUCENE-10050) Remove DrillSideways#search(DrillDownQuery,Collector) in favor of DrillSideways#search(DrillDownQuery,CollectorManager)

[ https://issues.apache.org/jira/browse/LUCENE-10050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487377#comment-17487377 ] ASF subversion and git services commented on LUCENE-10050: -- Co

[GitHub] [lucene] gsmiller merged pull request #650: LUCENE-10050 Remove DrillSideways#search(DrillDownQuery,Collector) in favor of DrillSideways#search(DrillDownQuery,CollectorManager)

gsmiller merged pull request #650: URL: https://github.com/apache/lucene/pull/650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [lucene] gsmiller commented on pull request #644: LUCENE-10403: Add ArrayUtil#grow(T[])

gsmiller commented on pull request #644: URL: https://github.com/apache/lucene/pull/644#issuecomment-1030444352 Thanks @msokolov. It's a little sneaky as a number of places appear to be good candidates to use the new method because they're doing a `+ 1`, but they're adding 1 to something o

[GitHub] [lucene] gsmiller commented on pull request #650: LUCENE-10050 Remove DrillSideways#search(DrillDownQuery,Collector) in favor of DrillSideways#search(DrillDownQuery,CollectorManager)

gsmiller commented on pull request #650: URL: https://github.com/apache/lucene/pull/650#issuecomment-1030430764 @gautamworah96 would you mind giving this a look when you have a moment to make sure I didn't miss anything? This is just a backport of your change to 9.x but leaving in DS#searc

[GitHub] [lucene] gsmiller opened a new pull request #650: LUCENE-10050 Remove DrillSideways#search(DrillDownQuery,Collector) in favor of DrillSideways#search(DrillDownQuery,CollectorManager)

gsmiller opened a new pull request #650: URL: https://github.com/apache/lucene/pull/650 Backport (but marking `DrillSideways#search(DrillDownQuery,Collector)` as deprecated instead of removing it completely for 9.x) -- This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (LUCENE-10050) Remove DrillSideways#search(DrillDownQuery,Collector) in favor of DrillSideways#search(DrillDownQuery,CollectorManager)

[ https://issues.apache.org/jira/browse/LUCENE-10050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487369#comment-17487369 ] ASF subversion and git services commented on LUCENE-10050: -- Co

[GitHub] [lucene] gsmiller merged pull request #632: LUCENE-10050 Remove DrillSideways#search(DrillDownQuery,Collector) in favor of DrillSideways#search(DrillDownQuery,CollectorManager)

gsmiller merged pull request #632: URL: https://github.com/apache/lucene/pull/632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [lucene] mayya-sharipova opened a new pull request #649: LUCENE-10408 Better encoding of doc Ids in vectors

mayya-sharipova opened a new pull request #649: URL: https://github.com/apache/lucene/pull/649 Better encoding of doc Ids in Lucene91HnswVectorsFormat Currently we write doc Ids of all documents that have vectors not very efficiently. This improve their encoding by: - for a c

[jira] [Created] (LUCENE-10408) Better encoding of doc Ids in Lucene91HnswVectorsFormat

Mayya Sharipova created LUCENE-10408: Summary: Better encoding of doc Ids in Lucene91HnswVectorsFormat Key: LUCENE-10408 URL: https://issues.apache.org/jira/browse/LUCENE-10408 Project: Lucene - Co

[jira] [Assigned] (LUCENE-10408) Better encoding of doc Ids in Lucene91HnswVectorsFormat

[ https://issues.apache.org/jira/browse/LUCENE-10408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova reassigned LUCENE-10408: Assignee: Mayya Sharipova > Better encoding of doc Ids in Lucene91HnswVectorsFor

[jira] [Commented] (LUCENE-10054) Handle hierarchy in HNSW graph

[ https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487278#comment-17487278 ] ASF subversion and git services commented on LUCENE-10054: -- Co

[jira] [Closed] (LUCENE-10054) Handle hierarchy in HNSW graph

[ https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova closed LUCENE-10054. > Handle hierarchy in HNSW graph > -- > > Key: LU

[jira] [Resolved] (LUCENE-10054) Handle hierarchy in HNSW graph

[ https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova resolved LUCENE-10054. -- Fix Version/s: 9.1 Resolution: Fixed > Handle hierarchy in HNSW graph > --

[jira] [Resolved] (LUCENE-9573) Add back compat tests for VectorFormat to TestBackwardsCompatibility

[ https://issues.apache.org/jira/browse/LUCENE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova resolved LUCENE-9573. - Fix Version/s: 10.0 (main) Resolution: Fixed > Add back compat tests for VectorFo

[jira] [Closed] (LUCENE-9573) Add back compat tests for VectorFormat to TestBackwardsCompatibility

[ https://issues.apache.org/jira/browse/LUCENE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova closed LUCENE-9573. --- > Add back compat tests for VectorFormat to TestBackwardsCompatibility > ---

[jira] [Commented] (LUCENE-9573) Add back compat tests for VectorFormat to TestBackwardsCompatibility

[ https://issues.apache.org/jira/browse/LUCENE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487272#comment-17487272 ] ASF subversion and git services commented on LUCENE-9573: - Commi

[GitHub] [lucene] zhaih commented on a change in pull request #630: LUCENE-10371 Make IndexRearranger able to arrange segment in a determined order

zhaih commented on a change in pull request #630: URL: https://github.com/apache/lucene/pull/630#discussion_r799744915 ## File path: lucene/misc/src/java/org/apache/lucene/misc/index/IndexRearranger.java ## @@ -84,6 +112,28 @@ public void execute() throws Exception { }

[GitHub] [lucene] zhaih commented on a change in pull request #630: LUCENE-10371 Make IndexRearranger able to arrange segment in a determined order

zhaih commented on a change in pull request #630: URL: https://github.com/apache/lucene/pull/630#discussion_r799744597 ## File path: lucene/misc/src/java/org/apache/lucene/misc/index/IndexRearranger.java ## @@ -49,16 +53,40 @@ protected final Directory input, output; pro

[jira] [Resolved] (LUCENE-10407) ContainingIntervalIterator can incorrectly report positions after exhaustion

[ https://issues.apache.org/jira/browse/LUCENE-10407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-10407. Fix Version/s: 9.1 Resolution: Fixed > ContainingIntervalIterator can incorrectly

[jira] [Commented] (LUCENE-10407) ContainingIntervalIterator can incorrectly report positions after exhaustion

[ https://issues.apache.org/jira/browse/LUCENE-10407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487188#comment-17487188 ] ASF subversion and git services commented on LUCENE-10407: -- Co

[jira] [Commented] (LUCENE-10402) Intervals.prefix() handles multicharacter unicode incorrectly

[ https://issues.apache.org/jira/browse/LUCENE-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487187#comment-17487187 ] ASF subversion and git services commented on LUCENE-10402: -- Co

[GitHub] [lucene] jtibshirani commented on pull request #641: LUCENE-10391: Reuse data structures across HnswGraph#searchLevel calls

jtibshirani commented on pull request #641: URL: https://github.com/apache/lucene/pull/641#issuecomment-1030190957 > I think we cannot use intinthashset in core I used `IntIntHashMap` as a quick test, which was recently copied in from hppc to `org.apache.lucene.util.hppc`. -- Th

[jira] [Commented] (LUCENE-10407) ContainingIntervalIterator can incorrectly report positions after exhaustion

[ https://issues.apache.org/jira/browse/LUCENE-10407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487182#comment-17487182 ] ASF subversion and git services commented on LUCENE-10407: -- Co

[GitHub] [lucene] romseygeek merged pull request #648: LUCENE-10407: Set bpos flag to true when containing filter is exhausted

romseygeek merged pull request #648: URL: https://github.com/apache/lucene/pull/648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [lucene] uschindler commented on a change in pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

uschindler commented on a change in pull request #643: URL: https://github.com/apache/lucene/pull/643#discussion_r799620611 ## File path: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java ## @@ -154,6 +153,98 @@ protected BinaryDictiona

[jira] [Resolved] (LUCENE-10406) Incorrect match with disjunction and extends interval

[ https://issues.apache.org/jira/browse/LUCENE-10406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10406. -- Resolution: Duplicate https://issues.apache.org/jira/browse/LUCENE-10407 > Incorrect match w

[jira] [Commented] (LUCENE-10406) Incorrect match with disjunction and extends interval

[ https://issues.apache.org/jira/browse/LUCENE-10406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487157#comment-17487157 ] Alan Woodward commented on LUCENE-10406: Oops, didn't check that you'd already

[GitHub] [lucene] romseygeek opened a new pull request #648: LUCENE-10407: Set bpos flag to true when containing filter is exhausted

romseygeek opened a new pull request #648: URL: https://github.com/apache/lucene/pull/648 ContainedByIntervalIterator and OverlappingIntervalIterator set their 'is the filter interval exhausted' flag to `false` once it has returned NO_MORE_POSITIONS on a document, so that subsequen

[jira] [Created] (LUCENE-10407) ContainingIntervalIterator can incorrectly report positions after exhaustion

Alan Woodward created LUCENE-10407: -- Summary: ContainingIntervalIterator can incorrectly report positions after exhaustion Key: LUCENE-10407 URL: https://issues.apache.org/jira/browse/LUCENE-10407 Pr

[GitHub] [lucene] uschindler commented on a change in pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

uschindler commented on a change in pull request #643: URL: https://github.com/apache/lucene/pull/643#discussion_r799601412 ## File path: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java ## @@ -154,6 +153,98 @@ protected BinaryDictiona

[GitHub] [lucene] mikemccand commented on a change in pull request #630: LUCENE-10371 Make IndexRearranger able to arrange segment in a determined order

mikemccand commented on a change in pull request #630: URL: https://github.com/apache/lucene/pull/630#discussion_r799585879 ## File path: lucene/misc/src/java/org/apache/lucene/misc/index/IndexRearranger.java ## @@ -84,6 +112,28 @@ public void execute() throws Exception {

[GitHub] [lucene] msokolov commented on pull request #641: LUCENE-10391: Reuse data structures across HnswGraph#searchLevel calls

msokolov commented on pull request #641: URL: https://github.com/apache/lucene/pull/641#issuecomment-1030105715 re: sharing across searches I agree it gets tricky, but can be bounded RAM if we use some kind of LRU cache as a pool, and in this case the only "compatibility" check is the size

[jira] [Commented] (LUCENE-10406) Incorrect match with disjunction and extends interval

[ https://issues.apache.org/jira/browse/LUCENE-10406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487132#comment-17487132 ] Dawid Weiss commented on LUCENE-10406: -- I didn't have a chance to look yet but I t

[jira] [Created] (LUCENE-10406) Incorrect match with disjunction and extends interval

Dawid Weiss created LUCENE-10406: Summary: Incorrect match with disjunction and extends interval Key: LUCENE-10406 URL: https://issues.apache.org/jira/browse/LUCENE-10406 Project: Lucene - Core

[GitHub] [lucene] msokolov commented on a change in pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

msokolov commented on a change in pull request #643: URL: https://github.com/apache/lucene/pull/643#discussion_r799565983 ## File path: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java ## @@ -154,6 +153,98 @@ protected BinaryDictionary

[jira] [Resolved] (LUCENE-10402) Intervals.prefix() handles multicharacter unicode incorrectly

[ https://issues.apache.org/jira/browse/LUCENE-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-10402. Fix Version/s: 9.1 Assignee: Alan Woodward Resolution: Fixed > Intervals.

[jira] [Commented] (LUCENE-10402) Intervals.prefix() handles multicharacter unicode incorrectly

[ https://issues.apache.org/jira/browse/LUCENE-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487127#comment-17487127 ] ASF subversion and git services commented on LUCENE-10402: -- Co

[jira] [Commented] (LUCENE-10402) Intervals.prefix() handles multicharacter unicode incorrectly

[ https://issues.apache.org/jira/browse/LUCENE-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487126#comment-17487126 ] ASF subversion and git services commented on LUCENE-10402: -- Co

[GitHub] [lucene] romseygeek merged pull request #646: LUCENE-10402: Prefix interval automaton should be declared binary

romseygeek merged pull request #646: URL: https://github.com/apache/lucene/pull/646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [lucene-solr] iverase closed pull request #1538: LUCENE-9368: Use readLELongs to read docIds on BKD leaf nodes

iverase closed pull request #1538: URL: https://github.com/apache/lucene-solr/pull/1538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[GitHub] [lucene-solr] iverase commented on pull request #1538: LUCENE-9368: Use readLELongs to read docIds on BKD leaf nodes

iverase commented on pull request #1538: URL: https://github.com/apache/lucene-solr/pull/1538#issuecomment-1030029995 closing it as there has been a better proposal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene] iverase opened a new pull request #647: LUCENE-10405: MemoryIndex: binary and Sorted doc values are stored as BytesRef instead of BytesRefHash

iverase opened a new pull request #647: URL: https://github.com/apache/lucene/pull/647 This prevents the size limit that imposes BytesRefHash to the size of the doc values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Created] (LUCENE-10405) MemoryIndex: Binary and Sorted doc values should not be added to a BytesRefHash

Ignacio Vera created LUCENE-10405: - Summary: MemoryIndex: Binary and Sorted doc values should not be added to a BytesRefHash Key: LUCENE-10405 URL: https://issues.apache.org/jira/browse/LUCENE-10405 P

[GitHub] [lucene] msokolov commented on pull request #641: LUCENE-10391: Reuse data structures across HnswGraph#searchLevel calls

msokolov commented on pull request #641: URL: https://github.com/apache/lucene/pull/641#issuecomment-1030007403 I think we cannot use intinthashset in core since it's an external dependency? Did it work for you though? On Thu, Feb 3, 2022, 1:36 PM Julie Tibshirani ***@***.***>

[GitHub] [lucene] dweiss commented on pull request #646: LUCENE-10402: Prefix interval automaton should be declared binary

dweiss commented on pull request #646: URL: https://github.com/apache/lucene/pull/646#issuecomment-1029996859 It's quite confusing that different constructors of CompiledAutomaton vary the defaults. You'd expect additional constructor parameters to behave consistently as you use more and m

[jira] [Commented] (LUCENE-10402) Intervals.prefix() handles multicharacter unicode incorrectly

[ https://issues.apache.org/jira/browse/LUCENE-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487065#comment-17487065 ] Alan Woodward commented on LUCENE-10402: I opened a PR with a fix: https://gith

[jira] [Resolved] (LUCENE-10399) Handle large boolean expressions better in flexible query parser

[ https://issues.apache.org/jira/browse/LUCENE-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10399. -- Fix Version/s: (was: 9.1) Resolution: Information Provided > Handle large boolean

[GitHub] [lucene] dweiss closed pull request #634: LUCENE-10399: Handle large boolean expressions better in flexible query parser

dweiss closed pull request #634: URL: https://github.com/apache/lucene/pull/634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [lucene] dweiss commented on pull request #634: LUCENE-10399: Handle large boolean expressions better in flexible query parser

dweiss commented on pull request #634: URL: https://github.com/apache/lucene/pull/634#issuecomment-1029904911 > I get that nobody wants to have to deal with javacc to change the syntax Sure, no worries - I don't have to commit it to Lucene and can apply it externally. Let me e

[GitHub] [lucene] mocobeta edited a comment on pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

mocobeta edited a comment on pull request #643: URL: https://github.com/apache/lucene/pull/643#issuecomment-1029842772 > One thing that I wanted to add: We should add @deprecated(forRemoval=true), this makes builds very noisy if you use the deprecated API. By adding a since="9.1" tag we ma

[GitHub] [lucene] mocobeta edited a comment on pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

mocobeta edited a comment on pull request #643: URL: https://github.com/apache/lucene/pull/643#issuecomment-1029842772 > One thing that I wanted to add: We should add @deprecated(forRemoval=true), this makes builds very noisy if you use the deprecated API. By adding a since="9.1" tag we ma

[GitHub] [lucene] mocobeta commented on pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

mocobeta commented on pull request #643: URL: https://github.com/apache/lucene/pull/643#issuecomment-1029842772 > One thing that I wanted to add: We should add @deprecated(forRemoval=true), this makes builds very noisy if you use the deprecated API. By adding a since="9.1" tag we may also

[GitHub] [lucene] uschindler commented on pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

uschindler commented on pull request #643: URL: https://github.com/apache/lucene/pull/643#issuecomment-1029837934 One thing that I wanted to add: We should add @Deprecated(forRemoval=true), this makes builds very noisy if you use the deprecated API. By adding a since="9.1" tag we may also

[GitHub] [lucene] rmuir commented on pull request #634: LUCENE-10399: Handle large boolean expressions better in flexible query parser

rmuir commented on pull request #634: URL: https://github.com/apache/lucene/pull/634#issuecomment-1029818866 also, just think about the technical benefits if "filtering" (non-scoring) is exposed properly in the parsers. Long term, users adding these kinds of structured clauses today could

[GitHub] [lucene] uschindler commented on a change in pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

uschindler commented on a change in pull request #643: URL: https://github.com/apache/lucene/pull/643#discussion_r799317558 ## File path: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/ConnectionCosts.java ## @@ -61,8 +68,63 @@ public ConnectionCosts(Bina

[GitHub] [lucene] uschindler commented on pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

uschindler commented on pull request #643: URL: https://github.com/apache/lucene/pull/643#issuecomment-1029815750 Hi, I am a bit busy, let me check later! Could take over weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [lucene] jpountz commented on a change in pull request #635: LUCENE-10385: Implement Weight#count on IndexSortSortedNumericDocValuesRangeQuery

jpountz commented on a change in pull request #635: URL: https://github.com/apache/lucene/pull/635#discussion_r799310175 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java ## @@ -195,7 +211,7 @@ public boolean

[GitHub] [lucene] rmuir commented on pull request #634: LUCENE-10399: Handle large boolean expressions better in flexible query parser

rmuir commented on pull request #634: URL: https://github.com/apache/lucene/pull/634#issuecomment-1029809555 sorry @dweiss for the delay. I'm not properly getting email notifications from GH: I dont know why. I randomly looked in the github UI and saw this one right now. Maybe get a

[GitHub] [lucene] ryo0301 commented on a change in pull request #635: LUCENE-10385: Implement Weight#count on IndexSortSortedNumericDocValuesRangeQuery

ryo0301 commented on a change in pull request #635: URL: https://github.com/apache/lucene/pull/635#discussion_r799300144 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java ## @@ -195,7 +211,7 @@ public boolean

[jira] [Commented] (LUCENE-10404) Use hash set for visited nodes in HNSW search?

[ https://issues.apache.org/jira/browse/LUCENE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486894#comment-17486894 ] Adrien Grand commented on LUCENE-10404: --- {quote}For example, on the glove-100-ang

[jira] [Commented] (LUCENE-10401) Seeking on empty doc-value terms dictionaries fails with AIOOBE

[ https://issues.apache.org/jira/browse/LUCENE-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486872#comment-17486872 ] ASF subversion and git services commented on LUCENE-10401: -- Co

[jira] [Resolved] (LUCENE-10401) Seeking on empty doc-value terms dictionaries fails with AIOOBE

[ https://issues.apache.org/jira/browse/LUCENE-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10401. --- Fix Version/s: 9.1 Resolution: Fixed > Seeking on empty doc-value terms dictionaries

[jira] [Commented] (LUCENE-10401) Seeking on empty doc-value terms dictionaries fails with AIOOBE

[ https://issues.apache.org/jira/browse/LUCENE-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486870#comment-17486870 ] ASF subversion and git services commented on LUCENE-10401: -- Co

[GitHub] [lucene] jpountz merged pull request #642: LUCENE-10401: Fix lookups on empty doc-values terms dictionaries.

jpountz merged pull request #642: URL: https://github.com/apache/lucene/pull/642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..