rmuir commented on pull request #634: URL: https://github.com/apache/lucene/pull/634#issuecomment-1029809555
sorry @dweiss for the delay. I'm not properly getting email notifications from GH: I dont know why. I randomly looked in the github UI and saw this one right now. Maybe get a second opinion, I think I am too biased against it. I really feel that people doing `JOIN` shouldn't be doing it with enormous boolean expressions of `AND`'s and `OR`'s. And that if they really should be doing stuff thru thee parsers, it'd be better to add support for things like `BooleanClause.Occur.FILTER`, `TermInSetQuery`, and maybe even `ConstantScoreQuery` to these parsers if we want things like this to be more efficient for them. I get that nobody wants to have to deal with javacc to change the syntax, but to some people, it would probably be less complicated than that massive stream expression, magical options that impact scoring and performance in confusing ways, etc. There's a reason why these kinds of issues turn into bikesheds, and its because hacky solutions / option explosion doesn't scale long-term for the project, the code just becomes insane. I also resent the implication that i don't live in the "real world", that my world is somehow fake, because I push back on such things. I just want code to be clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
