dweiss commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986512645
Sure, no worries. Play around with both. I admit I started hesitating after
your comment - if it wasn't clear from the start to you then perhaps it
wouldn't be clear to anybody else
iverase commented on a change in pull request #486:
URL: https://github.com/apache/lucene/pull/486#discussion_r762755043
##
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##
@@ -361,14 +405,29 @@ private void intersect(IntersectVisitor visitor,
PointT
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453801#comment-17453801
]
ASF subversion and git services commented on LUCENE-10233:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453800#comment-17453800
]
ASF subversion and git services commented on LUCENE-10233:
--
Co
iverase merged pull request #512:
URL: https://github.com/apache/lucene/pull/512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
dsmiley opened a new pull request #519:
URL: https://github.com/apache/lucene/pull/519
nor should asLongValues.
https://issues.apache.org/jira/browse/LUCENE-10252
I could probably do more testing
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/LUCENE-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley reassigned LUCENE-10252:
-
Assignee: David Smiley
> ValueSource.asDoubleValues shouldn't fetch score
> --
mocobeta commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986461817
> Pushed an alternative take, this time without explicit modular
configurations so that we have a choice and see the options.
Oh thanks... I'm not against introducing the cu
mayya-sharipova commented on a change in pull request #416:
URL: https://github.com/apache/lucene/pull/416#discussion_r762700036
##
File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java
##
@@ -56,31 +59,50 @@
public final class HnswGraph extends KnnGraphVa
[
https://issues.apache.org/jira/browse/LUCENE-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453777#comment-17453777
]
Angadpreet Nagpal edited comment on LUCENE-10276 at 12/6/21, 4:43 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453777#comment-17453777
]
Angadpreet Nagpal edited comment on LUCENE-10276 at 12/6/21, 4:32 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453777#comment-17453777
]
Angadpreet Nagpal commented on LUCENE-10276:
Hi Adrian & Mike,
Thanks for
apanimesh061 commented on pull request #412:
URL: https://github.com/apache/lucene/pull/412#issuecomment-986360914
> I think this is done!
>
> Please add an entry to lucene/CHANGES.txt. I propose the following, under
"API Changes":
>
> ```
> * LUCENE-10197: UnifiedHighlight
[
https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453674#comment-17453674
]
David Smiley commented on LUCENE-10197:
---
I think this could be back-ported to 9.x
dweiss commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986296738
@mocobeta Pushed an alternative take, this time without explicit modular
configurations so that we have a choice and see the options. Please feel free
to experiment.
--
This is a
[
https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10287:
---
Fix Version/s: 9.1
> Add jdk.unsupported module to Luke startup script
> --
dweiss commented on pull request #517:
URL: https://github.com/apache/lucene/pull/517#issuecomment-986291520
I grepped for lucene.luke and module-path and these are the only relevant
hits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
uschindler commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-986289333
In contrast to previous drafts, the branch was squashed into one commit.
This makes review easier.
--
This is an automated message from the Apache Git Service.
To respond to t
uschindler opened a new pull request #518:
URL: https://github.com/apache/lucene/pull/518
**INFO: This is a followup of #177: It's the same code base, but with API
changes from JDK 18 applied**
This is just a draft PR for a first insight on memory mapping improvements
in JDK 18+.
apanimesh061 commented on a change in pull request #412:
URL: https://github.com/apache/lucene/pull/412#discussion_r762605564
##
File path:
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java
##
@@ -137,23 +141,24 @@ static UnifiedHighli
uschindler commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986287738
I am not sure what's the right choice. If we don't pass it, it would be
needed on startup explicit. This would be a trap for users of Lucene.
--
This is an automated message f
uschindler commented on pull request #517:
URL: https://github.com/apache/lucene/pull/517#issuecomment-986286447
If there's anything missing (like another startup script mention in some
other readme file), please tell me. I lost overview!
--
This is an automated message from the Apache G
[
https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453663#comment-17453663
]
Uwe Schindler commented on LUCENE-10287:
I opened PR: https://github.com/apache
uschindler opened a new pull request #517:
URL: https://github.com/apache/lucene/pull/517
See https://issues.apache.org/jira/browse/LUCENE-10287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10287:
---
Fix Version/s: 10.0 (main)
9.x
> Add jdk.unsupported module to Luke star
Uwe Schindler created LUCENE-10287:
--
Summary: Add jdk.unsupported module to Luke startup script
Key: LUCENE-10287
URL: https://issues.apache.org/jira/browse/LUCENE-10287
Project: Lucene - Core
dweiss commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986285373
Ok. Maybe not because then you'd need to add it manually for it to be
included in the module graph (even if it's available it wouldn't be included
automatically).
--
This is an a
dweiss commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986285095
Should it be a "requires static" (runtime only) dependency? Since we're not
compiling against it and use reflection to gain access to it?
--
This is an automated message from the
uschindler edited a comment on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986284927
You can easily see the problem if you start luke and then open an index. It
will use NIOFSDirectory when you choose the automatic selection (FSDirectory).
If you use MMap
uschindler commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986284927
You can easily see the problem if you start luke and then open an index. It
will use NIOFSDirectory when you shoose the automatic selection. If you use
MMapDirectoy explicit, it
uschindler edited a comment on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986284668
> Yep, I saw that. It's a bit crappy that we require an unsupported
module... :(
That was always the case. In classpath mode this module is just enabled by
default
uschindler commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986284668
> Yep, I saw that. It's a bit crappy that we require an unsupported
module... :(
That was always the case. In classpath module this moudle is just enabled by
default.
-
dweiss commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986283873
Yep, I saw that. It's a bit crappy that we require an unsupported module...
:(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
uschindler commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986283620
Hi, please see my message on the 9.0 release. Lucene Core needs
jdk.unsupported as "requires", otherwise you can't use MMapDirctory.
For 9.x branch I will provide a hotfix
dsmiley commented on a change in pull request #412:
URL: https://github.com/apache/lucene/pull/412#discussion_r762601545
##
File path:
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java
##
@@ -137,23 +141,24 @@ static UnifiedHighlighter
dweiss commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r762601182
##
File path: gradle/java/modules.gradle
##
@@ -22,7 +22,97 @@ import java.util.stream.Collectors
allprojects {
plugins.withType(JavaPlugin) {
-// C
zhaih commented on pull request #513:
URL: https://github.com/apache/lucene/pull/513#issuecomment-986279976
Thanks! This really makes NFA change a lot easier, when I was making that
change I always complain that we're over-determinizing the automaton
everywhere, and this one along with #48
zhaih commented on a change in pull request #513:
URL: https://github.com/apache/lucene/pull/513#discussion_r762599350
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##
@@ -556,165 +538,84 @@ static RegExp newLeafNode(
* toAutomaton(null) (e
[
https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453652#comment-17453652
]
Haoyu Zhai commented on LUCENE-10229:
-
Sure I can work on a PR :)
> Match offsets
mocobeta commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r762594652
##
File path: gradle/java/modules.gradle
##
@@ -22,7 +22,97 @@ import java.util.stream.Collectors
allprojects {
plugins.withType(JavaPlugin) {
-//
mocobeta commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r762594652
##
File path: gradle/java/modules.gradle
##
@@ -22,7 +22,97 @@ import java.util.stream.Collectors
allprojects {
plugins.withType(JavaPlugin) {
-//
mocobeta commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r762594652
##
File path: gradle/java/modules.gradle
##
@@ -22,7 +22,97 @@ import java.util.stream.Collectors
allprojects {
plugins.withType(JavaPlugin) {
-//
dweiss commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r762592957
##
File path: gradle/java/modules.gradle
##
@@ -22,7 +22,97 @@ import java.util.stream.Collectors
allprojects {
plugins.withType(JavaPlugin) {
-// C
dweiss commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r762592787
##
File path: gradle/java/modules.gradle
##
@@ -22,7 +22,97 @@ import java.util.stream.Collectors
allprojects {
plugins.withType(JavaPlugin) {
-// C
mocobeta commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r762592215
##
File path: gradle/java/modules.gradle
##
@@ -22,7 +22,97 @@ import java.util.stream.Collectors
allprojects {
plugins.withType(JavaPlugin) {
-//
apanimesh061 edited a comment on pull request #412:
URL: https://github.com/apache/lucene/pull/412#issuecomment-986174116
@dsmiley
Updated the PR as per the comments and added the new builder functions.
I also had a question about `SearchTravRetHighlightTask.java`. There were
[
https://issues.apache.org/jira/browse/LUCENE-10286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453633#comment-17453633
]
Dawid Weiss commented on LUCENE-10286:
--
Also, the code contains some remarks about
[
https://issues.apache.org/jira/browse/LUCENE-10286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453632#comment-17453632
]
Dawid Weiss commented on LUCENE-10286:
--
I've pushed a commit to https://github.com
[
https://issues.apache.org/jira/browse/LUCENE-10286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss reassigned LUCENE-10286:
Assignee: Dawid Weiss
> Module path to dependencies that are not automatic modules (acco
[
https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453628#comment-17453628
]
Alan Woodward commented on LUCENE-10229:
That sounds like a good solution [~zha
50 matches
Mail list logo
